From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] net/thunderx: fix MTU configuration for
 jumbo pkts
Date: Wed, 18 Apr 2018 18:03:16 +0100
Message-ID: <47649369-11ad-228a-1730-52c9d1320b57@intel.com>
References: <1523875487-5220-1-git-send-email-nitin.saxena@caviumnetworks.com>
 <20180418045653.GA6696@jerin>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Narayana Prasad <narayanaprasad.athreya@caviumnetworks.com>, dev@dpdk.org
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Nitin Saxena <nitin.saxena@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 68F0A5323
 for <dev@dpdk.org>; Wed, 18 Apr 2018 19:03:20 +0200 (CEST)
In-Reply-To: <20180418045653.GA6696@jerin>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/18/2018 5:56 AM, Jerin Jacob wrote:
> -----Original Message-----
>> Date: Mon, 16 Apr 2018 10:44:47 +0000
>> From: Nitin Saxena <nitin.saxena@caviumnetworks.com>
>> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>> Cc: Nitin Saxena <nitin.saxena@caviumnetworks.com>, Narayana Prasad
>>  <narayanaprasad.athreya@caviumnetworks.com>, dev@dpdk.org
>> Subject: [PATCH] net/thunderx: fix MTU configuration for jumbo pkts
>> X-Mailer: git-send-email 2.7.4
>>
>> thunderx pmd driver passes dev_info.max_rx_pktlen as
>> 9200 (via rte_eth_dev_info_get()) to application.
>> But, when application tries to set MTU as
>> (9200 - sizeof(ethernet_header_t)) the operation fails
>> because of missing CRC and VLAN additions.
>>
>> This patch fixes the following for thunderx pmd driver:
>>  - Sets NIC_HW_MAX_FRS to 9216 (instead of 9200)
>>  - Sets NIC_HW_MAX_MTU to 9190 (NIC_HW_MAX_FRS - ETH_HLEN
>>    - ETHER_CRC_LEN - 2*VLAN_HLEN)
>>  - Sets dev_info->max_rx_pkt_len to NIC_HW_MAX_MTU +
>>    ETH_HLEN (instead of 9200)
>>  - Allows rte_eth_dev_set_mtu() to pass if application
>>    (like VPP) calls rte_eth_dev_set_mtu() before
>>    rte_eth_dev_start() by putting appropriate check for
>>    dev->data->dev_started
>>
>> Fixes: 65d9804edc05 ("net/thunderx: support MTU configuration")
>>
> 
> Cc: stable@dpdk.org
> 
>> Signed-off-by: Nitin Saxena <nitin.saxena@caviumnetworks.com>
> 
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Applied to dpdk-next-net/master, thanks.