All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roberts, William C" <william.c.roberts@intel.com>
To: "'selinux@tycho.nsa.gov'" <selinux@tycho.nsa.gov>,
	"'seandroid-list@tycho.nsa.gov'" <seandroid-list@tycho.nsa.gov>,
	"'sds@tycho.nsa.gov'" <sds@tycho.nsa.gov>
Subject: RE: [PATCH] libsepol: fix memory leak in expand.c
Date: Tue, 9 Aug 2016 16:12:56 +0000	[thread overview]
Message-ID: <476DC76E7D1DF2438D32BFADF679FC56012812D9@ORSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <476DC76E7D1DF2438D32BFADF679FC56012805C4@ORSMSX103.amr.corp.intel.com>

<snip>
> >
> > -      out:
> > +	  out:
> > +	rc = 0;
> >
> > -	ebitmap_destroy(&types);
> > +	  err_neg:
> >  	ebitmap_destroy(&neg_types);
> > +	  err_types:
> > +	ebitmap_destroy(&types);
> >
> > -	return 0;
> > +	return rc;
> >  }

I just noticed the indenting on the label changed, I went through the
File and it has:
1. labels with 7 leading spaces
2. labels left justified

Which one is the way you want them, left justified?

Bill

  reply	other threads:[~2016-08-09 16:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-08 17:28 [PATCH] libsepol: fix memory leak in expand.c william.c.roberts
2016-08-08 17:29 ` Roberts, William C
2016-08-09 16:12   ` Roberts, William C [this message]
2016-08-09 20:26     ` James Carter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=476DC76E7D1DF2438D32BFADF679FC56012812D9@ORSMSX103.amr.corp.intel.com \
    --to=william.c.roberts@intel.com \
    --cc=sds@tycho.nsa.gov \
    --cc=seandroid-list@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.