[U-Boot] [U-Boot,v2] odroid-c2: Enable distro boot

From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot,v2] odroid-c2: Enable distro boot
Date: Sat, 22 Apr 2017 16:51:32 +0200	[thread overview]
Message-ID: <476f8650-e1ea-2861-d12d-608b85c99feb@gmx.de> (raw)
In-Reply-To: <ee49e54d-3ec0-7df9-d5aa-10c87abb73cb@suse.de>

On 04/22/2017 03:10 PM, Andreas Färber wrote:
> Hi,
> 
> Am 22.04.2017 um 14:59 schrieb Heinrich Schuchardt:
>> On 01/15/2017 07:52 PM, Andreas Färber wrote:
>>> Use the generic "distro" boot framework to enable automatic DHCP boot.
>>>
>>> The fdt and kernel addresses are adopted from downstream; ramdisk and
>>> scriptaddr addresses were chosen arbitrarily.
>>>
>>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>>> ---
>> ...
>>> diff --git a/include/configs/odroid-c2.h b/include/configs/odroid-c2.h
>>> index 1d5b3d5..bf7e1af 100644
>>> --- a/include/configs/odroid-c2.h
>>> +++ b/include/configs/odroid-c2.h
>>> @@ -12,6 +12,8 @@
>>>  #define CONFIG_CONS_INDEX		0
>>>  #define CONFIG_BAUDRATE			115200
>>>  
>>> +#define MESON_FDTFILE_SETTING "fdtfile=amlogic/meson-gxbb-odroidc2.dtb\0"
>>
>> Hello Andreas,
>>
>> do you remember why you chose to put meson-gxbb-odroidc2.dtb into
>> subdirectory amlogic?
> 
> I chose that directory name when I added GXBaby support to the kernel:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts
> 
> Note that we had a discussion about this a while ago when I sent patches
> to amend the distro framework's dtb search paths, and Tom's decision was
> to instead hardcode the vendor dirs inside $fdtfile.

The following mail by Tom Rini just mentions the the file name should
match between Linux and U-Boot but does not ask for a vendor
subdirectory hardcoded in fdtfile:
https://lists.denx.de/pipermail/u-boot/2016-April/251709.html

And the dragonboard ended up with fdtfile=apq8016-sbc.dtb without vendor
directory.

Could you, please, refer me to the mail with the decision that you
mentioned.

Regards

Heinrich Schuchardt

> 
>> This breaks package flash-kernel in Debian.
> 
> Then your package may also have problems with the Raspberry Pi 3 and
> further arm64 boards. For sunXi I have a pending patch to fix it. If
> others are not yet doing it, consider it a bug and file patches please.
> 
> Regards,
> Andreas
> 