From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] net/tap: add CRC stripping capability Date: Tue, 13 Feb 2018 17:35:20 +0100 Message-ID: <4788233.rokdTfvtAd@xps> References: <1518509665-12171-1-git-send-email-ophirmu@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Pascal Mazon , Olga Shern , stable@dpdk.org To: Ophir Munk Return-path: In-Reply-To: <1518509665-12171-1-git-send-email-ophirmu@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/02/2018 09:14, Ophir Munk: > CRC stripping is executed in the kernel outside of TAP PMD scope. > There is no prevention that the TAP PMD will report on Rx CRC > stripping capability. > In the corrupted code, TAP PMD did not report on this capability. > The fix enables TAP PMD to report that Rx CRC stripping is supported. > > Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") > Cc: stable@dpdk.org > > Signed-off-by: Ophir Munk Applied, thanks