From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gEYcy-0004zP-US for mharc-grub-devel@gnu.org; Mon, 22 Oct 2018 07:44:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gEYcw-0004yl-IT for grub-devel@gnu.org; Mon, 22 Oct 2018 07:44:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gEYcn-0007kO-97 for grub-devel@gnu.org; Mon, 22 Oct 2018 07:44:03 -0400 Received: from mx2.suse.de ([195.135.220.15]:41392 helo=mx1.suse.de) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gEYck-0007i3-Nn for grub-devel@gnu.org; Mon, 22 Oct 2018 07:43:55 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C00A8ACB8; Mon, 22 Oct 2018 11:43:53 +0000 (UTC) Subject: Re: [PATCH v2 13/18] xen: init memory regions for PVH To: Daniel Kiper Cc: grub-devel@gnu.org, xen-devel@lists.xen.org, phcoder@gmail.com, hans@knorrie.org References: <20181009110317.6022-1-jgross@suse.com> <20181009110317.6022-14-jgross@suse.com> <20181022113139.GC4548@olila.i.net-space.pl> From: Juergen Gross Openpgp: preference=signencrypt Autocrypt: addr=jgross@suse.com; prefer-encrypt=mutual; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNHkp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmRlPsLAeQQTAQIAIwUCU4xw6wIbAwcL CQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJELDendYovxMvi4UH/Ri+OXlObzqMANruTd4N zmVBAZgx1VW6jLc8JZjQuJPSsd/a+bNr3BZeLV6lu4Pf1Yl2Log129EX1KWYiFFvPbIiq5M5 kOXTO8Eas4CaScCvAZ9jCMQCgK3pFqYgirwTgfwnPtxFxO/F3ZcS8jovza5khkSKL9JGq8Nk czDTruQ/oy0WUHdUr9uwEfiD9yPFOGqp4S6cISuzBMvaAiC5YGdUGXuPZKXLpnGSjkZswUzY d9BVSitRL5ldsQCg6GhDoEAeIhUC4SQnT9SOWkoDOSFRXZ+7+WIBGLiWMd+yKDdRG5RyP/8f 3tgGiB6cyuYfPDRGsELGjUaTUq3H2xZgIPfOwE0EU4xwFgEIAMsx+gDjgzAY4H1hPVXgoLK8 B93sTQFN9oC6tsb46VpxyLPfJ3T1A6Z6MVkLoCejKTJ3K9MUsBZhxIJ0hIyvzwI6aYJsnOew cCiCN7FeKJ/oA1RSUemPGUcIJwQuZlTOiY0OcQ5PFkV5YxMUX1F/aTYXROXgTmSaw0aC1Jpo w7Ss1mg4SIP/tR88/d1+HwkJDVW1RSxC1PWzGizwRv8eauImGdpNnseneO2BNWRXTJumAWDD pYxpGSsGHXuZXTPZqOOZpsHtInFyi5KRHSFyk2Xigzvh3b9WqhbgHHHE4PUVw0I5sIQt8hJq 5nH5dPqz4ITtCL9zjiJsExHuHKN3NZsAEQEAAcLAXwQYAQIACQUCU4xwFgIbDAAKCRCw3p3W KL8TL0P4B/9YWver5uD/y/m0KScK2f3Z3mXJhME23vGBbMNlfwbr+meDMrJZ950CuWWnQ+d+ Ahe0w1X7e3wuLVODzjcReQ/v7b4JD3wwHxe+88tgB9byc0NXzlPJWBaWV01yB2/uefVKryAf AHYEd0gCRhx7eESgNBe3+YqWAQawunMlycsqKa09dBDL1PFRosF708ic9346GLHRc6Vj5SRA UTHnQqLetIOXZm3a2eQ1gpQK9MmruO86Vo93p39bS1mqnLLspVrL4rhoyhsOyh0Hd28QCzpJ wKeHTd0MAWAirmewHXWPco8p1Wg+V+5xfZzuQY0f4tQxvOpXpt4gQ1817GQ5/Ed/wsDtBBgB CAAgFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAlrd8NACGwIAgQkQsN6d1ii/Ey92IAQZFggA HRYhBFMtsHpB9jjzHji4HoBcYbtP2GO+BQJa3fDQAAoJEIBcYbtP2GO+TYsA/30H/0V6cr/W V+J/FCayg6uNtm3MJLo4rE+o4sdpjjsGAQCooqffpgA+luTT13YZNV62hAnCLKXH9n3+ZAgJ RtAyDWk1B/0SMDVs1wxufMkKC3Q/1D3BYIvBlrTVKdBYXPxngcRoqV2J77lscEvkLNUGsu/z W2pf7+P3mWWlrPMJdlbax00vevyBeqtqNKjHstHatgMZ2W0CFC4hJ3YEetuRBURYPiGzuJXU pAd7a7BdsqWC4o+GTm5tnGrCyD+4gfDSpkOT53S/GNO07YkPkm/8J4OBoFfgSaCnQ1izwgJQ jIpcG2fPCI2/hxf2oqXPYbKr1v4Z1wthmoyUgGN0LPTIm+B5vdY82wI5qe9uN6UOGyTH2B3p hRQUWqCwu2sqkI3LLbTdrnyDZaixT2T0f4tyF5Lfs+Ha8xVMhIyzNb1byDI5FKCb Message-ID: <478b4b66-2218-d475-19c8-24237355e4c6@suse.com> Date: Mon, 22 Oct 2018 13:43:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181022113139.GC4548@olila.i.net-space.pl> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 195.135.220.15 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2018 11:44:07 -0000 On 22/10/2018 13:31, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:12PM +0200, Juergen Gross wrote: >> Add all usable memory regions to grub memory management and add the >> needed mmap iterate code. > > I am missing a few words why this patch is needed. Especially why > grub_machine_mmap_iterate() has to belong to this patch. However, > I think that it should be introduced by patch in which > grub_machine_mmap_iterate() is used at some point. That would again lead to one giant PVH patch which you didn't like. grub_machine_mmap_iterate() is being used by grub common code like grub-core/lib/relocator.c or grub-core/mmap/mmap.c grub_machine_mmap_iterate() belongs into this patch as it is the main user of the memory map introduced here. Juergen > >> As we are running in 32-bit mode don't add memory above 4GB. >> >> Signed-off-by: Juergen Gross >> --- >> grub-core/kern/i386/xen/pvh.c | 35 +++++++++++++++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> >> diff --git a/grub-core/kern/i386/xen/pvh.c b/grub-core/kern/i386/xen/pvh.c >> index 93ed68245..c4a8bccf4 100644 >> --- a/grub-core/kern/i386/xen/pvh.c >> +++ b/grub-core/kern/i386/xen/pvh.c >> @@ -222,6 +222,30 @@ grub_xen_get_mmap (void) >> grub_xen_sort_mmap (); >> } >> >> +static void >> +grub_xen_mm_init_regions (void) >> +{ >> + grub_uint64_t modend, from, to; >> + unsigned int i; >> + >> + modend = grub_modules_get_end (); >> + >> + for (i = 0; i < nr_map_entries; i++) >> + { >> + if (map[i].type != GRUB_MEMORY_AVAILABLE) >> + continue; >> + from = map[i].addr; >> + to = from + map[i].len; >> + if (from < modend) >> + from = modend; >> + if (from >= to || from >= 0x100000000ULL) >> + continue; >> + if (to > 0x100000000ULL) >> + to = 0x100000000ULL; >> + grub_mm_init_region ((void *) (grub_addr_t) from, to - from); >> + } >> +} >> + >> static grub_uint64_t >> grub_xen_find_page (grub_uint64_t start) >> { >> @@ -302,10 +326,21 @@ grub_xen_setup_pvh (void) >> grub_xen_shared_info = grub_xen_add_physmap (XENMAPSPACE_shared_info, >> (void *) par); >> >> + grub_xen_mm_init_regions (); >> + >> grub_rsdp_addr = pvh_start_info->rsdp_paddr; >> } >> >> grub_err_t >> grub_machine_mmap_iterate (grub_memory_hook_t hook, void *hook_data) >> { >> + unsigned int i; >> + >> + for (i = 0; i < nr_map_entries; i++) >> + { >> + if (map[i].len && hook (map[i].addr, map[i].len, map[i].type, hook_data)) >> + break; >> + } >> + >> + return GRUB_ERR_NONE; > > Daniel >