All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [Qemu-devel] [PATCH v3 5/5] tests: add a m25p80 test
Date: Thu, 23 Jun 2016 21:09:24 +0200	[thread overview]
Message-ID: <4798b3f1-078c-22c3-26f9-925e2b93a0ef@kaod.org> (raw)
In-Reply-To: <CAFEAcA832Wa0wjSvSrAkmy5K3-jjLXgFtCs3RkK499V5W1vVNg@mail.gmail.com>

On 06/23/2016 08:52 PM, Peter Maydell wrote:
> On 23 June 2016 at 17:33, Cédric Le Goater <clg@kaod.org> wrote:
>> This test uses the palmetto platform and the AST2400 SPI controller to
>> test the m25p80 flash module device model. The flash model is defined
>> by the platform (n25q256a) and it would be nice to find way to control
>> it, using a property probably.
>>
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>> ---
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 
> Are you in a position to check this test passes on both a
> bigendian and little endian host? I have no specific reason
> to think it will fail, but it seems worth checking.
> (If not, it'll get tested when I do a merge eventually.)

I can do bigendian on a p7/ppc64 host. I will check that when 
I have addressed all your comments.

Thanks for the review.

C.

      reply	other threads:[~2016-06-23 19:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-23 16:33 [Qemu-devel] [PATCH v3 0/5] ast2400: SMC controllers Cédric Le Goater
2016-06-23 16:33 ` [Qemu-devel] [PATCH v3 1/5] m25p80: qdev-ify drive property Cédric Le Goater
2016-06-23 18:35   ` Peter Maydell
2016-06-24 11:49     ` Cédric Le Goater
2016-06-23 16:33 ` [Qemu-devel] [PATCH v3 2/5] ast2400: add SMC controllers (FMC and SPI) Cédric Le Goater
2016-06-23 18:43   ` Peter Maydell
2016-06-24 13:30     ` Cédric Le Goater
2016-06-23 16:33 ` [Qemu-devel] [PATCH v3 3/5] ast2400: add SPI flash slave object Cédric Le Goater
2016-06-23 18:56   ` Peter Maydell
2016-06-24 13:47     ` Cédric Le Goater
2016-06-23 16:33 ` [Qemu-devel] [PATCH v3 4/5] ast2400: create SPI flash slaves Cédric Le Goater
2016-06-23 18:48   ` Peter Maydell
2016-06-24 13:42     ` Cédric Le Goater
2016-06-23 16:33 ` [Qemu-devel] [PATCH v3 5/5] tests: add a m25p80 test Cédric Le Goater
2016-06-23 18:52   ` Peter Maydell
2016-06-23 19:09     ` Cédric Le Goater [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4798b3f1-078c-22c3-26f9-925e2b93a0ef@kaod.org \
    --to=clg@kaod.org \
    --cc=andrew@aj.id.au \
    --cc=armbru@redhat.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.