From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06438C43334 for ; Wed, 29 Jun 2022 11:32:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232682AbiF2LcL (ORCPT ); Wed, 29 Jun 2022 07:32:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232389AbiF2LcK (ORCPT ); Wed, 29 Jun 2022 07:32:10 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7B363EF0A for ; Wed, 29 Jun 2022 04:32:05 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id d2so20224393ejy.1 for ; Wed, 29 Jun 2022 04:32:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=z7YdxvHVrANcl7/MwaXyOEvtHd06mWAjfHecZi9wxDA=; b=wGH6hq8FO42nMsH7uuRTjyg1xyAs0bk732kzq6bPIZKP0VVWLVmchGvj9wufryAbMo 7EbCmPP9FkNAA5gjUP1pNiMUBQpHEvmLP0S30OiA++FnBwbAlKpc9MLUms6jkTLdjSCy dBeCogdBD6h+ETxna6DBOJw17214BgCxfr7+Ctyda3FWsG1Dnu1KWxS8VxeURS92tSmC K7qMbqF0eGzhSNME+tftxIeWCND/9y0h9zRR9DE6NLa6i+0639DI4Zg57KZ40NkKK0gA DgaReJvdAUvZrO5GjBW7M4kCsaxdbP9kOQ1F7VobumPa3sa3E68YFkr95E6aWjEQepk+ tZxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=z7YdxvHVrANcl7/MwaXyOEvtHd06mWAjfHecZi9wxDA=; b=y+wNitEHfDpGPVvyoc/kTI+3kcdjPiSyqhltFBM41Mevf0nUQFo+Ner4WEvwTTAi+f tggj5+UbSmIMQr+ouwN7gY08xKKDj0F8ifwyGXtGOIcXVxRkmX8d6pJq+qxLu/8WJue9 Fq3EpWPhV74NqjtK+ozx9c2nSmUGTVUJaK5JcLnTQqUbftFUGzjRo4n13widABt4Ts0P YAP0DWQmP/j3mxrSwTX7t9dD2DUmlHhI263/KjAR5jJchvnoVYfkl1vVvnkHwpRrClm4 1vjOW8Whx/pBkj7Dxz+0UwIoOz7n0/gkeQuH1N8THGoi+EydJ3/xI2pgD/SXsgzIAc9v ke/w== X-Gm-Message-State: AJIora+PTuBgGpZIC0f3HEj8PpSSUlzPGJPnZtiRu7noRUCgLXOLC3t6 PKMvuHj16OkwoFwsaTbiZvqKXg== X-Google-Smtp-Source: AGRyM1vCAkX9bFVsQfuTLGX2ok/ViPnL2u3W6VZSGnPeXBWryLaSYEnMX7e/7rGW7Grc+BVzqHHXaw== X-Received: by 2002:a17:906:1ca:b0:715:73f3:b50f with SMTP id 10-20020a17090601ca00b0071573f3b50fmr2799072ejj.374.1656502324385; Wed, 29 Jun 2022 04:32:04 -0700 (PDT) Received: from [192.168.0.184] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id fx24-20020a170906b75800b006fec63e564bsm7616985ejb.30.2022.06.29.04.32.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jun 2022 04:32:03 -0700 (PDT) Message-ID: <479a021a-36eb-7b44-9e14-51e16d1b64fb@linaro.org> Date: Wed, 29 Jun 2022 13:32:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v5 4/4] arm64: dts: qcom: sdm845: Add CPU BWMON Content-Language: en-US To: Rajendra Nayak , Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Thara Gopinath References: <20220629075250.17610-1-krzysztof.kozlowski@linaro.org> <20220629075250.17610-5-krzysztof.kozlowski@linaro.org> <87b83a0c-0ea2-6839-1d90-8f1145ed9ed2@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <87b83a0c-0ea2-6839-1d90-8f1145ed9ed2@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 29/06/2022 13:22, Rajendra Nayak wrote: > > > On 6/29/2022 1:22 PM, Krzysztof Kozlowski wrote: >> Add device node for CPU-memory BWMON device (bandwidth monitoring) on >> SDM845 measuring bandwidth between CPU (gladiator_noc) and Last Level >> Cache (memnoc). Usage of this BWMON allows to remove fixed bandwidth >> votes from cpufreq (CPU nodes) thus achieve high memory throughput even >> with lower CPU frequencies. >> >> Co-developed-by: Thara Gopinath >> Signed-off-by: Thara Gopinath >> Signed-off-by: Krzysztof Kozlowski >> --- >> arch/arm64/boot/dts/qcom/sdm845.dtsi | 38 ++++++++++++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> index 83e8b63f0910..e0f088996390 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> @@ -2026,6 +2026,44 @@ llcc: system-cache-controller@1100000 { >> interrupts = ; >> }; >> >> + pmu@1436400 { >> + compatible = "qcom,sdm845-cpu-bwmon", "qcom,msm8998-cpu-bwmon"; >> + reg = <0 0x01436400 0 0x600>; >> + interrupts = ; >> + interconnects = <&gladiator_noc MASTER_APPSS_PROC 3 &mem_noc SLAVE_LLCC 3>; >> + >> + operating-points-v2 = <&cpu_bwmon_opp_table>; >> + >> + cpu_bwmon_opp_table: opp-table { >> + compatible = "operating-points-v2"; >> + >> + /* >> + * The interconnect paths bandwidths taken from >> + * cpu4_opp_table bandwidth. >> + * They also match different tables from >> + * msm-4.9 downstream kernel: >> + * - the OSM L3 from bandwidth table of >> + * qcom,cpu4-l3lat-mon (qcom,core-dev-table); >> + * bus width: 16 bytes; >> + */ > > Maybe the comment needs an update? Yes, a bit. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 161C2C43334 for ; Wed, 29 Jun 2022 11:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zS7CjZm3FqXxj87TGa9av524HXISm/m5DI6Xv+hdIt8=; b=Yv5Xg5cYUrFkIo QTP/W1ZWIgU8uCGiTtn64Pl7feC9De0R6UO4sS8nY7ddeFe8U771Sr8kjTd4JQ5Onvy0IP+OKDyLO mld6LVbFEV36kA5e+tFEhdjObr0EihT+mCIQrhvW0Ziw4q+ZVzRSom9pivfLQ0leRKPYSYTmNO1oc iIjWcx1WUtnZQ3C1x06N07LvdvTOZgGdvgOeVMbR9V0m557k7wU8LrKEhhrFVujR7ZWRks7rGwDfn UG3iGsvXVrBTKDWs7m8a0JdDyRoeVHT8ekFSoRUvCFjQY6HOOtJY/AxSIhrpDThfq25iMZ4YmYwEe G7+zb9vJowpi0/zP5QEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6W07-00BULp-R3; Wed, 29 Jun 2022 11:36:56 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6VvS-00BSDU-Hs for linux-arm-kernel@lists.infradead.org; Wed, 29 Jun 2022 11:32:10 +0000 Received: by mail-ej1-x62e.google.com with SMTP id h23so31883457ejj.12 for ; Wed, 29 Jun 2022 04:32:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=z7YdxvHVrANcl7/MwaXyOEvtHd06mWAjfHecZi9wxDA=; b=wGH6hq8FO42nMsH7uuRTjyg1xyAs0bk732kzq6bPIZKP0VVWLVmchGvj9wufryAbMo 7EbCmPP9FkNAA5gjUP1pNiMUBQpHEvmLP0S30OiA++FnBwbAlKpc9MLUms6jkTLdjSCy dBeCogdBD6h+ETxna6DBOJw17214BgCxfr7+Ctyda3FWsG1Dnu1KWxS8VxeURS92tSmC K7qMbqF0eGzhSNME+tftxIeWCND/9y0h9zRR9DE6NLa6i+0639DI4Zg57KZ40NkKK0gA DgaReJvdAUvZrO5GjBW7M4kCsaxdbP9kOQ1F7VobumPa3sa3E68YFkr95E6aWjEQepk+ tZxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=z7YdxvHVrANcl7/MwaXyOEvtHd06mWAjfHecZi9wxDA=; b=Tuxlkg+S9MinuYwhiA8kk8keEOYyxLGWHANiEQWz4PkwJ8ssfvjqfRNTVX3v+UaMGw MSplNimz5YUk4hGYNkTk+oM8h59mA7ttqVDB750Cu50YdwD4SixlLwoBE+buQipTRpun 3I/aHbV9tmWuve9P5R+nO+ZGZA0TIivWSQuqfy9VCoTxoIhO9RvlVJIpOrXJbYsFVgL2 dTM2rObO2CQoFx6xLYTTHyU3IbO6bavHcHxyP4SOmoCuf8iunlzcwqxXA/ekhieU5zIp 5nhKAD5Wo39z/Ti2rVWikHUICkxD/tj/Yeyp13CfwSNJ56w6LkaixZE3zj6r6Q9TNhGj SDPA== X-Gm-Message-State: AJIora93d2owSQNT3rP23M/akXK+PVcR68sN6VxCYZ1N34M/PkPaP+F6 3cKzlrGuPv3ZytcAmcjkiO+NEg== X-Google-Smtp-Source: AGRyM1vCAkX9bFVsQfuTLGX2ok/ViPnL2u3W6VZSGnPeXBWryLaSYEnMX7e/7rGW7Grc+BVzqHHXaw== X-Received: by 2002:a17:906:1ca:b0:715:73f3:b50f with SMTP id 10-20020a17090601ca00b0071573f3b50fmr2799072ejj.374.1656502324385; Wed, 29 Jun 2022 04:32:04 -0700 (PDT) Received: from [192.168.0.184] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id fx24-20020a170906b75800b006fec63e564bsm7616985ejb.30.2022.06.29.04.32.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jun 2022 04:32:03 -0700 (PDT) Message-ID: <479a021a-36eb-7b44-9e14-51e16d1b64fb@linaro.org> Date: Wed, 29 Jun 2022 13:32:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v5 4/4] arm64: dts: qcom: sdm845: Add CPU BWMON Content-Language: en-US To: Rajendra Nayak , Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Thara Gopinath References: <20220629075250.17610-1-krzysztof.kozlowski@linaro.org> <20220629075250.17610-5-krzysztof.kozlowski@linaro.org> <87b83a0c-0ea2-6839-1d90-8f1145ed9ed2@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <87b83a0c-0ea2-6839-1d90-8f1145ed9ed2@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220629_043206_709620_7ED65413 X-CRM114-Status: GOOD ( 15.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29/06/2022 13:22, Rajendra Nayak wrote: > > > On 6/29/2022 1:22 PM, Krzysztof Kozlowski wrote: >> Add device node for CPU-memory BWMON device (bandwidth monitoring) on >> SDM845 measuring bandwidth between CPU (gladiator_noc) and Last Level >> Cache (memnoc). Usage of this BWMON allows to remove fixed bandwidth >> votes from cpufreq (CPU nodes) thus achieve high memory throughput even >> with lower CPU frequencies. >> >> Co-developed-by: Thara Gopinath >> Signed-off-by: Thara Gopinath >> Signed-off-by: Krzysztof Kozlowski >> --- >> arch/arm64/boot/dts/qcom/sdm845.dtsi | 38 ++++++++++++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> index 83e8b63f0910..e0f088996390 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> @@ -2026,6 +2026,44 @@ llcc: system-cache-controller@1100000 { >> interrupts = ; >> }; >> >> + pmu@1436400 { >> + compatible = "qcom,sdm845-cpu-bwmon", "qcom,msm8998-cpu-bwmon"; >> + reg = <0 0x01436400 0 0x600>; >> + interrupts = ; >> + interconnects = <&gladiator_noc MASTER_APPSS_PROC 3 &mem_noc SLAVE_LLCC 3>; >> + >> + operating-points-v2 = <&cpu_bwmon_opp_table>; >> + >> + cpu_bwmon_opp_table: opp-table { >> + compatible = "operating-points-v2"; >> + >> + /* >> + * The interconnect paths bandwidths taken from >> + * cpu4_opp_table bandwidth. >> + * They also match different tables from >> + * msm-4.9 downstream kernel: >> + * - the OSM L3 from bandwidth table of >> + * qcom,cpu4-l3lat-mon (qcom,core-dev-table); >> + * bus width: 16 bytes; >> + */ > > Maybe the comment needs an update? Yes, a bit. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel