From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50946)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefan.weil@weilnetz.de>) id 1c6D2r-0008IK-65
	for qemu-devel@nongnu.org; Mon, 14 Nov 2016 03:55:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefan.weil@weilnetz.de>) id 1c6D2m-00015I-8p
	for qemu-devel@nongnu.org; Mon, 14 Nov 2016 03:55:17 -0500
Received: from mail.weilnetz.de ([37.221.199.173]:34648)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefan.weil@weilnetz.de>) id 1c6D2m-000145-3a
	for qemu-devel@nongnu.org; Mon, 14 Nov 2016 03:55:12 -0500
References: <cover.1478863621.git.vpalatin@chromium.org>
	<147900720399.226.10800365976960745863@9040ca97f87d>
	<CAP_ceTwwzTrMgCdujGD7s3gSvi6vqJ_RdZZJQ3EfUQuGb_dpOg@mail.gmail.com>
From: Stefan Weil <stefan.weil@weilnetz.de>
Message-ID: <479b2523-f7f7-2a65-4fda-57084714d07f@weilnetz.de>
Date: Mon, 14 Nov 2016 09:55:07 +0100
MIME-Version: 1.0
In-Reply-To: <CAP_ceTwwzTrMgCdujGD7s3gSvi6vqJ_RdZZJQ3EfUQuGb_dpOg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 0/5] [RFC] Add HAX support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Vincent Palatin <vpalatin@chromium.org>, famz@redhat.com
Cc: qemu-devel <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>

On 11/14/16 09:21, Vincent Palatin wrote:
> On Sun, Nov 13, 2016 at 4:20 AM,  <no-reply@patchew.org> wrote:
>>
>> === OUTPUT BEGIN ===
>> fatal: unrecognized argument: --no-patch
>> Checking PATCH 1/5: ...
>> fatal: unrecognized argument: --no-patch
>> Checking PATCH 2/5: ...
>> fatal: unrecognized argument: --no-patch
>> Checking PATCH 3/5: ...
>> fatal: unrecognized argument: --no-patch
>> Checking PATCH 4/5: ...
>> fatal: unrecognized argument: --no-patch
>> Checking PATCH 5/5: ...
>> ERROR: spaces required around that '-' (ctx:WxV)
>> #158: FILE: cpus.c:1276:
>> +        if (SuspendThread(cpu->hThread) == (DWORD) -1) {
>>                                                     ^
>>
>> ERROR: spaces required around that '-' (ctx:WxV)
>> #176: FILE: cpus.c:1294:
>> +        if (ResumeThread(cpu->hThread) == (DWORD) -1) {
>>                                                    ^
>>
>
> Apparently I missed this couple of warnings when I did my final checkpatch pass.
> At the same time, I have no idea how to solve this one, can anybody
> enlighten me ?
> Having a space on both sides of a unary minus doesn't seem what we want,
> so I imagine something else is wrong and confuse a bit checkpatch.pl.


(DWORK)(-1) works for checkpatch.pl.

I noticed a strange behaviour of checkpatch.pl:

If I run it on all of your five commits, it does not find any error.
If I run it only on the 5th commit, it shows the two errors like above.

Stefan