From mboxrd@z Thu Jan  1 00:00:00 1970
From: Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [v4,1/5] eventdev: introduce event crypto adapter
Date: Wed, 9 May 2018 12:31:49 +0530
Message-ID: <479d6bf8-c0aa-620a-1946-0a209a279c59@nxp.com>
References: <1525808764-109595-1-git-send-email-abhinandan.gujjar@intel.com>
 <1525808764-109595-2-git-send-email-abhinandan.gujjar@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: narender.vangati@intel.com, nikhil.rao@intel.com, gage.eads@intel.com
To: Abhinandan Gujjar <abhinandan.gujjar@intel.com>,
 jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, akhil.goyal@nxp.com,
 dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01on0043.outbound.protection.outlook.com [104.47.0.43])
 by dpdk.org (Postfix) with ESMTP id F251E3195
 for <dev@dpdk.org>; Wed,  9 May 2018 09:02:05 +0200 (CEST)
In-Reply-To: <1525808764-109595-2-git-send-email-abhinandan.gujjar@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/9/2018 1:16 AM, Abhinandan Gujjar wrote:
> Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Signed-off-by: Gage Eads <gage.eads@intel.com>
> ---
[...]

> +
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this structure may change without prior notice
> + *
> + * Crypto event metadata structure will be filled by application
> + * to provide crypto request and event response information.
> + *
> + * If crypto events are enqueued using a HW mechanism, the cryptodev
> + * PMD will use the event response information to set up the event
> + * that is enqueued back to eventdev after completion of the crypto
> + * operation. If the transfer is done by SW, event response information
> + * will be used by the adapter.
> + */
> +union rte_event_crypto_metadata {
> +	struct rte_event_crypto_request request_info;
> +	/**< Request information to be filled in by application
> +	 * for RTE_EVENT_CRYPTO_ADAPTER_OP_NEW mode.
> +	 */
> +	struct rte_event response_info;
> +	/**< Response information to be filled in by application
> +	 * for RTE_EVENT_CRYPTO_ADAPTER_OP_NEW and
> +	 * RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD mode.
> +	 */
> +};
I think the comments are not correct. It was correct in previous version.
request is for only forward mode and response is for both.

Apart from this:

Patch Series
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>