From: maxg@mellanox.com (Max Gurtovoy)
Subject: [PATCH 2/7] nvme-rdma: fix possible free non-allocated async event buffer
Date: Wed, 20 Jun 2018 15:02:01 +0300 [thread overview]
Message-ID: <479f91be-2a8c-ae01-fee1-71fa2e18372f@mellanox.com> (raw)
In-Reply-To: <20180620083159.GB3284@lst.de>
On 6/20/2018 11:31 AM, Christoph Hellwig wrote:
> On Tue, Jun 19, 2018@03:34:10PM +0300, Sagi Grimberg wrote:
>> If nvme_rdma_configure_admin_queue fails before we allocated
>> the async event buffer, we will falsly free it because nvme_rdma_free_queue
>> is freeing it. Fix it by allocating the buffer right after nvme_rdma_alloc_queue
>> and free it right before nvme_rdma_queue_free to maintain orderly reverse cleanup
>> sequence.
>
> This looks much nicer indeed.
>
Looks good,
Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
next prev parent reply other threads:[~2018-06-20 12:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 12:34 [PATCH 0/7] few nvme-rdma fixes for 4.18 Sagi Grimberg
2018-06-19 12:34 ` [PATCH 1/7] nvme-rdma: fix possible double free condition when failing to create a controller Sagi Grimberg
2018-06-20 9:06 ` Max Gurtovoy
2018-06-20 10:41 ` Sagi Grimberg
2018-06-20 12:29 ` Christoph Hellwig
2018-06-19 12:34 ` [PATCH 2/7] nvme-rdma: fix possible free non-allocated async event buffer Sagi Grimberg
2018-06-20 8:31 ` Christoph Hellwig
2018-06-20 12:02 ` Max Gurtovoy [this message]
2018-06-24 10:40 ` [Suspected-Phishing]Re: " Max Gurtovoy
2018-06-24 16:00 ` Sagi Grimberg
2018-06-24 16:19 ` Max Gurtovoy
2018-06-19 12:34 ` [PATCH 3/7] nvme-rdma: Fix command completion race at error recovery Sagi Grimberg
2018-06-19 12:34 ` [PATCH 4/7] nvme-rdma: unquiesce queues when deleting the controller Sagi Grimberg
2018-06-21 9:57 ` Max Gurtovoy
2018-06-24 16:07 ` Sagi Grimberg
2018-06-19 12:34 ` [PATCH 5/7] nvme-rdma: don't override opts->queue_size Sagi Grimberg
2018-06-19 16:56 ` Daniel Verkamp
2018-06-19 12:34 ` [PATCH 6/7] nvme-rdma: centralize controller setup sequence Sagi Grimberg
2018-06-19 12:34 ` [PATCH 7/7] nvme-rdma: centralize admin/io queue teardown sequence Sagi Grimberg
2018-06-20 8:40 ` [PATCH 0/7] few nvme-rdma fixes for 4.18 Christoph Hellwig
2018-06-20 8:40 ` Sagi Grimberg
2018-06-20 8:52 ` Christoph Hellwig
2018-06-20 8:53 ` Sagi Grimberg
2018-06-20 9:05 ` Christoph Hellwig
2018-06-20 9:08 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479f91be-2a8c-ae01-fee1-71fa2e18372f@mellanox.com \
--to=maxg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.