All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Knutsson <ricknu-0@student.ltu.se>
To: caglar@pardus.org.tr
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net,
	torvalds@linux-foundation.org, hidave.darkstar@gmail.com,
	marcel@holtmann.org
Subject: Re: [PATCH] Silent compiler warning introduced by acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.)
Date: Sun, 10 Feb 2008 10:52:01 +0100	[thread overview]
Message-ID: <47AEC941.1070504@student.ltu.se> (raw)
In-Reply-To: <200802100457.20143.caglar@pardus.org.tr>

S.Çağlar Onur wrote:
> Hi;
>
> Following patch silents
>
> net/bluetooth/hci_sysfs.c: In function `del_conn':
> net/bluetooth/hci_sysfs.c:339: warning: suggest parentheses around assignment used as truth value
>
> compiler warning introduced by commit acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.)
>
> Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr>
>
>  net/bluetooth/hci_sysfs.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/bluetooth/hci_sysfs.c b/net/bluetooth/hci_sysfs.c
> index e13cf5e..d2d1e4f 100644
> --- a/net/bluetooth/hci_sysfs.c
> +++ b/net/bluetooth/hci_sysfs.c
> @@ -336,7 +336,7 @@ static void del_conn(struct work_struct *work)
>  	struct device *dev;
>  	struct hci_conn *conn = container_of(work, struct hci_conn, work);
>  
> -	while (dev = device_find_child(&conn->dev, NULL, __match_tty)) {
> +	while ((dev = device_find_child(&conn->dev, NULL, __match_tty)) != NULL) {
>   
Why do you need '!= NULL'?


  reply	other threads:[~2008-02-10  9:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-10  2:57 [PATCH] Silent compiler warning introduced by acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.) S.Çağlar Onur
2008-02-10  9:52 ` Richard Knutsson [this message]
2008-02-10 14:21   ` S.Çağlar Onur
2008-02-10 18:58     ` Linus Torvalds
2008-02-10 22:05       ` S.Çağlar Onur
2008-02-11 12:53         ` Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47AEC941.1070504@student.ltu.se \
    --to=ricknu-0@student.ltu.se \
    --cc=caglar@pardus.org.tr \
    --cc=davem@davemloft.net \
    --cc=hidave.darkstar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.