From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C50C432C3 for ; Thu, 14 Nov 2019 09:08:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B808C20715 for ; Thu, 14 Nov 2019 09:08:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727275AbfKNJIX (ORCPT ); Thu, 14 Nov 2019 04:08:23 -0500 Received: from bilbo.ozlabs.org ([203.11.71.1]:40815 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727205AbfKNJIV (ORCPT ); Thu, 14 Nov 2019 04:08:21 -0500 Received: by ozlabs.org (Postfix, from userid 1034) id 47DFy90198z9sSZ; Thu, 14 Nov 2019 20:08:16 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 7d8212747435c534c8d564fbef4541a463c976ff In-Reply-To: <20191031142933.10779-2-david@redhat.com> To: David Hildenbrand , linux-kernel@vger.kernel.org From: Michael Ellerman Cc: David Hildenbrand , Konstantin Khlebnikov , Greg Kroah-Hartman , linux-mm@kvack.org, Paul Mackerras , Allison Randal , Arun KS , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Thomas Gleixner , Vlastimil Babka Subject: Re: [PATCH v1 01/12] powerpc/pseries: CMM: Implement release() function for sysfs device Message-Id: <47DFy90198z9sSZ@ozlabs.org> Date: Thu, 14 Nov 2019 20:08:16 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-10-31 at 14:29:22 UTC, David Hildenbrand wrote: > When unloading the module, one gets > [ 548.188594] ------------[ cut here ]------------ > [ 548.188596] Device 'cmm0' does not have a release() function, it is brok= > en and must be fixed. See Documentation/kobject.txt. > [ 548.188622] WARNING: CPU: 0 PID: 19308 at drivers/base/core.c:1244 .devi= > ce_release+0xcc/0xf0 > ... > > We only have on static fake device. There is nothing to do when > releasing the device (via cmm_exit). > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Andrew Morton > Cc: Vlastimil Babka > Cc: Konstantin Khlebnikov > Cc: Allison Randal > Cc: Greg Kroah-Hartman > Cc: Thomas Gleixner > Cc: Arun KS > Signed-off-by: David Hildenbrand Patches 1-10 applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/7d8212747435c534c8d564fbef4541a463c976ff cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 061DDC432C3 for ; Thu, 14 Nov 2019 10:17:55 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BCD0206EF for ; Thu, 14 Nov 2019 10:17:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BCD0206EF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47DHVS3GjgzF52B for ; Thu, 14 Nov 2019 21:17:52 +1100 (AEDT) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47DFyD3FkSzF5jm for ; Thu, 14 Nov 2019 20:08:20 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: by ozlabs.org (Postfix, from userid 1034) id 47DFy90198z9sSZ; Thu, 14 Nov 2019 20:08:16 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 7d8212747435c534c8d564fbef4541a463c976ff In-Reply-To: <20191031142933.10779-2-david@redhat.com> To: David Hildenbrand , linux-kernel@vger.kernel.org From: Michael Ellerman Subject: Re: [PATCH v1 01/12] powerpc/pseries: CMM: Implement release() function for sysfs device Message-Id: <47DFy90198z9sSZ@ozlabs.org> Date: Thu, 14 Nov 2019 20:08:16 +1100 (AEDT) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Hildenbrand , Konstantin Khlebnikov , Greg Kroah-Hartman , linux-mm@kvack.org, Paul Mackerras , Vlastimil Babka , Arun KS , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Thomas Gleixner , Allison Randal Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, 2019-10-31 at 14:29:22 UTC, David Hildenbrand wrote: > When unloading the module, one gets > [ 548.188594] ------------[ cut here ]------------ > [ 548.188596] Device 'cmm0' does not have a release() function, it is brok= > en and must be fixed. See Documentation/kobject.txt. > [ 548.188622] WARNING: CPU: 0 PID: 19308 at drivers/base/core.c:1244 .devi= > ce_release+0xcc/0xf0 > ... > > We only have on static fake device. There is nothing to do when > releasing the device (via cmm_exit). > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Andrew Morton > Cc: Vlastimil Babka > Cc: Konstantin Khlebnikov > Cc: Allison Randal > Cc: Greg Kroah-Hartman > Cc: Thomas Gleixner > Cc: Arun KS > Signed-off-by: David Hildenbrand Patches 1-10 applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/7d8212747435c534c8d564fbef4541a463c976ff cheers