From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.tqs.de ([62.157.136.17]:37700 "EHLO mail.tqs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753254Ab2B0RPv convert rfc822-to-8bit (ORCPT ); Mon, 27 Feb 2012 12:15:51 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Subject: AW: [PATCH] Staging: rtl8712: Change double device ID back to original value Date: Mon, 27 Feb 2012 18:14:59 +0100 Message-ID: <47F3F98010FF784EBEE6526EAAB078D10FD7EF7B@tq-mailsrv.tq-net.de> (sfid-20120227_181555_040432_C26A0B75) In-Reply-To: <4F4BA81D.1070800@lwfinger.net> References: <20120227102857.21246.43090.stgit@localhost.localdomain> <4F4BA81D.1070800@lwfinger.net> From: "Martin Krause" To: "Larry Finger" Cc: , "John Linville" Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Larry, thank you for your quick response! Comments see below. Larry Finger wrote on : > On 02/27/2012 04:29 AM, Martin Krause wrote: >> In the rtl8712 staging driver the 0bda:8172 usb device id exists two >> times. It seems that this was an error when integrating the original >> Realtek driver into the kernel. This patch changes the double device >> id back to the value used in the last Realtek driver >> (rtl8712_8188_8191_8192SU_usb_linux_v2.6.6.0.20110401). >> >> Signed-off-by: Martin Krause >> --- >> I tested this patch on a powerpc board (p2020 based) with a WIFIHU >> Radicom wireless module with a RTL8191SU chip on it (usb device id >> 0bda:8192). >> >> drivers/staging/rtl8712/usb_intf.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) > > Your patch does two things. One is the deletion of a > duplicate USB ID, and the > other is the addition of a new one. I would prefer that any > patch do one or the > other, but not both. Note, there are two sets of duplicate > IDs in the table for > the driver - the one you note in the RTL8191SU section, and another > for 0bda:8174 in the section that covers the RTL8192SU. > > I think you are deleting the wrong 0bda:8172 with this patch. > The 0bda code is > for Realtek, thus the one in the Asus section is the one to remove. OK (I don't thought very hard about this I fear ...). > Does your chip really have an RTL8191SU label? The USB > database says that ID > 0bda:8192 is for the RTL8192SU. I would like to correct the database > if it is wrong. The chip is covered by a metallic shielding. So I wrote an email to Radicom to confirm this. I will forward you the answer. > All patches to a staging driver go through the staging tree, > not wireless. Send > them to Greg Kroah-Hartman (gregkh@linuxfoundation.org) > rather than John > Linville. A Cc to linux-wireless is OK, but you should also reference > the driver development list (devel@driverdev.osuosl.org). OK, thanks for the hint! Regards, Martin