From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Ard Biesheuvel <ardb@kernel.org>, linuxppc-dev@lists.ozlabs.org
Cc: paulus@samba.org, Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH] powerpc/archrandom: fix arch_get_random_seed_int()
Date: Mon, 9 Dec 2019 16:45:11 +1100 (AEDT) [thread overview]
Message-ID: <47WXGH3Myxz9sR7@ozlabs.org> (raw)
In-Reply-To: <20191204115015.18015-1-ardb@kernel.org>
On Wed, 2019-12-04 at 11:50:15 UTC, Ard Biesheuvel wrote:
> Commit 01c9348c7620ec65
>
> powerpc: Use hardware RNG for arch_get_random_seed_* not arch_get_random_*
>
> updated arch_get_random_[int|long]() to be NOPs, and moved the hardware
> RNG backing to arch_get_random_seed_[int|long]() instead. However, it
> failed to take into account that arch_get_random_int() was implemented
> in terms of arch_get_random_long(), and so we ended up with a version
> of the former that is essentially a NOP as well.
>
> Fix this by calling arch_get_random_seed_long() from
> arch_get_random_seed_int() instead.
>
> Fixes: 01c9348c7620ec65 ("powerpc: Use hardware RNG for arch_get_random_seed_* not arch_get_random_*")
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/b6afd1234cf93aa0d71b4be4788c47534905f0be
cheers
prev parent reply other threads:[~2019-12-09 5:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 11:50 [PATCH] powerpc/archrandom: fix arch_get_random_seed_int() Ard Biesheuvel
2019-12-09 5:45 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47WXGH3Myxz9sR7@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=ardb@kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.