Re: [PATCH xf86-video-intel v2] sna: Added AYUV format support for textured and sprite video adapters.

["Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>]

On Thu, 2018-10-04 at 16:33 +0100, Chris Wilson wrote:
> Quoting Stanislav Lisovskiy (2018-10-04 13:49:41)
> > diff --git a/src/sna/sna_render.h b/src/sna/sna_render.h
> > index 6669af9d..ef88d1f9 100644
> > --- a/src/sna/sna_render.h
> > +++ b/src/sna/sna_render.h
> > @@ -139,20 +139,25 @@ struct sna_composite_op {
> >  
> >                 struct {
> >                         uint32_t flags;
> > +                       uint8_t wm_kernel;
> >                 } gen6;
> >  
> >                 struct {
> >                         uint32_t flags;
> > +                       uint8_t wm_kernel;
> >                 } gen7;
> >  
> >                 struct {
> >                         uint32_t flags;
> > +                       uint8_t wm_kernel;
> >                 } gen8;
> >  
> >                 struct {
> >                         uint32_t flags;
> > +                       uint8_t wm_kernel;
> >                 } gen9;
> >         } u;
> > +       unsigned long gen9_kernel;
> 
> Still the same problems. Additional *unused* parameters in the common
> which
> are clearly marked as gen specific, and extra unused gen specific
> parameters.
> 
> Would it be easier if you split the patch up into functional changes?
> -Chris

Well, I agree, forgot to remove those unneeded gens. Also probably good
idea to split it( I just wonder may be should Ville's initial patch go
first then, as I used it as a base). 

-- 
Best Regards,

Lisovskiy Stanislav
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx