From: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
To: u-boot@lists.denx.de
Subject: [PATCH 4/5] cmd: allow disabling of timeout for password entry
Date: Wed, 21 Apr 2021 16:09:46 +0200 [thread overview]
Message-ID: <47a898d8-f28f-eeec-6d2c-2b2ad0eb59ad@eyet-services.de> (raw)
In-Reply-To: <CAPnjgZ3ZNoesYGCg9HEk+LRBYj1rq7kn+gVO6cG1BncOHcpFhg@mail.gmail.com>
On 4/21/21 9:14 AM, Simon Glass wrote:
> On Tue, 13 Apr 2021 at 10:16, Steffen Jaeckel
> <jaeckel-floss@eyet-services.de> wrote:
>>
>> In case a user has to enter a complicated password it is sometimes
>> desireable to give the user more time than the default timeout.
>> Enabling this feature will disable the timeout entirely in case the user
>> presses the <Enter> key before entering any other character.
>>
>> Signed-off-by: Steffen Jaeckel <jaeckel-floss@eyet-services.de>
>> ---
>>
>> cmd/Kconfig | 8 ++++++++
>> common/autoboot.c | 8 +++++++-
>> 2 files changed, 15 insertions(+), 1 deletion(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> I wonder if we could have some unit tests for this?
As there are no tests yet for the autoboot part and I don't really feel
comfortable adding one, I guess this has to wait ...
FYI: I've implemented the unit tests & your change requests but I'm
waiting with a re-spin until we've sorted out the open points of Patch 2.
Cheers
Steffen
next prev parent reply other threads:[~2021-04-21 14:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 22:15 [PATCH 0/5] common: Introduce crypt-style password support Steffen Jaeckel
2021-04-12 22:15 ` [PATCH 1/5] lib: add crypt subsystem Steffen Jaeckel
2021-04-21 7:14 ` Simon Glass
2021-04-21 8:21 ` Steffen Jaeckel
2021-04-22 23:55 ` Simon Glass
2021-04-12 22:15 ` [PATCH 2/5] common: integrate crypt-based passwords Steffen Jaeckel
2021-04-21 7:14 ` Simon Glass
2021-04-21 8:55 ` Steffen Jaeckel
2021-04-29 16:10 ` Simon Glass
2021-04-12 22:15 ` [PATCH 3/5] common: Rename macro appropriately Steffen Jaeckel
2021-04-14 19:38 ` Simon Glass
2021-04-12 22:15 ` [PATCH 4/5] cmd: allow disabling of timeout for password entry Steffen Jaeckel
2021-04-21 7:14 ` Simon Glass
2021-04-21 14:09 ` Steffen Jaeckel [this message]
2021-04-12 22:15 ` [PATCH 5/5] configs: add new values to bcm963158 defconfig Steffen Jaeckel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47a898d8-f28f-eeec-6d2c-2b2ad0eb59ad@eyet-services.de \
--to=jaeckel-floss@eyet-services.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.