Re: [PATCH] ARM: dts: stm32: Fix touchscreen IRQ line assignment on DHCOM

[Marek Vasut <marex@denx.de>]

On 7/28/21 9:31 AM, Alexandre TORGUE wrote:
> On 7/23/21 7:39 PM, Marek Vasut wrote:
>> On 7/23/21 5:18 PM, Alexandre TORGUE wrote:
>>> Hi Marek
>>>
>>> On 7/21/21 8:10 PM, Marek Vasut wrote:
>>>> While 7e5f3155dcbb4 ("ARM: dts: stm32: Fix LED5 on STM32MP1 DHCOM 
>>>> PDK2")
>>>> fixed the LED0 assignment on the PDK2 board, the same commit did not
>>>> update the touchscreen IRQ line assignment, which is the same GPIO 
>>>> line,
>>>> shared between the LED0 output and touchscreen IRQ input. To make this
>>>> more convoluted, the same EXTI input (not the same GPIO line) is shared
>>>> between Button B which is Active-Low IRQ, and touchscreen IRQ which is
>>>> Edge-Falling IRQ, which cannot be used at the same time. In case the 
>>>> LCD
>>>> board with touchscreen is in use, which is the case here, LED0 must be
>>>> disabled, Button B must be polled, so the touchscreen interrupt 
>>>> works as
>>>> it should.
>>>>
>>>> Update the touchscreen IRQ line assignment, disable LED0 and use polled
>>>> GPIO button driver for Button B, since the DT here describes baseboard
>>>> with LCD board.
>>>>
>>>> Fixes: 7e5f3155dcbb4 ("ARM: dts: stm32: Fix LED5 on STM32MP1 DHCOM 
>>>> PDK2")
>>>> Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM 
>>>> STM32MP1 SoM and PDK2 board")
>>>
>>> I think you need to keep only one fixes tag.
>>
>> Then it is the first one (LED5) if you want to pick it, or shall I 
>> resend it ?
> 
> I'll do it.

Thank you

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel