From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DC6BC282CE for ; Fri, 12 Apr 2019 11:03:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7FF22083E for ; Fri, 12 Apr 2019 11:03:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="SmYADYnh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727025AbfDLLDr (ORCPT ); Fri, 12 Apr 2019 07:03:47 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:51904 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726697AbfDLLDr (ORCPT ); Fri, 12 Apr 2019 07:03:47 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x3CB3LdE062149; Fri, 12 Apr 2019 06:03:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1555067001; bh=QOpbQOPEGfnHx7BYOEMM3tXXv5qE85Y2wbQy0Auarps=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=SmYADYnhjk9veWb9BI8cTkS4DspywLZOUNhouOfrHpC51+5zNVpbAw/gOftEo6fqx JwfRPbxyXSPkTP7igmE/QuXA6YPM2IPXFtLo0jiiB9qgM4LZ1rtLJi/rUyboBOOIhd opI6er9XpzbzwSCaWqUC1FgAoZgQK53w4lhk+xZ4= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x3CB3Kma094171 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 12 Apr 2019 06:03:20 -0500 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 12 Apr 2019 06:03:20 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Fri, 12 Apr 2019 06:03:20 -0500 Received: from [172.24.190.233] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x3CB3DfA081431; Fri, 12 Apr 2019 06:03:14 -0500 Subject: Re: [PATCH v3 12/26] PCI: keystone: Prevent ARM32 specific code to be compiled for ARM64 To: Russell King - ARM Linux admin CC: Lorenzo Pieralisi , , Jesper Nilsson , Arnd Bergmann , Greg Kroah-Hartman , Gustavo Pimentel , , , , Minghuan Lian , Rob Herring , Murali Karicheri , Jingoo Han , Bjorn Helgaas , Mingkai Hu , , Roy Zang , References: <20190325093947.32633-1-kishon@ti.com> <20190325093947.32633-13-kishon@ti.com> <20190411150332.GC6862@red-moon> <20190412093154.7wj4dmm3oppvv32m@shell.armlinux.org.uk> From: Kishon Vijay Abraham I Message-ID: <47ea91f7-bbc1-187d-6f75-e2e6460f90a0@ti.com> Date: Fri, 12 Apr 2019 16:32:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190412093154.7wj4dmm3oppvv32m@shell.armlinux.org.uk> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Russell, On 12/04/19 3:01 PM, Russell King - ARM Linux admin wrote: > On Fri, Apr 12, 2019 at 02:20:06PM +0530, Kishon Vijay Abraham I wrote: >> Hi Lorenzo, >> >> On 11/04/19 8:33 PM, Lorenzo Pieralisi wrote: >>> On Mon, Mar 25, 2019 at 03:09:33PM +0530, Kishon Vijay Abraham I wrote: >>>> hook_fault_code is an ARM32 specific API for hooking into data abort. >>>> Since pci-keystone.c will be used for AM65X platforms which is an >>>> ARM64 platform, >>> >>> Hi Kishon, >>> >>> How is the problem plugged by the fault hook fixed on ARM64 ? >> >> At least in AM654 platform, I don't see a bus error when PCIe device is not >> connected but returns 0xffffffff. So there is no necessary for hook_fault_code >> in AM654 platform. > > ... which needs to be explained somewhere, either in the commit > message or comments in the file, so that years later when someone > has to look at this code, they know why it is the way that it is. > > When writing commits, please think about whether there is enough > information to understand the change in ten years time. sure, I'll fix this one. Lorenzo, let me know if you want me to resend with updated commit log. Thanks Kishon > >> >> Thanks >> Kishon >> >>> >>> Thanks, >>> Lorenzo >>> >>>> allow hook_fault_code to be compiled only for ARM32. >>>> >>>> Signed-off-by: Kishon Vijay Abraham I >>>> --- >>>> drivers/pci/controller/dwc/pci-keystone.c | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c >>>> index dfe54553d832..93296d434f40 100644 >>>> --- a/drivers/pci/controller/dwc/pci-keystone.c >>>> +++ b/drivers/pci/controller/dwc/pci-keystone.c >>>> @@ -710,6 +710,7 @@ static int ks_pcie_config_legacy_irq(struct keystone_pcie *ks_pcie) >>>> return ret; >>>> } >>>> >>>> +#ifdef CONFIG_ARM >>>> /* >>>> * When a PCI device does not exist during config cycles, keystone host gets a >>>> * bus error instead of returning 0xffffffff. This handler always returns 0 >>>> @@ -729,6 +730,7 @@ static int ks_pcie_fault(unsigned long addr, unsigned int fsr, >>>> >>>> return 0; >>>> } >>>> +#endif >>>> >>>> static int __init ks_pcie_init_id(struct keystone_pcie *ks_pcie) >>>> { >>>> @@ -778,12 +780,14 @@ static int __init ks_pcie_host_init(struct pcie_port *pp) >>>> if (ret < 0) >>>> return ret; >>>> >>>> +#ifdef CONFIG_ARM >>>> /* >>>> * PCIe access errors that result into OCP errors are caught by ARM as >>>> * "External aborts" >>>> */ >>>> hook_fault_code(17, ks_pcie_fault, SIGBUS, 0, >>>> "Asynchronous external abort"); >>>> +#endif >>>> >>>> ks_pcie_start_link(pci); >>>> dw_pcie_wait_for_link(pci); >>>> -- >>>> 2.17.1 >>>> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH v3 12/26] PCI: keystone: Prevent ARM32 specific code to be compiled for ARM64 Date: Fri, 12 Apr 2019 16:32:10 +0530 Message-ID: <47ea91f7-bbc1-187d-6f75-e2e6460f90a0@ti.com> References: <20190325093947.32633-1-kishon@ti.com> <20190325093947.32633-13-kishon@ti.com> <20190411150332.GC6862@red-moon> <20190412093154.7wj4dmm3oppvv32m@shell.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190412093154.7wj4dmm3oppvv32m@shell.armlinux.org.uk> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Russell King - ARM Linux admin Cc: Lorenzo Pieralisi , devicetree@vger.kernel.org, Jesper Nilsson , Arnd Bergmann , Greg Kroah-Hartman , Gustavo Pimentel , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, Minghuan Lian , Rob Herring , Murali Karicheri , Jingoo Han , Bjorn Helgaas , Mingkai Hu , linux-omap@vger.kernel.org, Roy Zang , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi Russell, On 12/04/19 3:01 PM, Russell King - ARM Linux admin wrote: > On Fri, Apr 12, 2019 at 02:20:06PM +0530, Kishon Vijay Abraham I wrote: >> Hi Lorenzo, >> >> On 11/04/19 8:33 PM, Lorenzo Pieralisi wrote: >>> On Mon, Mar 25, 2019 at 03:09:33PM +0530, Kishon Vijay Abraham I wrote: >>>> hook_fault_code is an ARM32 specific API for hooking into data abort. >>>> Since pci-keystone.c will be used for AM65X platforms which is an >>>> ARM64 platform, >>> >>> Hi Kishon, >>> >>> How is the problem plugged by the fault hook fixed on ARM64 ? >> >> At least in AM654 platform, I don't see a bus error when PCIe device is not >> connected but returns 0xffffffff. So there is no necessary for hook_fault_code >> in AM654 platform. > > ... which needs to be explained somewhere, either in the commit > message or comments in the file, so that years later when someone > has to look at this code, they know why it is the way that it is. > > When writing commits, please think about whether there is enough > information to understand the change in ten years time. sure, I'll fix this one. Lorenzo, let me know if you want me to resend with updated commit log. Thanks Kishon > >> >> Thanks >> Kishon >> >>> >>> Thanks, >>> Lorenzo >>> >>>> allow hook_fault_code to be compiled only for ARM32. >>>> >>>> Signed-off-by: Kishon Vijay Abraham I >>>> --- >>>> drivers/pci/controller/dwc/pci-keystone.c | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c >>>> index dfe54553d832..93296d434f40 100644 >>>> --- a/drivers/pci/controller/dwc/pci-keystone.c >>>> +++ b/drivers/pci/controller/dwc/pci-keystone.c >>>> @@ -710,6 +710,7 @@ static int ks_pcie_config_legacy_irq(struct keystone_pcie *ks_pcie) >>>> return ret; >>>> } >>>> >>>> +#ifdef CONFIG_ARM >>>> /* >>>> * When a PCI device does not exist during config cycles, keystone host gets a >>>> * bus error instead of returning 0xffffffff. This handler always returns 0 >>>> @@ -729,6 +730,7 @@ static int ks_pcie_fault(unsigned long addr, unsigned int fsr, >>>> >>>> return 0; >>>> } >>>> +#endif >>>> >>>> static int __init ks_pcie_init_id(struct keystone_pcie *ks_pcie) >>>> { >>>> @@ -778,12 +780,14 @@ static int __init ks_pcie_host_init(struct pcie_port *pp) >>>> if (ret < 0) >>>> return ret; >>>> >>>> +#ifdef CONFIG_ARM >>>> /* >>>> * PCIe access errors that result into OCP errors are caught by ARM as >>>> * "External aborts" >>>> */ >>>> hook_fault_code(17, ks_pcie_fault, SIGBUS, 0, >>>> "Asynchronous external abort"); >>>> +#endif >>>> >>>> ks_pcie_start_link(pci); >>>> dw_pcie_wait_for_link(pci); >>>> -- >>>> 2.17.1 >>>> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C1FBC10F0E for ; Fri, 12 Apr 2019 11:03:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D7A92083E for ; Fri, 12 Apr 2019 11:03:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rGaRXjmp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="SmYADYnh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D7A92083E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UMnxKApKEQzsFp6Qa9JxddrAiPI8W3s0QcsASHp25oQ=; b=rGaRXjmpVOQlQn ZqsuBDShIAMvlRKldV14mvdtjaFOAQJ1FveiW7lhCjdey2kTzSiosuEa004ZVKbk/GE1+a+JmudhD RPoQ5+OcmIuo3jmHTZnhxjW39+7TZEuTWH0RRtW64mWOQmf8G+YqFoBIZqr6ZQdz+YwB1j7RHh4OO F5ETZnDRdOSoy38G1c9y70Oj+OajCPIxq7ln55y7RytTi6Ww3iBANQluxM0kqq+Se4diGnBgESnH1 49M025QWzJDJLpfQgGCMoXoV1ueMinTsBw4flokxVDMoEVED7M6oOVDmYlbowwSM1t7Q8HYAMoYkQ CUotBd12/OcQKUaVZ+dA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEtyC-0000Jo-Tx; Fri, 12 Apr 2019 11:03:44 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEty8-0000Iu-NM for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2019 11:03:42 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x3CB3LdE062149; Fri, 12 Apr 2019 06:03:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1555067001; bh=QOpbQOPEGfnHx7BYOEMM3tXXv5qE85Y2wbQy0Auarps=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=SmYADYnhjk9veWb9BI8cTkS4DspywLZOUNhouOfrHpC51+5zNVpbAw/gOftEo6fqx JwfRPbxyXSPkTP7igmE/QuXA6YPM2IPXFtLo0jiiB9qgM4LZ1rtLJi/rUyboBOOIhd opI6er9XpzbzwSCaWqUC1FgAoZgQK53w4lhk+xZ4= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x3CB3Kma094171 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 12 Apr 2019 06:03:20 -0500 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 12 Apr 2019 06:03:20 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Fri, 12 Apr 2019 06:03:20 -0500 Received: from [172.24.190.233] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x3CB3DfA081431; Fri, 12 Apr 2019 06:03:14 -0500 Subject: Re: [PATCH v3 12/26] PCI: keystone: Prevent ARM32 specific code to be compiled for ARM64 To: Russell King - ARM Linux admin References: <20190325093947.32633-1-kishon@ti.com> <20190325093947.32633-13-kishon@ti.com> <20190411150332.GC6862@red-moon> <20190412093154.7wj4dmm3oppvv32m@shell.armlinux.org.uk> From: Kishon Vijay Abraham I Message-ID: <47ea91f7-bbc1-187d-6f75-e2e6460f90a0@ti.com> Date: Fri, 12 Apr 2019 16:32:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190412093154.7wj4dmm3oppvv32m@shell.armlinux.org.uk> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190412_040340_839027_8A770C46 X-CRM114-Status: GOOD ( 22.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Jesper Nilsson , Lorenzo Pieralisi , Arnd Bergmann , Jingoo Han , Gustavo Pimentel , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, Minghuan Lian , Rob Herring , Murali Karicheri , Greg Kroah-Hartman , Bjorn Helgaas , linux-omap@vger.kernel.org, Roy Zang , Mingkai Hu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Russell, On 12/04/19 3:01 PM, Russell King - ARM Linux admin wrote: > On Fri, Apr 12, 2019 at 02:20:06PM +0530, Kishon Vijay Abraham I wrote: >> Hi Lorenzo, >> >> On 11/04/19 8:33 PM, Lorenzo Pieralisi wrote: >>> On Mon, Mar 25, 2019 at 03:09:33PM +0530, Kishon Vijay Abraham I wrote: >>>> hook_fault_code is an ARM32 specific API for hooking into data abort. >>>> Since pci-keystone.c will be used for AM65X platforms which is an >>>> ARM64 platform, >>> >>> Hi Kishon, >>> >>> How is the problem plugged by the fault hook fixed on ARM64 ? >> >> At least in AM654 platform, I don't see a bus error when PCIe device is not >> connected but returns 0xffffffff. So there is no necessary for hook_fault_code >> in AM654 platform. > > ... which needs to be explained somewhere, either in the commit > message or comments in the file, so that years later when someone > has to look at this code, they know why it is the way that it is. > > When writing commits, please think about whether there is enough > information to understand the change in ten years time. sure, I'll fix this one. Lorenzo, let me know if you want me to resend with updated commit log. Thanks Kishon > >> >> Thanks >> Kishon >> >>> >>> Thanks, >>> Lorenzo >>> >>>> allow hook_fault_code to be compiled only for ARM32. >>>> >>>> Signed-off-by: Kishon Vijay Abraham I >>>> --- >>>> drivers/pci/controller/dwc/pci-keystone.c | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c >>>> index dfe54553d832..93296d434f40 100644 >>>> --- a/drivers/pci/controller/dwc/pci-keystone.c >>>> +++ b/drivers/pci/controller/dwc/pci-keystone.c >>>> @@ -710,6 +710,7 @@ static int ks_pcie_config_legacy_irq(struct keystone_pcie *ks_pcie) >>>> return ret; >>>> } >>>> >>>> +#ifdef CONFIG_ARM >>>> /* >>>> * When a PCI device does not exist during config cycles, keystone host gets a >>>> * bus error instead of returning 0xffffffff. This handler always returns 0 >>>> @@ -729,6 +730,7 @@ static int ks_pcie_fault(unsigned long addr, unsigned int fsr, >>>> >>>> return 0; >>>> } >>>> +#endif >>>> >>>> static int __init ks_pcie_init_id(struct keystone_pcie *ks_pcie) >>>> { >>>> @@ -778,12 +780,14 @@ static int __init ks_pcie_host_init(struct pcie_port *pp) >>>> if (ret < 0) >>>> return ret; >>>> >>>> +#ifdef CONFIG_ARM >>>> /* >>>> * PCIe access errors that result into OCP errors are caught by ARM as >>>> * "External aborts" >>>> */ >>>> hook_fault_code(17, ks_pcie_fault, SIGBUS, 0, >>>> "Asynchronous external abort"); >>>> +#endif >>>> >>>> ks_pcie_start_link(pci); >>>> dw_pcie_wait_for_link(pci); >>>> -- >>>> 2.17.1 >>>> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel