From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2018C2D0A3 for ; Sat, 24 Oct 2020 17:12:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B44CA2083B for ; Sat, 24 Oct 2020 17:12:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=elopez.com.ar header.i=@elopez.com.ar header.b="o95xcThY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762506AbgJXRMc (ORCPT ); Sat, 24 Oct 2020 13:12:32 -0400 Received: from exa.lopez.ar ([51.89.75.32]:45774 "EHLO exa.lopez.ar" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762487AbgJXRMa (ORCPT ); Sat, 24 Oct 2020 13:12:30 -0400 X-Greylist: delayed 453 seconds by postgrey-1.27 at vger.kernel.org; Sat, 24 Oct 2020 13:12:27 EDT Authentication-Results: exa.lopez.ar; auth=pass (plain) Subject: Re: [linux-sunxi] [PATCH 03/10] ARM: dts: sun7i: cubietruck: Enable RGMII RX/TX delay on Ethernet PHY To: wens@kernel.org, Maxime Ripard , Jernej Skrabec Cc: linux-sunxi@googlegroups.com, Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20201024162515.30032-1-wens@kernel.org> <20201024162515.30032-3-wens@kernel.org> From: =?UTF-8?Q?Emilio_L=c3=b3pez?= Message-ID: <47f00919-39fe-bbf3-32c7-e1375f34a7be@elopez.com.ar> Date: Sat, 24 Oct 2020 14:04:46 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201024162515.30032-3-wens@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received: from localhost (Unknown [127.0.0.1]) by exa.lopez.ar (Haraka) with ESMTPSA id B3E375ED-B79F-46BB-BD98-D96F37E02556.1 envelope-from (authenticated bits=0) (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 24 Oct 2020 17:04:52 +0000 DKIM-Signature: v=1;a=rsa-sha256;bh=2EyzHnJp15sr8tT4gTFe+OUB6xzYrozSwpx/bWJER5w=;c=relaxed/simple;d=elopez.com.ar;h=from:subject:date:message-id:to:cc:mime-version;s=s20200214815;b=o95xcThYIBGLVZGG4AU8efDz+q0bhaSeA181ZgEltYBYm6N6k1D4opc1jA8VwRk3WhjMp+yC5Y0ux1dx9DJNGxNI86BYwfPLNCCcVKc/WSSKKuvbKrJitQxkeG0ICCWKVBYqpjeXedwVHegfPmI00i3Nh+fG/nkHs34jjb5lgChyxz2KWw4SFMkTqjRLeDZnp6D50nQwyVSpFIex4t/LxcUXepptIIA7o1GBoPXCqnl+NC0KZk7+Lum2Djlfzj9Xq+cyhnr/Da5gnw+i+pYGT8wT0T2Bg93i7EMM7SoJkaB2vHrNA2SOs4PBuA5t1zq3AgC72oa/XcF8sIa/MT4NvA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org El 24/10/20 a las 13:25, Chen-Yu Tsai escribió: > From: Chen-Yu Tsai > > The Ethernet PHY on the Cubietruck has the RX and TX delays > enabled on the PHY, using pull-ups on the RXDLY and TXDLY pins. > > Fix the phy-mode description to correct reflect this so that the > implementation doesn't reconfigure the delays incorrectly. This > happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e > rx/tx delay config"). > > Fixes: 67073d97672d ("ARM: dts: sun7i: cubietruck: Enable the GMAC") > Signed-off-by: Chen-Yu Tsai > --- > arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts > index 8c8dee6ea461..9109ca0919ad 100644 > --- a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts > +++ b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts > @@ -151,7 +151,7 @@ &gmac { > pinctrl-names = "default"; > pinctrl-0 = <&gmac_rgmii_pins>; > phy-handle = <&phy1>; > - phy-mode = "rgmii"; > + phy-mode = "rgmii-id"; > status = "okay"; > }; > > I upgraded kernels yesterday and saw that networking had stopped working. I can confirm that this patch fixes the problem and restores connectivity on my Cubietruck. I also verified the information with the schematics, and it looks alright to me :) Reviewed-by: Emilio López Tested-by: Emilio López Thanks! Emilio From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6FD1C2D0A3 for ; Sat, 24 Oct 2020 17:07:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FDD12085B for ; Sat, 24 Oct 2020 17:07:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="099EE5Ji"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=elopez.com.ar header.i=@elopez.com.ar header.b="o95xcThY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FDD12085B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=elopez.com.ar Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/GIaoeQsRuKMIh8TWzfoK1PYtlG70opUXQFNhgJ1BT4=; b=099EE5JiTeCqaZpAKvTXZiahG waS3tYNOnqD8JjbVPTGA7/VPkTil7X830bUbdFRAAakLmd7J7zFN5Tr7l7/SbJX4tBIQvO/dVcnxs QkuXb23mpb+GvZDbk+RIeqmPdTxZir4jPjHJxl+3BTps+vL+PO5lzz1gRVJEQGEJLcVfq2d/ywRxx bms3M2T7fhlPIJGdrOLxX+QLUpuhgzy9HnGsPQHPhxWVt3Xho32gsBDJRud1t0VtNlMe71LbyfD5u 9r9miyyVphfM9aTHv0lLCpy7AvzOTp456Cz6c/A93+8IwDPZjveaP//iVHPgP38PdzlzayToFc8HX B/M0zbXVA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWMyX-0008Jv-E2; Sat, 24 Oct 2020 17:05:05 +0000 Received: from exa.lopez.ar ([51.89.75.32]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWMyT-0008Ii-K8 for linux-arm-kernel@lists.infradead.org; Sat, 24 Oct 2020 17:05:02 +0000 Authentication-Results: exa.lopez.ar; auth=pass (plain) Subject: Re: [linux-sunxi] [PATCH 03/10] ARM: dts: sun7i: cubietruck: Enable RGMII RX/TX delay on Ethernet PHY To: wens@kernel.org, Maxime Ripard , Jernej Skrabec References: <20201024162515.30032-1-wens@kernel.org> <20201024162515.30032-3-wens@kernel.org> From: =?UTF-8?Q?Emilio_L=c3=b3pez?= Message-ID: <47f00919-39fe-bbf3-32c7-e1375f34a7be@elopez.com.ar> Date: Sat, 24 Oct 2020 14:04:46 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201024162515.30032-3-wens@kernel.org> Content-Language: en-US Received: from localhost (Unknown [127.0.0.1]) by exa.lopez.ar (Haraka) with ESMTPSA id B3E375ED-B79F-46BB-BD98-D96F37E02556.1 envelope-from (authenticated bits=0) (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 24 Oct 2020 17:04:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; bh=2EyzHnJp15sr8tT4gTFe+OUB6xzYrozSwpx/bWJER5w=; c=relaxed/simple; d=elopez.com.ar; h=from:subject:date:message-id:to:cc:mime-version; s=s20200214815; b=o95xcThYIBGLVZGG4AU8efDz+q0bhaSeA181ZgEltYBYm6N6k1D4opc1jA8VwRk3WhjMp+yC5Y0ux1dx9DJNGxNI86BYwfPLNCCcVKc/WSSKKuvbKrJitQxkeG0ICCWKVBYqpjeXedwVHegfPmI00i3Nh+fG/nkHs34jjb5lgChyxz2KWw4SFMkTqjRLeDZnp6D50nQwyVSpFIex4t/LxcUXepptIIA7o1GBoPXCqnl+NC0KZk7+Lum2Djlfzj9Xq+cyhnr/Da5gnw+i+pYGT8wT0T2Bg93i7EMM7SoJkaB2vHrNA2SOs4PBuA5t1zq3AgC72oa/XcF8sIa/MT4NvA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201024_130501_987456_A787B126 X-CRM114-Status: GOOD ( 19.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RWwgMjQvMTAvMjAgYSBsYXMgMTM6MjUsIENoZW4tWXUgVHNhaSBlc2NyaWJpw7M6Cj4gRnJvbTog Q2hlbi1ZdSBUc2FpIDx3ZW5zQGNzaWUub3JnPgo+IAo+IFRoZSBFdGhlcm5ldCBQSFkgb24gdGhl IEN1YmlldHJ1Y2sgaGFzIHRoZSBSWCBhbmQgVFggZGVsYXlzCj4gZW5hYmxlZCBvbiB0aGUgUEhZ LCB1c2luZyBwdWxsLXVwcyBvbiB0aGUgUlhETFkgYW5kIFRYRExZIHBpbnMuCj4gCj4gRml4IHRo ZSBwaHktbW9kZSBkZXNjcmlwdGlvbiB0byBjb3JyZWN0IHJlZmxlY3QgdGhpcyBzbyB0aGF0IHRo ZQo+IGltcGxlbWVudGF0aW9uIGRvZXNuJ3QgcmVjb25maWd1cmUgdGhlIGRlbGF5cyBpbmNvcnJl Y3RseS4gVGhpcwo+IGhhcHBlbmVkIHdpdGggY29tbWl0IGJiYzRkNzFkNjM1NCAoIm5ldDogcGh5 OiByZWFsdGVrOiBmaXggcnRsODIxMWUKPiByeC90eCBkZWxheSBjb25maWciKS4KPiAKPiBGaXhl czogNjcwNzNkOTc2NzJkICgiQVJNOiBkdHM6IHN1bjdpOiBjdWJpZXRydWNrOiBFbmFibGUgdGhl IEdNQUMiKQo+IFNpZ25lZC1vZmYtYnk6IENoZW4tWXUgVHNhaSA8d2Vuc0Bjc2llLm9yZz4KPiAt LS0KPiAgIGFyY2gvYXJtL2Jvb3QvZHRzL3N1bjdpLWEyMC1jdWJpZXRydWNrLmR0cyB8IDIgKy0K PiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRp ZmYgLS1naXQgYS9hcmNoL2FybS9ib290L2R0cy9zdW43aS1hMjAtY3ViaWV0cnVjay5kdHMgYi9h cmNoL2FybS9ib290L2R0cy9zdW43aS1hMjAtY3ViaWV0cnVjay5kdHMKPiBpbmRleCA4YzhkZWU2 ZWE0NjEuLjkxMDljYTA5MTlhZCAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybS9ib290L2R0cy9zdW43 aS1hMjAtY3ViaWV0cnVjay5kdHMKPiArKysgYi9hcmNoL2FybS9ib290L2R0cy9zdW43aS1hMjAt Y3ViaWV0cnVjay5kdHMKPiBAQCAtMTUxLDcgKzE1MSw3IEBAICZnbWFjIHsKPiAgIAlwaW5jdHJs LW5hbWVzID0gImRlZmF1bHQiOwo+ICAgCXBpbmN0cmwtMCA9IDwmZ21hY19yZ21paV9waW5zPjsK PiAgIAlwaHktaGFuZGxlID0gPCZwaHkxPjsKPiAtCXBoeS1tb2RlID0gInJnbWlpIjsKPiArCXBo eS1tb2RlID0gInJnbWlpLWlkIjsKPiAgIAlzdGF0dXMgPSAib2theSI7Cj4gICB9Owo+ICAgCj4g CgpJIHVwZ3JhZGVkIGtlcm5lbHMgeWVzdGVyZGF5IGFuZCBzYXcgdGhhdCBuZXR3b3JraW5nIGhh ZCBzdG9wcGVkIAp3b3JraW5nLiBJIGNhbiBjb25maXJtIHRoYXQgdGhpcyBwYXRjaCBmaXhlcyB0 aGUgcHJvYmxlbSBhbmQgcmVzdG9yZXMgCmNvbm5lY3Rpdml0eSBvbiBteSBDdWJpZXRydWNrLiBJ IGFsc28gdmVyaWZpZWQgdGhlIGluZm9ybWF0aW9uIHdpdGggdGhlIApzY2hlbWF0aWNzLCBhbmQg aXQgbG9va3MgYWxyaWdodCB0byBtZSA6KQoKUmV2aWV3ZWQtYnk6IEVtaWxpbyBMw7NwZXogPGVt aWxpb0BlbG9wZXouY29tLmFyPgpUZXN0ZWQtYnk6IEVtaWxpbyBMw7NwZXogPGVtaWxpb0BlbG9w ZXouY29tLmFyPgoKVGhhbmtzIQpFbWlsaW8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK