From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751154AbdEaPaz (ORCPT ); Wed, 31 May 2017 11:30:55 -0400 Received: from mail-eopbgr10126.outbound.protection.outlook.com ([40.107.1.126]:52032 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750998AbdEaPax (ORCPT ); Wed, 31 May 2017 11:30:53 -0400 Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=axentia.se; Subject: Re: [PATCH v1 1/1] mux: mux-intel-usb: Add Intel USB Multiplexer driver To: Hans de Goede , Andy Shevchenko , Kuppuswamy Sathyanarayanan Cc: "Krogerus, Heikki" , "linux-kernel@vger.kernel.org" , Sathyanarayanan Kuppuswamy Natarajan References: <84e3fdaf979c070a5c39c7635910fee30c3a8b06.1496104447.git.sathyanarayanan.kuppuswamy@linux.intel.com> <0e2a3df8-e3b4-28d3-eea9-5ec6a684bf53@linux.intel.com> <2ca23e5a-af13-f6f5-7c94-0af36acff6a3@axentia.se> <1c57c881-3885-dca5-b202-07f71a7dc936@redhat.com> From: Peter Rosin Organization: Axentia Technologies AB Message-ID: <47f64eaa-9985-542c-1845-c7b8aaf81f70@axentia.se> Date: Wed, 31 May 2017 17:30:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1c57c881-3885-dca5-b202-07f71a7dc936@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [81.224.171.159] X-ClientProxiedBy: AM5PR0201CA0011.eurprd02.prod.outlook.com (2603:10a6:203:3d::21) To VI1PR0202MB2559.eurprd02.prod.outlook.com (2603:10a6:801:6::10) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR0202MB2559: X-MS-Office365-Filtering-Correlation-Id: 7b3a3204-c321-4b79-f753-08d4a83a042a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075);SRVR:VI1PR0202MB2559; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;3:rpIdlK5EPq7SqrqCC01wr/MFwJ441oQmw4kotVGhdj5TdiFJw5UF7yZC2o4fal3Mm6EMZ7CroYywebRVY08nMD0SX5NhaPhcG22sP706/78Cct/P3g29qfunBzjLLvi6GDmsfHawC8ZESQcvTGMDDdetYjZnHQ0boUVNXod2PwR0250yhV8ulHoSVWpoWceN5g59AZ3whcwpM4x5J7yRb0zu9xphZUem6PYtJA/XTzX3Z4ruYhg/DSrauu2l8AZugDO3k2+f5wDQ7BtQGDRq36QcRxG4MK9NYh/nvOBcXaw=;25:kd/mFEee1rMnGheg29n1FadamjoWWpSDDsVTwjiyzjMXRCeoScLHEp0LeVOY5kb+KMxLSWLwd4PndcVqVHdY+yge1eIF+hcoWPZoA02KyElPFe0LWUSyaZSNaA4VykC0Vk5OsCtq4cxvMutBQuHqu2IiXCdLokoOA2aHo8PrT35ayZ8zgsra/Jj7IKy0a6fxR/f6cTCFAnzAcCxMQNfRAHkVgILgcXIP/1ycAuCqel10CY9Gfwpj1vEqpQ1V1o+50QPZJimINXfXojDIK14GsfFKw4SyVJ3g+G9t3Xw3lOMkVNKT65/PGOU2L3pw929vi/U6rHlIBsuVDMGKjzXSdEjER7oUXxg8b4WQf7cPGMtxK3a9yjH25Ft+TB692vT/d3oxoNGzITA58Xqtl8N8qxeeF6WK5NEV7CpOxIfA0kSYvxehWrBpc43o6T64bdejKJor+Gph3LqA1/YCkZA994pWKNGIdtyS3PYd2kmjSTE= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;31:7gdPe0OCa7cw0L0mpomWXPySoWJxEsU9Y+2fkNhSAfjSN1EWdeZs0+UYYfPWrKtOazEo2tWoKXGIPemsCx5isWkTQBWdYJ2TZCZVnp+9iM4d3e2le7E5MrnZ/sO+/sQKqbKLAhheRTRH26Z6zRDMkly9+07OGJNq88rKXUAXwhgLJRe/z/X8oNgZp8SL418CgIsBRzdYFGqSHweTXm7CklZykgWKXlWjMQVNd4xxRCHyJejk24UTAqTgviWmJxOgTzwOg9qCoQY1nB/TF7LT7Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(4782527817362); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(6041248)(20161123564025)(20161123560025)(20161123562025)(20161123555025)(2016111802025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6043046)(6072148);SRVR:VI1PR0202MB2559;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0202MB2559; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;4:UX+eg7oQgEaT3fr7XP44Ws+KRisPdHJBGZufRJsyBEqADPPOE+HanX8q9Kh84/b/4Or+R65StsdXRBUXAJCr+f7rqjssZ9OwJjXSPn7JfmpPBNJNqGebS8mYThZGHu5P3r2bedJrIySyLfJQrERZkrirromsFLWChwef76N3X0t9MZn46NVI0UCwt/Z2gZjGeymohsLh8ul3np4VE/5W03d51VgCua9dl898Lt5WpTJxV/qkAMFbHUdagT+EUn2fTFCicdyc+8NJ5kmPSj4D0CV1QFEEdqBqJBSs2zuKLvIK+JRdsyYFBkIv3OTrP7mhAko59U+Xs4PPzw+3R5AjY78tpiAA2uTnG7lwcNkoa5yFzk+KQm6dsbL7rTrESJDzbpaevhl30h1UJlAkH48T7w3ZFVFkeHc5zhnO3N9XsF4UeozZM46eJsKcYvtyujt7MQ0TwrU3u7YnHcqh7E9d+0nJGzso6673rA1+kfT4Ztb5USNNiCBmlR25zhGIWipp12j4msOx+u3YW7g7CrknwXYVtpjrIdFsidvpDhOZ3rC+O2OdKDYP/J3oLyKlqf7sSW+dK/SxicyX1N4q9Va3FaoWdBNe8QE7ESq134jZnhungW/rBVN+DrCJyMTyjEAEWoF3m5RsYkuL+FFyFlKI3QVrouVb5XQFh2EOYETV7BvAcS73IcwsAycRx7CULzEXpNtW47YOMjo6pC654bqEOFbD82urSBRhbE7gJDkBNPoagv1uiWpQ5muLmkL/rEPHxJB4wAQysOA2NDlKzrAl0gA/AjC6judt9Dkmhz+UC0m77AlOqeb8ghVfRQcMbp8uQ1afMAjyTvQEEPqRu/QSbxdjHiyBIhcZ/nI03YsmvpXSRKg45AfLaFXMDWPXfVUs X-Forefront-PRVS: 0324C2C0E2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(39410400002)(39400400002)(39450400003)(39830400002)(377424004)(24454002)(6116002)(3846002)(4001350100001)(6486002)(77096006)(38730400002)(230700001)(4326008)(53546009)(53936002)(6246003)(229853002)(76176999)(6666003)(230783001)(65956001)(25786009)(54356999)(83506001)(31696002)(86362001)(93886004)(50986999)(66066001)(23676002)(2950100002)(189998001)(33646002)(2906002)(65826007)(5660300001)(966005)(47776003)(50466002)(7736002)(305945005)(478600001)(54906002)(6306002)(117156002)(74482002)(8676002)(81166006)(31686004)(36756003)(42186005)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0202MB2559;H:[192.168.0.125];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjAyMDJNQjI1NTk7MjM6aDhTamtTWkFNamM2ZXFjcHFLWmgvbG1q?= =?utf-8?B?L1Exb21kOU5BcnNZWnJla0huSHB5TGUzRXdTRld2N0VyZXlLS2YxeS9lY2d3?= =?utf-8?B?TWlud3FScDYzd3QxNWl4eFRISFc4akVSb1ZqZkEzZ0ViV2trbXlnWjRCRWVQ?= =?utf-8?B?bmJFWWVIU2FFNEowa3RTdWpteTJKRHpPdkFLSklhcTFiN0hKRm5KUENZTGV4?= =?utf-8?B?SElxRnZxZjZlQmF5UUJYbk5wR1BxTWZjWURyNSt4bUUxaEtFT0w3ZmM4MVFH?= =?utf-8?B?LzNiQWFFZ2ZYRzg3WG8zYWVHV2pIWXR5OHFOTFVJVVBSQ3UxcmlEcDkrblpQ?= =?utf-8?B?N2RBaVRpQ0xCSVZ0cnVzZEFWZmNzRHAvNWxtcTZjTFN2REhmRXNrdGVLQkM3?= =?utf-8?B?amRmeGY3ZXRCUWtwaFdoTWRjdDJsTkNEZElKOTB4NGozcTQ1dkFwR3ZLZmRj?= =?utf-8?B?V29JYThESUV6U0FHeFhoeVVKRVNBSWY1VGNSTlA5Lzd4UHBpTmllN0RGN1VO?= =?utf-8?B?bFFxamswbHIrUHlZNUNlMnNFb2tuS3hlUUVndnVVTkllOEN6c1hUYnB1Nk8x?= =?utf-8?B?R3VNTTRKR0JtWVBwRlFwRjJReng5cHBVZ1NXLzVCRElxbmYybGtIaTN5WkdT?= =?utf-8?B?dkZqMmI1cTFRY0tDY2tQdWVHWWgyeHVzeDBidFBvVmxDc2NjL09XTTdwYUFl?= =?utf-8?B?L3hpN2d3NFNTQXY1R2c1eWhqZTN0RGhaM05tZXJKaGlhT2hYWDY4MGZiTlFN?= =?utf-8?B?MzQ5d2xJak1ZVVRCZUdoV3ZuQ0VaZHZKU1Z3OTYrVk5vZkRiSkMrTXc4OXRC?= =?utf-8?B?N3c2dFhpNkh6ZzArREMxOC9EQjFXSHRsTHFua3h5V3ZqamRZSDJrQW5IUmdF?= =?utf-8?B?ekhDRFZUSHoxTkhzNXJ3M2JUT2VVOHZkTmdDNDdUbkcxN3BxTEJhTVBUSUtZ?= =?utf-8?B?SnBlcXg0VGppUStTcTRYWnFnRnlkVW1mLzJBTVZMVlZHcVZTbmxGd2ZYUG14?= =?utf-8?B?LzBGRmc4Q00zSHpxUzJXakNwTWU0WkN1dHZXSnhCdmQ1bWVtK284Q2Y5dlEx?= =?utf-8?B?U1ZVcWR1dUNJOFJoSHEwbW0zaTE1SFVIcUNLZzlITkljMERnTTRkazRlcyt1?= =?utf-8?B?YzJBejB2MkpPNklhY0hFejhtemhWOENKY1lSWHRGZ3BrNTNKWkRSVlVLQWV2?= =?utf-8?B?QTB4U1Z0REcvNm9OR0Yxejg3cDVySENwTzg5TzBSMkRmcVhYbWJqalRHdkhi?= =?utf-8?B?RlJnTURmY1c5VmlRZjI3MjY2WllKNUE4VGUydnVuaW5Jc0UrUU1TZDNMVnlo?= =?utf-8?B?MGpBbTVxVm9EQW9rTG9SVU5SdEpESDFVL2szb0FZbGt1Ti8vSE1QY05UdGU5?= =?utf-8?B?N0p6TGl3VDFoeTVBcXFBS2IrdmFpR1VweXBpTGZZQkt0Y29HS1NTdS9ValFY?= =?utf-8?B?M3FzaWlHcEJkOTdqQTVCVmJ1UTdaU05Ba2Z6RXdlcHdiZTFDOVZIeElWcUtD?= =?utf-8?B?TjExcVU3aS9ud0k3WC9SVE05NXg4U0hQbUVBMy8yWGp4clkvNE9TNHVweVhq?= =?utf-8?B?dkR5aWk5TW1BaVUvTVA1NGhBc0VzYTlwRmRVU0NxNWN0Q0FsU3JpSXRpK2p5?= =?utf-8?B?dndqc0xUc1l5M2d0eXlCelpNWTdySHQ3NEYwRDBlZUlDMEozdTRzU0gvbXAr?= =?utf-8?B?d214Ukl3UDJyaG1TWGpCbkxhdG1zeG1vQTEwMEkxWVlnekEraGJCVFYyRVV2?= =?utf-8?B?RStwdUNvYXV0SDV2WitOT2MyUnZYN21paXgra2IzSlEwQ1R2TkN6TEJRTUQ3?= =?utf-8?B?ZGJkQ0lLWkRDRktVWlkvWSszWE9EbXMveDZ2SFJZRWJEdVovQT09?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;6:TZ+AnjzsHr5+J9q0TubAqE02ZbQjaqTq6EXuFsnHK5oWgSGMDzY4ZbguE7mfa95OoJ/s/LTeaCNlcvAUJeElsg9AY5FmqyNtnEpBLlv6yWSqxPSDwX1nNIjOgzc+V3o1CFVXQA1xLhtiwDVwH3vocoJeLawq0qCfDpnVUxb1OxMZDhIZMic7xi0gtptkhitgmMTLi6pFSg3DnHNdsI6gvyyogVzZ9vjJU+Oqk+gojtSfDgd9D2Y8W/5p58o/aAO7LwIsZCV4sN4Pf1UHQN2325aAQZSqr3MFyeFyEA5t+Q6NS9QCNhuW9xDRNZX4CFREnyWDGDt0lZFXL0Oa4+wohpy+BAiG3Y9/Xh21Ki06/liprYLzoOg6arLhjgkcdLHQArpF10xLSZDXmRsB60YvxKhDn3LXMXNmOO8iKaqK3oQM4gn1RHktdloSKsEVMkZK05P6TyCrx2Wnk+DhIDTcz3jYSjUxldBHFdDl/H1iDQApMTYKjNAuPxAk2tu9zqEBwEMG0X8ALRtnT6lF0CZz2Q==;5:W3qcV/Ya24VQvVo892Jkk5A/HSgNibUtdWiydmVZpJJOiNSonHCiyHtwnpVcUT/27EFq1yL4Dp5uF16xFXeqq+XA7q4tNaPZGtaMFxwFuVmsEgzJDY2fB6Sq+AMs15P4X4PVXcUUyX3w3WXfGMM/Pw==;24:kVUzO3RrNqBP9l80z5Nl4MPFiGpxJnfhTJiTE8JnZHWpMFYK1e/OHfJTI7hdV0F8zHDx0krM+TbHO5Y3HtZ0cKmXjzleBmxoy/n50qK44MA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;7:A63hbK7DnSyIboE4VqPjki00xJmHuHV7Qpvko7ICQPl+OAZ853S2t2W2ZUT/uMzXel0U0fO9JdFPIpX1J7lx/zTMJbcbDQF0jmRsi4GdF5orQsY4FKkY6HNNM8nf4IDXpslDSmvaTz3dS0G1abZFgpaw76lxwZljUM7PFhhcULQqGJJHwbVe3wu9AsXHCRh64+mley1xi2RlYE8QunannbFjcyo4ZvJxI+33ZaD9CncV1HszU2fxZ94iwvigfyEdAipYfYHCYK/fOmsiC2r868M+2KUQcowYvYfgP5TVlgCYIHfkcxpjxSooNYqjqp6e/O+bEabo8EWOXaaScGODKQ== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2017 15:30:46.1170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0202MB2559 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-05-31 16:18, Hans de Goede wrote: > Hi, > > On 31-05-17 15:05, Peter Rosin wrote: >> On 2017-05-31 14:21, Hans de Goede wrote: >>> actually this is the first time I hear about a mux framework >>> at all. Is there a git tree with the patches for this somewhere ? >> >> https://gitlab.com/peda-linux/mux.git in the "mux" branch. >> >> Series posted here: >> https://lkml.org/lkml/2017/5/14/160 > > Thank you. > > I see that mux_control_get() currently relies on devicetree describing > the mux, that is not going to work on non devicetree platforms like > x86 where the relation typically is not described ad all (*) ? Yes, I'm aware of this. I wanted to keep things simple. Also, see my reply on the other branch of this discussion. https://lkml.org/lkml/2017/5/31/58 > Typically there would be a global list of mux_controls maintained > by mux_[de]register and then mux_control_get() would walk this list > until it finds a matching name. The names to register would then be > passed in by platform data/code when registering and likewise the > consumer would be passed a unique name to pass into mux_control_get() > through platform data / code, would that work for you ? > > Note one option would be to set the names to use when registering > a mux chip through device_properties, this is what the power-supply > subsys is currently doing more or less. I had this lose plan to match by the struct device name, but if that is not working the above seems fine too... Cheers, peda