From: Stefan Wahren <stefan.wahren@i2se.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Eduardo Valentin <edubezval@gmail.com>,
Guenter Roeck <linux@roeck-us.net>
Cc: Rui Zhang <rui.zhang@intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Thermal-SoC management changes for v5.2-rc1
Date: Thu, 16 May 2019 18:11:32 +0200 [thread overview]
Message-ID: <4803994d-f519-a6b6-f5bb-a2f50d91ecd7@i2se.com> (raw)
In-Reply-To: <CAHk-=wiaO_8SiEB9QM3vOTniiT67K6CBH0uHJ82-Dp_+6kxH3g@mail.gmail.com>
Hi Linus,
On 16.05.19 17:07, Linus Torvalds wrote:
> On Wed, May 15, 2019 at 9:43 PM Eduardo Valentin <edubezval@gmail.com> wrote:
>> - thermal core has a new devm_* API for registering cooling devices, thanks to Guenter R.
>> I took the entire series, that is why you see changes on drivers/hwmon in this pull.
> This clashed badly with commit 6b1ec4789fb1 ("hwmon: (pwm-fan) Add RPM
> support via external interrupt"), which added a timer to the pwm-fan
> handling.
>
> In particular, that timer now needed the same kind of cleanup changes,
> and I'd like you guys (particularly Guenther, who was involved on both
> sides) to double-check my merge.
>
> The way I solved it was to just make the pwm_fan_pwm_disable()
> callback do both the pwm_diable() _and_ the del_timer_sync() on the
> new timer. That seemed to be the simplest solution that meshed with
> the new devm cleanup model, but while I build-tested the result, I
> obviously did no actual use testing. And maybe there's some reason why
> that approach is flawed.
i will try to test on our custom i.MX6 board. Unfortunately this take
some time since it isn't mainline yet (at least until tomorrow).
Stefan
>
> Guenther?
>
> Linus
next prev parent reply other threads:[~2019-05-16 16:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 4:43 [GIT PULL] Thermal-SoC management changes for v5.2-rc1 Eduardo Valentin
2019-05-16 15:07 ` Linus Torvalds
2019-05-16 16:11 ` Stefan Wahren [this message]
2019-05-17 12:25 ` Stefan Wahren
2019-05-16 16:55 ` Guenter Roeck
2019-05-24 2:37 ` Eduardo Valentin
2019-05-16 15:10 ` pr-tracker-bot
2019-05-23 9:46 ` Tomeu Vizoso
2019-05-24 2:40 ` Eduardo Valentin
2019-05-24 8:23 ` Tomeu Vizoso
2019-05-24 13:54 ` Eduardo Valentin
2019-05-27 11:26 ` Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4803994d-f519-a6b6-f5bb-a2f50d91ecd7@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=edubezval@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rui.zhang@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.