From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754719AbcATXGS (ORCPT ); Wed, 20 Jan 2016 18:06:18 -0500 Received: from gloria.sntech.de ([95.129.55.99]:51290 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751821AbcATXGP (ORCPT ); Wed, 20 Jan 2016 18:06:15 -0500 From: Heiko Stuebner To: Chris Zhong Cc: linux-rockchip@lists.infradead.org, mark.yao@rock-chips.com, treding@nvidia.com, Russell King , devicetree@vger.kernel.org, Kumar Gala , linux-kernel@vger.kernel.org, Ian Campbell , Rob Herring , Pawel Moll , Mark Rutland , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 5/5] ARM: dts: rockchip: add support mipi panel tv080wum-nl0 Date: Wed, 20 Jan 2016 23:25:03 +0100 Message-ID: <4804270.fNNME6HN13@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <569EDE2F.6060400@rock-chips.com> References: <1452053038-32098-1-git-send-email-zyw@rock-chips.com> <1649978.zzK0Pex4sR@phil> <569EDE2F.6060400@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 20. Januar 2016, 09:09:03 schrieb Chris Zhong: > Hi Heiko > > On 01/20/2016 03:26 AM, Heiko Stuebner wrote: > > Hi Chris, > > > > Am Mittwoch, 6. Januar 2016, 12:03:57 schrieb Chris Zhong: > >> This tv080wum-nl0 panel is a mipi panel, it can use in MIPI_TX socket > >> of rk3288 evb board. > >> > >> Signed-off-by: Chris Zhong > > > > [...] > > > >> diff --git a/arch/arm/boot/dts/rk3288-evb-act8846.dts > >> b/arch/arm/boot/dts/rk3288-evb-act8846.dts index e662147..7d5475b > >> 100644 > >> --- a/arch/arm/boot/dts/rk3288-evb-act8846.dts > >> +++ b/arch/arm/boot/dts/rk3288-evb-act8846.dts > >> @@ -50,6 +50,8 @@ > >> > >> gpio = <&gpio7 3 GPIO_ACTIVE_HIGH>; > >> pinctrl-names = "default"; > >> pinctrl-0 = <&lcd_en>; > >> > >> + regulator-always-on; > >> + regulator-boot-on; > > > > Is this only needed for the panel itself and can you try to get the > > panel > > supplies set up correctly instead in that case please? > > It is not only for panel, LCDC_VDD need this supply too. > And rk3288-evb-rk808.dts has set this regulator to always on, so I do > the same thing in here. ok, so we keep the regulator-always-on for now, but could probably still add the supply to the panel as well? That way once vcc_lcd handling is complete in the future, we don't get surprises :-) I guess I can add that power-supply property myself when applying. Heiko > > >> regulator-name = "vcc_lcd"; > >> vin-supply = <&vcc_io>; > >> > >> }; > >> > >> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi > >> b/arch/arm/boot/dts/rk3288-evb.dtsi index 4faabdb..0c91858 100644 > >> --- a/arch/arm/boot/dts/rk3288-evb.dtsi > >> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi > >> @@ -47,7 +47,7 @@ > >> > >> reg = <0x0 0x80000000>; > >> > >> }; > >> > >> - backlight { > >> + backlight: backlight { > >> > >> compatible = "pwm-backlight"; > >> brightness-levels = < > >> > >> 0 1 2 3 4 5 6 7 > >> > >> @@ -183,6 +183,16 @@ > >> > >> status = "okay"; > >> > >> }; > >> > >> +&mipi_dsi { > >> + status = "okay"; > >> + panel { > >> + compatible ="boe,tv080wum-nl0"; > >> + reg = <0>; > >> + backlight = <&backlight>; > >> + status = "okay"; > > > > in the evb-schematics I see, vcc_lcd as supply for the panel. > > > > So I'd think the panel node here should have a > > > > power-supply = <&vcc_lcd>; > > > > instead of having the always-on above? > > > > > > Thanks > > Heiko > > > >> + }; > >> +}; > >> + > >> > >> &sdmmc { > >> > >> bus-width = <4>; > >> cap-mmc-highspeed; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v7 5/5] ARM: dts: rockchip: add support mipi panel tv080wum-nl0 Date: Wed, 20 Jan 2016 23:25:03 +0100 Message-ID: <4804270.fNNME6HN13@phil> References: <1452053038-32098-1-git-send-email-zyw@rock-chips.com> <1649978.zzK0Pex4sR@phil> <569EDE2F.6060400@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <569EDE2F.6060400-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Chris Zhong Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , Pawel Moll , Ian Campbell , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Kumar Gala , treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org List-Id: devicetree@vger.kernel.org Am Mittwoch, 20. Januar 2016, 09:09:03 schrieb Chris Zhong: > Hi Heiko > > On 01/20/2016 03:26 AM, Heiko Stuebner wrote: > > Hi Chris, > > > > Am Mittwoch, 6. Januar 2016, 12:03:57 schrieb Chris Zhong: > >> This tv080wum-nl0 panel is a mipi panel, it can use in MIPI_TX socket > >> of rk3288 evb board. > >> > >> Signed-off-by: Chris Zhong > > > > [...] > > > >> diff --git a/arch/arm/boot/dts/rk3288-evb-act8846.dts > >> b/arch/arm/boot/dts/rk3288-evb-act8846.dts index e662147..7d5475b > >> 100644 > >> --- a/arch/arm/boot/dts/rk3288-evb-act8846.dts > >> +++ b/arch/arm/boot/dts/rk3288-evb-act8846.dts > >> @@ -50,6 +50,8 @@ > >> > >> gpio = <&gpio7 3 GPIO_ACTIVE_HIGH>; > >> pinctrl-names = "default"; > >> pinctrl-0 = <&lcd_en>; > >> > >> + regulator-always-on; > >> + regulator-boot-on; > > > > Is this only needed for the panel itself and can you try to get the > > panel > > supplies set up correctly instead in that case please? > > It is not only for panel, LCDC_VDD need this supply too. > And rk3288-evb-rk808.dts has set this regulator to always on, so I do > the same thing in here. ok, so we keep the regulator-always-on for now, but could probably still add the supply to the panel as well? That way once vcc_lcd handling is complete in the future, we don't get surprises :-) I guess I can add that power-supply property myself when applying. Heiko > > >> regulator-name = "vcc_lcd"; > >> vin-supply = <&vcc_io>; > >> > >> }; > >> > >> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi > >> b/arch/arm/boot/dts/rk3288-evb.dtsi index 4faabdb..0c91858 100644 > >> --- a/arch/arm/boot/dts/rk3288-evb.dtsi > >> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi > >> @@ -47,7 +47,7 @@ > >> > >> reg = <0x0 0x80000000>; > >> > >> }; > >> > >> - backlight { > >> + backlight: backlight { > >> > >> compatible = "pwm-backlight"; > >> brightness-levels = < > >> > >> 0 1 2 3 4 5 6 7 > >> > >> @@ -183,6 +183,16 @@ > >> > >> status = "okay"; > >> > >> }; > >> > >> +&mipi_dsi { > >> + status = "okay"; > >> + panel { > >> + compatible ="boe,tv080wum-nl0"; > >> + reg = <0>; > >> + backlight = <&backlight>; > >> + status = "okay"; > > > > in the evb-schematics I see, vcc_lcd as supply for the panel. > > > > So I'd think the panel node here should have a > > > > power-supply = <&vcc_lcd>; > > > > instead of having the always-on above? > > > > > > Thanks > > Heiko > > > >> + }; > >> +}; > >> + > >> > >> &sdmmc { > >> > >> bus-width = <4>; > >> cap-mmc-highspeed; From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Wed, 20 Jan 2016 23:25:03 +0100 Subject: [PATCH v7 5/5] ARM: dts: rockchip: add support mipi panel tv080wum-nl0 In-Reply-To: <569EDE2F.6060400@rock-chips.com> References: <1452053038-32098-1-git-send-email-zyw@rock-chips.com> <1649978.zzK0Pex4sR@phil> <569EDE2F.6060400@rock-chips.com> Message-ID: <4804270.fNNME6HN13@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Mittwoch, 20. Januar 2016, 09:09:03 schrieb Chris Zhong: > Hi Heiko > > On 01/20/2016 03:26 AM, Heiko Stuebner wrote: > > Hi Chris, > > > > Am Mittwoch, 6. Januar 2016, 12:03:57 schrieb Chris Zhong: > >> This tv080wum-nl0 panel is a mipi panel, it can use in MIPI_TX socket > >> of rk3288 evb board. > >> > >> Signed-off-by: Chris Zhong > > > > [...] > > > >> diff --git a/arch/arm/boot/dts/rk3288-evb-act8846.dts > >> b/arch/arm/boot/dts/rk3288-evb-act8846.dts index e662147..7d5475b > >> 100644 > >> --- a/arch/arm/boot/dts/rk3288-evb-act8846.dts > >> +++ b/arch/arm/boot/dts/rk3288-evb-act8846.dts > >> @@ -50,6 +50,8 @@ > >> > >> gpio = <&gpio7 3 GPIO_ACTIVE_HIGH>; > >> pinctrl-names = "default"; > >> pinctrl-0 = <&lcd_en>; > >> > >> + regulator-always-on; > >> + regulator-boot-on; > > > > Is this only needed for the panel itself and can you try to get the > > panel > > supplies set up correctly instead in that case please? > > It is not only for panel, LCDC_VDD need this supply too. > And rk3288-evb-rk808.dts has set this regulator to always on, so I do > the same thing in here. ok, so we keep the regulator-always-on for now, but could probably still add the supply to the panel as well? That way once vcc_lcd handling is complete in the future, we don't get surprises :-) I guess I can add that power-supply property myself when applying. Heiko > > >> regulator-name = "vcc_lcd"; > >> vin-supply = <&vcc_io>; > >> > >> }; > >> > >> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi > >> b/arch/arm/boot/dts/rk3288-evb.dtsi index 4faabdb..0c91858 100644 > >> --- a/arch/arm/boot/dts/rk3288-evb.dtsi > >> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi > >> @@ -47,7 +47,7 @@ > >> > >> reg = <0x0 0x80000000>; > >> > >> }; > >> > >> - backlight { > >> + backlight: backlight { > >> > >> compatible = "pwm-backlight"; > >> brightness-levels = < > >> > >> 0 1 2 3 4 5 6 7 > >> > >> @@ -183,6 +183,16 @@ > >> > >> status = "okay"; > >> > >> }; > >> > >> +&mipi_dsi { > >> + status = "okay"; > >> + panel { > >> + compatible ="boe,tv080wum-nl0"; > >> + reg = <0>; > >> + backlight = <&backlight>; > >> + status = "okay"; > > > > in the evb-schematics I see, vcc_lcd as supply for the panel. > > > > So I'd think the panel node here should have a > > > > power-supply = <&vcc_lcd>; > > > > instead of having the always-on above? > > > > > > Thanks > > Heiko > > > >> + }; > >> +}; > >> + > >> > >> &sdmmc { > >> > >> bus-width = <4>; > >> cap-mmc-highspeed;