From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81223C49EAB for ; Thu, 24 Jun 2021 09:43:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6AB17613F8 for ; Thu, 24 Jun 2021 09:43:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232050AbhFXJp7 (ORCPT ); Thu, 24 Jun 2021 05:45:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:24265 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232019AbhFXJp5 (ORCPT ); Thu, 24 Jun 2021 05:45:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624527817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qkxHw284a/HcUQKczqJcr3hZxs0a/eNZzaMIqcieCR4=; b=N2dmpoXd8h1tJ/1jVQ8EadWoXvdJ00hsKd76ingRURI7ArP7YM3OVAqgd5iCcGtLbxK3C7 J0rwSiQGm1W62yubsHJcsSZWAiwG+R6YTX3bMtLXDw+7oAc+B11Z/3FqYtBXdPD45Pcc9x UB6haCnVbw5AnTQduuhTYeNyrGJRGKk= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-250-6v0P7LZmMfGGYuYLYjQlbw-1; Thu, 24 Jun 2021 05:43:36 -0400 X-MC-Unique: 6v0P7LZmMfGGYuYLYjQlbw-1 Received: by mail-ed1-f69.google.com with SMTP id h11-20020a50ed8b0000b02903947b9ca1f3so3052599edr.7 for ; Thu, 24 Jun 2021 02:43:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qkxHw284a/HcUQKczqJcr3hZxs0a/eNZzaMIqcieCR4=; b=oqdfDGfC232vz/KN04Sw64NtPUOF48q+ejJqHtn3Z1k8l1bOmSVhsZ7kuB0IlkleKV 5d1EXx4QZIO+OXCGSvAttqErIMb+iVrMFL2DfnCMlKVKr+pCwybK0K58uoxLhm1ZIfQ0 pahW8mLX+6Si4RNNU2L6yZKNpuz8nSL4RhW6T5v17EKXkuByM2CFK+oAzz66jGeIqgEy D77zOy3edxjPPxmD58C/5Jz2Eg6mluf0lh4P9dMg9rQ27I98oAUOgEgRICosR6rG19Oo s3JLq8ZOv3/E33Z1ctOqr5WvRNTVKRn4EDwH9KAFvsu9HkXhMgfNNTHBdZUCYFKSj0q6 qEaw== X-Gm-Message-State: AOAM532yS7To3zWC9mBzqYqBfN+uZJpDQOuIxQPioRKAuHsNhSMK0vQg x4NlyylcII95/MEekddrKF1AWwfVPcuc2pusU9ALx/DuKTXhiWLADH3WQH2qzTl6jRDKEAtGlqt 4hVrvxfLDn+u47IOYrS8w2vyW X-Received: by 2002:a05:6402:944:: with SMTP id h4mr5798158edz.76.1624527815210; Thu, 24 Jun 2021 02:43:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwD6cFFU4Uspcy5dTYBfn7A0VR+4loxnlaoo/QjHY9IN1nmjQ4mSQ+4egclMkG5+RC1oGdqOg== X-Received: by 2002:a05:6402:944:: with SMTP id h4mr5798117edz.76.1624527814999; Thu, 24 Jun 2021 02:43:34 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id t17sm1544705edv.75.2021.06.24.02.43.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 02:43:34 -0700 (PDT) Subject: Re: [PATCH 1/6] KVM: x86/mmu: release audited pfns To: Nicholas Piggin , Aleksandar Markovic , Huacai Chen , Marc Zyngier , Paul Mackerras , David Stevens , Zhenyu Wang , Zhi Wang Cc: Alexandru Elisei , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, James Morse , Jim Mattson , Joerg Roedel , kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Sean Christopherson , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Will Deacon References: <20210624035749.4054934-1-stevensd@google.com> <20210624035749.4054934-2-stevensd@google.com> <1624524156.04etgk7zmz.astroid@bobo.none> From: Paolo Bonzini Message-ID: <4816287a-b9a9-d3f4-f844-06922d696e06@redhat.com> Date: Thu, 24 Jun 2021 11:43:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1624524156.04etgk7zmz.astroid@bobo.none> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/06/21 10:43, Nicholas Piggin wrote: > Excerpts from David Stevens's message of June 24, 2021 1:57 pm: >> From: David Stevens > > Changelog? This looks like a bug, should it have a Fixes: tag? Probably has been there forever... The best way to fix the bug would be to nuke mmu_audit.c, which I've threatened to do many times but never followed up on. Paolo > Thanks, > Nick > >> >> Signed-off-by: David Stevens >> --- >> arch/x86/kvm/mmu/mmu_audit.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/x86/kvm/mmu/mmu_audit.c b/arch/x86/kvm/mmu/mmu_audit.c >> index cedc17b2f60e..97ff184084b4 100644 >> --- a/arch/x86/kvm/mmu/mmu_audit.c >> +++ b/arch/x86/kvm/mmu/mmu_audit.c >> @@ -121,6 +121,8 @@ static void audit_mappings(struct kvm_vcpu *vcpu, u64 *sptep, int level) >> audit_printk(vcpu->kvm, "levels %d pfn %llx hpa %llx " >> "ent %llxn", vcpu->arch.mmu->root_level, pfn, >> hpa, *sptep); >> + >> + kvm_release_pfn_clean(pfn); >> } >> >> static void inspect_spte_has_rmap(struct kvm *kvm, u64 *sptep) >> -- >> 2.32.0.93.g670b81a890-goog >> >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A81DC48BDF for ; Thu, 24 Jun 2021 09:44:10 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB5E2613C3 for ; Thu, 24 Jun 2021 09:44:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB5E2613C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4G9Zw86kDhz3bwD for ; Thu, 24 Jun 2021 19:44:08 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=N2dmpoXd; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=N2dmpoXd; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=216.205.24.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=pbonzini@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=N2dmpoXd; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=N2dmpoXd; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4G9Zvd65NQz2yy9 for ; Thu, 24 Jun 2021 19:43:41 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624527817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qkxHw284a/HcUQKczqJcr3hZxs0a/eNZzaMIqcieCR4=; b=N2dmpoXd8h1tJ/1jVQ8EadWoXvdJ00hsKd76ingRURI7ArP7YM3OVAqgd5iCcGtLbxK3C7 J0rwSiQGm1W62yubsHJcsSZWAiwG+R6YTX3bMtLXDw+7oAc+B11Z/3FqYtBXdPD45Pcc9x UB6haCnVbw5AnTQduuhTYeNyrGJRGKk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624527817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qkxHw284a/HcUQKczqJcr3hZxs0a/eNZzaMIqcieCR4=; b=N2dmpoXd8h1tJ/1jVQ8EadWoXvdJ00hsKd76ingRURI7ArP7YM3OVAqgd5iCcGtLbxK3C7 J0rwSiQGm1W62yubsHJcsSZWAiwG+R6YTX3bMtLXDw+7oAc+B11Z/3FqYtBXdPD45Pcc9x UB6haCnVbw5AnTQduuhTYeNyrGJRGKk= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-213-7na6HJe3Mz2pYS546FefiA-1; Thu, 24 Jun 2021 05:43:36 -0400 X-MC-Unique: 7na6HJe3Mz2pYS546FefiA-1 Received: by mail-ed1-f70.google.com with SMTP id j19-20020aa7c4130000b029039497d5cdbeso3022433edq.15 for ; Thu, 24 Jun 2021 02:43:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qkxHw284a/HcUQKczqJcr3hZxs0a/eNZzaMIqcieCR4=; b=e0+fqKtzJYxcA1IszEoTV437ksFLEfaJVALDUvOMzKMVJS+vuPTCklL5Yv7m8ukjpv jCECxtWTinCwR7mleCbrjfSG9lWLihr80B4WLcoauTdJ+9v9IRpOvIFpOi+85M+RO6X8 XyoOzmXceDxHCvcEbFdiGNBM9EefjFTO9wSpXBUecGbOjaZevXJUsxnepXw7G3+BIF+S 4LZfmz+7+mD9truG3da7CmWsQbckG1xFtWvcnXt5mEYO0CXwEc88cC+pzB7uI+EIiudR 9mJr+our0+TfdhBF6k2I/L3Iuo6FyPZhopS1jyESdKBSC3179tjDMEV4ri30Ss7Gvw3Q IUeg== X-Gm-Message-State: AOAM533cV7++hNk1+nHz7W1q7ehZqj7jDtL6mBAMdqe/AKKagmomLF2F 49oX4X1Q64QXtNuD50XBt8X5omcqdmlCl6Vlgd1uclPcrFptiZKFu9u6jBx8np8zGrjytrsu94n n67zquSboeDkmzmg3Lr48YQ33Wg== X-Received: by 2002:a05:6402:944:: with SMTP id h4mr5798146edz.76.1624527815210; Thu, 24 Jun 2021 02:43:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwD6cFFU4Uspcy5dTYBfn7A0VR+4loxnlaoo/QjHY9IN1nmjQ4mSQ+4egclMkG5+RC1oGdqOg== X-Received: by 2002:a05:6402:944:: with SMTP id h4mr5798117edz.76.1624527814999; Thu, 24 Jun 2021 02:43:34 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id t17sm1544705edv.75.2021.06.24.02.43.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 02:43:34 -0700 (PDT) Subject: Re: [PATCH 1/6] KVM: x86/mmu: release audited pfns To: Nicholas Piggin , Aleksandar Markovic , Huacai Chen , Marc Zyngier , Paul Mackerras , David Stevens , Zhenyu Wang , Zhi Wang References: <20210624035749.4054934-1-stevensd@google.com> <20210624035749.4054934-2-stevensd@google.com> <1624524156.04etgk7zmz.astroid@bobo.none> From: Paolo Bonzini Message-ID: <4816287a-b9a9-d3f4-f844-06922d696e06@redhat.com> Date: Thu, 24 Jun 2021 11:43:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1624524156.04etgk7zmz.astroid@bobo.none> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wanpeng Li , kvm@vger.kernel.org, Suzuki K Poulose , Alexandru Elisei , intel-gfx@lists.freedesktop.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kvmarm@lists.cs.columbia.edu, Will Deacon , James Morse , kvm-ppc@vger.kernel.org, Sean Christopherson , Vitaly Kuznetsov , linux-mips@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Jim Mattson Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 24/06/21 10:43, Nicholas Piggin wrote: > Excerpts from David Stevens's message of June 24, 2021 1:57 pm: >> From: David Stevens > > Changelog? This looks like a bug, should it have a Fixes: tag? Probably has been there forever... The best way to fix the bug would be to nuke mmu_audit.c, which I've threatened to do many times but never followed up on. Paolo > Thanks, > Nick > >> >> Signed-off-by: David Stevens >> --- >> arch/x86/kvm/mmu/mmu_audit.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/x86/kvm/mmu/mmu_audit.c b/arch/x86/kvm/mmu/mmu_audit.c >> index cedc17b2f60e..97ff184084b4 100644 >> --- a/arch/x86/kvm/mmu/mmu_audit.c >> +++ b/arch/x86/kvm/mmu/mmu_audit.c >> @@ -121,6 +121,8 @@ static void audit_mappings(struct kvm_vcpu *vcpu, u64 *sptep, int level) >> audit_printk(vcpu->kvm, "levels %d pfn %llx hpa %llx " >> "ent %llxn", vcpu->arch.mmu->root_level, pfn, >> hpa, *sptep); >> + >> + kvm_release_pfn_clean(pfn); >> } >> >> static void inspect_spte_has_rmap(struct kvm *kvm, u64 *sptep) >> -- >> 2.32.0.93.g670b81a890-goog >> >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB4F4C49EA7 for ; Thu, 24 Jun 2021 09:43:41 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 855A9613FA for ; Thu, 24 Jun 2021 09:43:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 855A9613FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 097584B253; Thu, 24 Jun 2021 05:43:41 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b9L09-+-qQB2; Thu, 24 Jun 2021 05:43:39 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D09324B25F; Thu, 24 Jun 2021 05:43:39 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A7EE14B253 for ; Thu, 24 Jun 2021 05:43:38 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w+vU5MqbjBDA for ; Thu, 24 Jun 2021 05:43:37 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B7E484B20A for ; Thu, 24 Jun 2021 05:43:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624527817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qkxHw284a/HcUQKczqJcr3hZxs0a/eNZzaMIqcieCR4=; b=N2dmpoXd8h1tJ/1jVQ8EadWoXvdJ00hsKd76ingRURI7ArP7YM3OVAqgd5iCcGtLbxK3C7 J0rwSiQGm1W62yubsHJcsSZWAiwG+R6YTX3bMtLXDw+7oAc+B11Z/3FqYtBXdPD45Pcc9x UB6haCnVbw5AnTQduuhTYeNyrGJRGKk= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-314-7GAwkTWeP4KIrrcSq3hI7Q-1; Thu, 24 Jun 2021 05:43:36 -0400 X-MC-Unique: 7GAwkTWeP4KIrrcSq3hI7Q-1 Received: by mail-ed1-f71.google.com with SMTP id v8-20020a0564023488b0290393873961f6so3032647edc.17 for ; Thu, 24 Jun 2021 02:43:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qkxHw284a/HcUQKczqJcr3hZxs0a/eNZzaMIqcieCR4=; b=q0QH+fx3122Bqvrw0fLWuoEcHi76p2YDECWIJDCNNisMJeNY7C06ItTpzMkmMxAI1D IQJi5lh2dYUhxJagT9OuCu2gGHKUKPGIPlJQpxwCpTqG5INtijuPF5YzScuLKi++Bl58 lB96/HiweORjTfdB/lkf2EjepuTZ1KYIvFO8zHFMS+s5Rlv/7ZjsC8ixlq1wJRILnh4C tsiPybHBQRSwB4x+pq5Bih0UMP+eTSeHPCpk8tdp+U5WXWsnVNTlkzPr7mp9SxBwsvEX RFUbq56P2S55qFyJfjFwPSadndWtoI3yYH7qP+is5437M14BhpcowSfOzefLHK4xD4EW 8AvA== X-Gm-Message-State: AOAM530aztgZwF8nFB5gv69mGpkIb84iAnwDwTz4MT+lMxnTUeRYVBBs pDKAsx9sG9ZOb/3rNzOhGSqQ8vjb3zos7Xtf8VrNz6LWGlmv54zNOxsE3jcE8WHQrSjMvw8vWyM 92++GGxoYTh14UVYvOl7iBk17 X-Received: by 2002:a05:6402:944:: with SMTP id h4mr5798149edz.76.1624527815210; Thu, 24 Jun 2021 02:43:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwD6cFFU4Uspcy5dTYBfn7A0VR+4loxnlaoo/QjHY9IN1nmjQ4mSQ+4egclMkG5+RC1oGdqOg== X-Received: by 2002:a05:6402:944:: with SMTP id h4mr5798117edz.76.1624527814999; Thu, 24 Jun 2021 02:43:34 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id t17sm1544705edv.75.2021.06.24.02.43.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 02:43:34 -0700 (PDT) Subject: Re: [PATCH 1/6] KVM: x86/mmu: release audited pfns To: Nicholas Piggin , Aleksandar Markovic , Huacai Chen , Marc Zyngier , Paul Mackerras , David Stevens , Zhenyu Wang , Zhi Wang References: <20210624035749.4054934-1-stevensd@google.com> <20210624035749.4054934-2-stevensd@google.com> <1624524156.04etgk7zmz.astroid@bobo.none> From: Paolo Bonzini Message-ID: <4816287a-b9a9-d3f4-f844-06922d696e06@redhat.com> Date: Thu, 24 Jun 2021 11:43:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1624524156.04etgk7zmz.astroid@bobo.none> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Wanpeng Li , kvm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kvmarm@lists.cs.columbia.edu, Will Deacon , kvm-ppc@vger.kernel.org, Sean Christopherson , Vitaly Kuznetsov , linux-mips@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Jim Mattson X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 24/06/21 10:43, Nicholas Piggin wrote: > Excerpts from David Stevens's message of June 24, 2021 1:57 pm: >> From: David Stevens > > Changelog? This looks like a bug, should it have a Fixes: tag? Probably has been there forever... The best way to fix the bug would be to nuke mmu_audit.c, which I've threatened to do many times but never followed up on. Paolo > Thanks, > Nick > >> >> Signed-off-by: David Stevens >> --- >> arch/x86/kvm/mmu/mmu_audit.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/x86/kvm/mmu/mmu_audit.c b/arch/x86/kvm/mmu/mmu_audit.c >> index cedc17b2f60e..97ff184084b4 100644 >> --- a/arch/x86/kvm/mmu/mmu_audit.c >> +++ b/arch/x86/kvm/mmu/mmu_audit.c >> @@ -121,6 +121,8 @@ static void audit_mappings(struct kvm_vcpu *vcpu, u64 *sptep, int level) >> audit_printk(vcpu->kvm, "levels %d pfn %llx hpa %llx " >> "ent %llxn", vcpu->arch.mmu->root_level, pfn, >> hpa, *sptep); >> + >> + kvm_release_pfn_clean(pfn); >> } >> >> static void inspect_spte_has_rmap(struct kvm *kvm, u64 *sptep) >> -- >> 2.32.0.93.g670b81a890-goog >> >> > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 442F5C48BDF for ; Thu, 24 Jun 2021 09:45:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06ECD613F9 for ; Thu, 24 Jun 2021 09:45:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06ECD613F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h/d2m1yLJzrWoe+yyODoNmkDSUmPHyOD/g3oZ3hRGhk=; b=vL5m8dBz/+7dGyhMHln3oug/MG n04s+HgsAsE/13DOyT4qolN2OgfX7fGWpa4swpboevpTHEciEiu+rDDpVybiwByuXefppQWVGfmcH X/TtrfZiu2LxeEvyufbbSO+HFMoF/zUKug5+nqdEDeMFMwqh0WagzJy5BB44S7XHjtAb7X2O6iGS3 pwZoQ1D0XiqT97i1IGZMmDJIsQ6OSZ1b80N0Y9s6dHHgHofsJ80UpBPn5G0vSKiXhcrOJcWfYWQmt Nj88PqWiqPitJDeXMQdxbtAScY3MZp6qMtq1YsQPArMF78kjVayqBx0cFc0usuHRag00zwxaIVUY8 PeParwwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwLtf-00Dmwl-La; Thu, 24 Jun 2021 09:43:45 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwLta-00DmvQ-DV for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 09:43:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624527817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qkxHw284a/HcUQKczqJcr3hZxs0a/eNZzaMIqcieCR4=; b=N2dmpoXd8h1tJ/1jVQ8EadWoXvdJ00hsKd76ingRURI7ArP7YM3OVAqgd5iCcGtLbxK3C7 J0rwSiQGm1W62yubsHJcsSZWAiwG+R6YTX3bMtLXDw+7oAc+B11Z/3FqYtBXdPD45Pcc9x UB6haCnVbw5AnTQduuhTYeNyrGJRGKk= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-240-e4f3f42WPCGZJDExahJSsA-1; Thu, 24 Jun 2021 05:43:36 -0400 X-MC-Unique: e4f3f42WPCGZJDExahJSsA-1 Received: by mail-ed1-f69.google.com with SMTP id j15-20020a05640211cfb0290394f9de5750so2459353edw.16 for ; Thu, 24 Jun 2021 02:43:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qkxHw284a/HcUQKczqJcr3hZxs0a/eNZzaMIqcieCR4=; b=GQrJBTtuik/vtW5/ET7eqi6VdzMmumckq71pEztOxGbxYwmg/0jP3/b7t3cIwmaPgC Ncu+tQ+pL3PNJFdhQelPV+mx+lzQz+ucUlpfrHBbZJp/PXJPOpM82zJF6tWtuTthCRf5 jZ+LkwLUXsUJCxA/IC36xOh+a88nKwq0FxZDOhfkVkUtSC9nWpRf0AyTc+xCmAyiEm3D f+W5c+n7jQfCbHsh1He/yTk9iAB4nxvX6GbCwnn94LfNHfZ9jfVVIMGjVnaXjOws3/os Ye0JXa6ccd6py2XZVPmJzlHTXcjJoG5T5BZv9dWmhXrUT9XXzZLoOdupM52ILPeUTf5+ L73Q== X-Gm-Message-State: AOAM533zdjkfZ9QCPFxtBEM4ZPfD4pDdaMyJRYS3xYRZaiEyOPn33HC6 8GnMti59WByKQZer2kNa30mG9YsG50KEZVGgt4W/wlkD0x1SOc3aA8n2QMgY8+vpMz+aJh2rKuM X7U8L/iuYl1hjUUVOD3tDGuhkg6K2Xav4Fno= X-Received: by 2002:a05:6402:944:: with SMTP id h4mr5798162edz.76.1624527815210; Thu, 24 Jun 2021 02:43:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwD6cFFU4Uspcy5dTYBfn7A0VR+4loxnlaoo/QjHY9IN1nmjQ4mSQ+4egclMkG5+RC1oGdqOg== X-Received: by 2002:a05:6402:944:: with SMTP id h4mr5798117edz.76.1624527814999; Thu, 24 Jun 2021 02:43:34 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id t17sm1544705edv.75.2021.06.24.02.43.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 02:43:34 -0700 (PDT) Subject: Re: [PATCH 1/6] KVM: x86/mmu: release audited pfns To: Nicholas Piggin , Aleksandar Markovic , Huacai Chen , Marc Zyngier , Paul Mackerras , David Stevens , Zhenyu Wang , Zhi Wang Cc: Alexandru Elisei , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, James Morse , Jim Mattson , Joerg Roedel , kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Sean Christopherson , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Will Deacon References: <20210624035749.4054934-1-stevensd@google.com> <20210624035749.4054934-2-stevensd@google.com> <1624524156.04etgk7zmz.astroid@bobo.none> From: Paolo Bonzini Message-ID: <4816287a-b9a9-d3f4-f844-06922d696e06@redhat.com> Date: Thu, 24 Jun 2021 11:43:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1624524156.04etgk7zmz.astroid@bobo.none> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_024338_583637_C84ED67B X-CRM114-Status: GOOD ( 16.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/06/21 10:43, Nicholas Piggin wrote: > Excerpts from David Stevens's message of June 24, 2021 1:57 pm: >> From: David Stevens > > Changelog? This looks like a bug, should it have a Fixes: tag? Probably has been there forever... The best way to fix the bug would be to nuke mmu_audit.c, which I've threatened to do many times but never followed up on. Paolo > Thanks, > Nick > >> >> Signed-off-by: David Stevens >> --- >> arch/x86/kvm/mmu/mmu_audit.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/x86/kvm/mmu/mmu_audit.c b/arch/x86/kvm/mmu/mmu_audit.c >> index cedc17b2f60e..97ff184084b4 100644 >> --- a/arch/x86/kvm/mmu/mmu_audit.c >> +++ b/arch/x86/kvm/mmu/mmu_audit.c >> @@ -121,6 +121,8 @@ static void audit_mappings(struct kvm_vcpu *vcpu, u64 *sptep, int level) >> audit_printk(vcpu->kvm, "levels %d pfn %llx hpa %llx " >> "ent %llxn", vcpu->arch.mmu->root_level, pfn, >> hpa, *sptep); >> + >> + kvm_release_pfn_clean(pfn); >> } >> >> static void inspect_spte_has_rmap(struct kvm *kvm, u64 *sptep) >> -- >> 2.32.0.93.g670b81a890-goog >> >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2DDBC49EA6 for ; Thu, 24 Jun 2021 09:43:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B34DA613C3 for ; Thu, 24 Jun 2021 09:43:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B34DA613C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 597E26EB44; Thu, 24 Jun 2021 09:43:40 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id A3E8E6EB42 for ; Thu, 24 Jun 2021 09:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624527818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qkxHw284a/HcUQKczqJcr3hZxs0a/eNZzaMIqcieCR4=; b=iSkSWDThPeWOYvLyec0qbHxJOjoFmxb2A/uKpvdXQeWxBhSTlf1vUi3b7j2azBIk+odaeU SgJH25r2kKf0+p2Xqkk5kL+I4DhLHDZHuEoCQLMIgeDHxra0URkf+qj/YmdqBwyw9WbKlS XrUHdwCJiioDAWqEuY7zFGBnOQb6+v8= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-314-Ee-aGcjzNLC2ySsP4cr9GA-1; Thu, 24 Jun 2021 05:43:36 -0400 X-MC-Unique: Ee-aGcjzNLC2ySsP4cr9GA-1 Received: by mail-ed1-f72.google.com with SMTP id g13-20020a056402090db02903935a4cb74fso3050240edz.1 for ; Thu, 24 Jun 2021 02:43:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qkxHw284a/HcUQKczqJcr3hZxs0a/eNZzaMIqcieCR4=; b=QnpIoKuotNS2Loj8gRSMpJ5yU4CfHSyWPyYPhw7p9hrQpgCkuEl3eK48AXR/L2P8T4 Q+6BwotgNQMKvEc2HmYmIPRNNx0WhszPosou4z5yOngPrCfuZTaAuS+KQh+dQsge3AqA uilSDddBGrV3ZYLZyGhZ2n/lrwv7Qul9BXrIZbrTpfhxvdfLGJEPnjTUhYGWKst0XO2U G3eAp4VzDwnE//qorbdFmFtongzrqwQhLtkCvYhdL+FCNrCqvBHwqztQJbZi35tyTOt5 CD1xBucXnQOb89S0Bsq8+ima2GAxDE6W1mgoMAQpMpRANpXde//IMRUd0d02XAAD6oC8 uogg== X-Gm-Message-State: AOAM530tZvLj8RyxG0iAkJXb3uKVGXQyqkgWd71mN7xa/oSf4nOI7aXm 5IfT9D1qVEpbbyxtb+/Vky9TtGhGFJDDNbB3tC9+BHHevZ24Z27oIpXbFJukdZDBDhOHHrbGvp3 23dQC9VPApnQrc8mSVDW+qW7Be+C1 X-Received: by 2002:a05:6402:944:: with SMTP id h4mr5798150edz.76.1624527815210; Thu, 24 Jun 2021 02:43:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwD6cFFU4Uspcy5dTYBfn7A0VR+4loxnlaoo/QjHY9IN1nmjQ4mSQ+4egclMkG5+RC1oGdqOg== X-Received: by 2002:a05:6402:944:: with SMTP id h4mr5798117edz.76.1624527814999; Thu, 24 Jun 2021 02:43:34 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id t17sm1544705edv.75.2021.06.24.02.43.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 02:43:34 -0700 (PDT) To: Nicholas Piggin , Aleksandar Markovic , Huacai Chen , Marc Zyngier , Paul Mackerras , David Stevens , Zhenyu Wang , Zhi Wang References: <20210624035749.4054934-1-stevensd@google.com> <20210624035749.4054934-2-stevensd@google.com> <1624524156.04etgk7zmz.astroid@bobo.none> From: Paolo Bonzini Message-ID: <4816287a-b9a9-d3f4-f844-06922d696e06@redhat.com> Date: Thu, 24 Jun 2021 11:43:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1624524156.04etgk7zmz.astroid@bobo.none> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 1/6] KVM: x86/mmu: release audited pfns X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wanpeng Li , kvm@vger.kernel.org, Suzuki K Poulose , Alexandru Elisei , intel-gfx@lists.freedesktop.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kvmarm@lists.cs.columbia.edu, Will Deacon , James Morse , kvm-ppc@vger.kernel.org, Sean Christopherson , Vitaly Kuznetsov , linux-mips@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Jim Mattson Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 24/06/21 10:43, Nicholas Piggin wrote: > Excerpts from David Stevens's message of June 24, 2021 1:57 pm: >> From: David Stevens > > Changelog? This looks like a bug, should it have a Fixes: tag? Probably has been there forever... The best way to fix the bug would be to nuke mmu_audit.c, which I've threatened to do many times but never followed up on. Paolo > Thanks, > Nick > >> >> Signed-off-by: David Stevens >> --- >> arch/x86/kvm/mmu/mmu_audit.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/x86/kvm/mmu/mmu_audit.c b/arch/x86/kvm/mmu/mmu_audit.c >> index cedc17b2f60e..97ff184084b4 100644 >> --- a/arch/x86/kvm/mmu/mmu_audit.c >> +++ b/arch/x86/kvm/mmu/mmu_audit.c >> @@ -121,6 +121,8 @@ static void audit_mappings(struct kvm_vcpu *vcpu, u64 *sptep, int level) >> audit_printk(vcpu->kvm, "levels %d pfn %llx hpa %llx " >> "ent %llxn", vcpu->arch.mmu->root_level, pfn, >> hpa, *sptep); >> + >> + kvm_release_pfn_clean(pfn); >> } >> >> static void inspect_spte_has_rmap(struct kvm *kvm, u64 *sptep) >> -- >> 2.32.0.93.g670b81a890-goog >> >> > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Date: Thu, 24 Jun 2021 09:43:32 +0000 Subject: Re: [PATCH 1/6] KVM: x86/mmu: release audited pfns Message-Id: <4816287a-b9a9-d3f4-f844-06922d696e06@redhat.com> List-Id: References: <20210624035749.4054934-1-stevensd@google.com> <20210624035749.4054934-2-stevensd@google.com> <1624524156.04etgk7zmz.astroid@bobo.none> In-Reply-To: <1624524156.04etgk7zmz.astroid@bobo.none> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Nicholas Piggin , Aleksandar Markovic , Huacai Chen , Marc Zyngier , Paul Mackerras , David Stevens , Zhenyu Wang , Zhi Wang Cc: Alexandru Elisei , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, James Morse , Jim Mattson , Joerg Roedel , kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Sean Christopherson , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Will Deacon On 24/06/21 10:43, Nicholas Piggin wrote: > Excerpts from David Stevens's message of June 24, 2021 1:57 pm: >> From: David Stevens > > Changelog? This looks like a bug, should it have a Fixes: tag? Probably has been there forever... The best way to fix the bug would be to nuke mmu_audit.c, which I've threatened to do many times but never followed up on. Paolo > Thanks, > Nick > >> >> Signed-off-by: David Stevens >> --- >> arch/x86/kvm/mmu/mmu_audit.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/x86/kvm/mmu/mmu_audit.c b/arch/x86/kvm/mmu/mmu_audit.c >> index cedc17b2f60e..97ff184084b4 100644 >> --- a/arch/x86/kvm/mmu/mmu_audit.c >> +++ b/arch/x86/kvm/mmu/mmu_audit.c >> @@ -121,6 +121,8 @@ static void audit_mappings(struct kvm_vcpu *vcpu, u64 *sptep, int level) >> audit_printk(vcpu->kvm, "levels %d pfn %llx hpa %llx " >> "ent %llxn", vcpu->arch.mmu->root_level, pfn, >> hpa, *sptep); >> + >> + kvm_release_pfn_clean(pfn); >> } >> >> static void inspect_spte_has_rmap(struct kvm *kvm, u64 *sptep) >> -- >> 2.32.0.93.g670b81a890-goog >> >> >