All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Shtylyov <s.shtylyov@omprussia.ru>
To: Bart Van Assche <bvanassche@acm.org>,
	Avri Altman <avri.altman@wdc.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	<linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] scsi: ufshcd-pltfrm: fix deferred probing
Date: Tue, 30 Mar 2021 15:25:47 +0300	[thread overview]
Message-ID: <481ba2ec-8480-7f87-1d75-15b11e87e2ad@omprussia.ru> (raw)
In-Reply-To: <52c081b2-2f66-ee7b-4dcd-d106106dfd3d@acm.org>

On 3/30/21 12:06 AM, Bart Van Assche wrote:

>> The driver overrides the error codes returned by platform_get_irq() to
>> -ENODEV, so if it returns -EPROBE_DEFER, the driver would fail the probe
>> permanently instead of the deferred probing.  Propagate the error code
>> upstream, as it should have been done from the start...
>>
>> Fixes: 2953f850c3b8 ("[SCSI] ufs: use devres functions for ufshcd")
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
> 
> Hi Sergey,
> 
> How has this patch been tested?

   Only build-tested.
   Misusing platfrom_get_irq() appears a common issue. :-(

> Thanks,
> 
> Bart.

MBR, Sergei

  reply	other threads:[~2021-03-30 12:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29 20:50 [PATCH] scsi: ufshcd-pltfrm: fix deferred probing Sergey Shtylyov
2021-03-29 21:06 ` Bart Van Assche
2021-03-30 12:25   ` Sergey Shtylyov [this message]
2021-04-16  2:51 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=481ba2ec-8480-7f87-1d75-15b11e87e2ad@omprussia.ru \
    --to=s.shtylyov@omprussia.ru \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.