All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Meh Mbeh Ida Delphine <idadelm@gmail.com>, yocto@lists.yoctoproject.org
Cc: mark.hatle@kernel.crashing.org
Subject: Re: [yocto] [prelink-cross][PATCH] Add SPDX license headers to all source files
Date: Thu, 04 Feb 2021 17:17:46 +0000	[thread overview]
Message-ID: <482207e7ba33b79b30e1357c64fd85353519f00b.camel@linuxfoundation.org> (raw)
In-Reply-To: <20210202105438.21650-1-idadelm@gmail.com>

On Tue, 2021-02-02 at 11:54 +0100, Meh Mbeh Ida Delphine wrote:
> From: Meh Mbeh Ida Delphine <idadelm@gmail.com>
> 
> Added SPDX headers in all source files except src/makecrc.c since it is not copyrighted.
> Skipped Makefile.am as well.
> Also cleared redundant license text.
> Updated README file with correct email addresses.
> 
> Fixes: [YOCTO #13529]

Thanks for this. There are a couple of tweaks I noticed as I was about
to merge it. Firstly, can you make the email address update a separate
commit please. Commits should do one logical thing.
> 
> -   The GNU C Library is free software; you can redistribute it and/or
> -   modify it under the terms of the GNU Lesser General Public
> -   License as published by the Free Software Foundation; either
> -   version 2.1 of the License, or (at your option) any later version.
> -
> -   The GNU C Library is distributed in the hope that it will be useful,
> -   but WITHOUT ANY WARRANTY; without even the implied warranty of
> -   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -   Lesser General Public License for more details.
> -
> -   You should have received a copy of the GNU Lesser General Public
> -   License along with the GNU C Library; if not, write to the Free
> -   Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
> -   02111-1307 USA.  */
> +* SPDX-License-Identifier: GPL-2.0-or-later
> +*/
> 

This file mentions "GNU Lesser General Public License" and version 2.1
which is not GPL-2.0!

It is critical to get this bit right.

Cheers,

Richard


  parent reply	other threads:[~2021-02-04 17:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02 10:54 [prelink-cross][PATCH] Add SPDX license headers to all source files Meh Mbeh Ida Delphine
2021-02-02 21:19 ` Mark Hatle
2021-02-04 17:17 ` Richard Purdie [this message]
2021-02-05  7:48   ` [yocto] " Robert Berger
     [not found] <165FE8F0D05B65CB.16314@lists.yoctoproject.org>
2021-02-02 10:59 ` Meh Mbeh Ida Delphine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482207e7ba33b79b30e1357c64fd85353519f00b.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=idadelm@gmail.com \
    --cc=mark.hatle@kernel.crashing.org \
    --cc=yocto@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.