From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752715AbdBILbw (ORCPT ); Thu, 9 Feb 2017 06:31:52 -0500 Received: from smtp81.iad3a.emailsrvr.com ([173.203.187.81]:58693 "EHLO smtp81.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752620AbdBILbu (ORCPT ); Thu, 9 Feb 2017 06:31:50 -0500 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH] staging: comedi: Fix incorrect type assignment To: Greg KH , Karthik Nayak References: <20170208202356.5662-1-Karthik.188@gmail.com> <20170209110433.GA31689@kroah.com> Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, kastolom@gmail.com From: Ian Abbott Message-ID: <482b9c8a-f48a-8e4c-20b0-c8dfc0ac2ed5@mev.co.uk> Date: Thu, 9 Feb 2017 11:22:41 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20170209110433.GA31689@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/02/2017 11:04, Greg KH wrote: > On Thu, Feb 09, 2017 at 01:53:56AM +0530, Karthik Nayak wrote: >> This patch fixes the following sparse error: >> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in assignment (different base types) >> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: expected restricted __be32 [usertype] serial_number >> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: got unsigned int >> >> This is done by removing the whole code block, since the variable >> 'serial_number' is only assigned but never used. >> >> Helped-by: Ian Abbott > > There's no such tag, sorry :( > > And does this obsolete all of your other ones? Please make it obvious > what I am supposed to do here. > > I've now dropped all of these patches from my queue. please resend the > proper one. > > thanks, > > greg k-h > To add to that, I think the emphasis of the patch title and description should now be on the removal of serial_number, with fixing the sparse error as a useful side-effect/inspiration. The patch title should also mention ni_pcimio. Thanks, Ian. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-