From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18CDDC433F5 for ; Tue, 7 Sep 2021 16:47:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE96E60E77 for ; Tue, 7 Sep 2021 16:47:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345011AbhIGQsr (ORCPT ); Tue, 7 Sep 2021 12:48:47 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:48546 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344752AbhIGQsp (ORCPT ); Tue, 7 Sep 2021 12:48:45 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 187GlTiG122068; Tue, 7 Sep 2021 11:47:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1631033249; bh=zJ4XDxcazJUychEqFAjufjQBTDd31o5RAnh+vygywfY=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=q2RZNtlX5DD7k8kQyb5/JOlY87xJdTb7GrqDCyHRH2VnDm9Wyl8LxZFsfapbIKhki q29/6ViSV/VPlO4SIJV74XZIpwktor+IBOMK/mblRCJN5z0AxAPqyURnmb9MQLjSxI 3X/ec2/yxrDF8DhS6dqGta6MT7WpyB+s7xa9owjg= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 187GlTro033026 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 7 Sep 2021 11:47:29 -0500 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Tue, 7 Sep 2021 11:47:29 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Tue, 7 Sep 2021 11:47:29 -0500 Received: from [10.250.232.51] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 187GlQIx038629; Tue, 7 Sep 2021 11:47:26 -0500 Subject: Re: [PATCH 1/3] arm64: dts: ti: iot2050: Flip mmc device ordering on Advanced devices To: Nishanth Menon , Jan Kiszka CC: Tero Kristo , Rob Herring , , , , Bao Cheng Su , Chao Zeng References: <8e2e435ef67868cb98382b44c51ddb5c8d045d66.1631024536.git.jan.kiszka@siemens.com> <20210907151301.7fqwmc7hmcyhhybv@carve> <35e0cadf-526c-6402-fb8e-8cdb8b7a0bfe@siemens.com> <20210907152746.fbddtkktvx6hb5ti@cattishly> <20210907153547.53cc2zx23rx72kqf@thyself> From: Aswath Govindraju Message-ID: <482dddc1-b1f8-15db-a0c5-0d6def5d859f@ti.com> Date: Tue, 7 Sep 2021 22:17:25 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210907153547.53cc2zx23rx72kqf@thyself> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nishanth, On 07/09/21 9:05 pm, Nishanth Menon wrote: > On 17:30-20210907, Jan Kiszka wrote: >> On 07.09.21 17:27, Nishanth Menon wrote: >>> On 17:20-20210907, Jan Kiszka wrote: >>>> On 07.09.21 17:13, Nishanth Menon wrote: >>>>> On 16:22-20210907, Jan Kiszka wrote: >>>>>> From: Jan Kiszka >>>>>> >>>>>> This ensures that the SD card will remain mmc0 across Basic and Advanced >>>>>> devices, also avoiding surprises for users coming from the downstream >>>>>> kernels. >>>>>> >>>>>> Signed-off-by: Jan Kiszka >>>>>> --- >>>>>> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts | 5 +++++ >>>>>> 1 file changed, 5 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts >>>>>> index ec9617c13cdb..d1d5278e0b94 100644 >>>>>> --- a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts >>>>>> +++ b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts >>>>>> @@ -18,6 +18,11 @@ / { >>>>>> compatible = "siemens,iot2050-advanced", "ti,am654"; >>>>>> model = "SIMATIC IOT2050 Advanced"; >>>>>> >>>>>> + aliases { >>>>>> + mmc0 = &sdhci1; >>>>>> + mmc1 = &sdhci0; >>>>>> + }; >>>>> >>>>> >>>>> Should we do this at SoC level? >>>>> >>>> >>>> Well, I wouldn't mind - but that would also impact your EVMs. For us, >>>> this is fine as we are coming from that ordering above with our >>>> downstream kernel/dts. >>>> >>> >>> I think it'd probably be a welcome change. overall we've standardized on >>> partuuid. >>> >> >> Yeah, it's more about "dd if=emmc.img of=/dev/mmcblk1 - damn, the wrong >> one again." >> >> Let me know what you prefer, and I'll update my patch. > > > Lets do it at SoC level. I will follow it up with a patch for other K3 > SoCs as well. > > > Unless someone has a strong opinion on this approach - if so, speak up > with reasons. > Making this change in SoC level for all K3 devices would force changes to be made in U-Boot too, for consistency. In U-Boot, a major change would be required in the environment variables to support this. As I don't see any functional advantage by making this change, I feel that this change would make things more confusing for users already using the K3 devices. At present, the ordering is consistent across all the K3 devices, I feel that keeping it the same way would be better. As for making changes only on IoT boards, if it is okay to have the ordering changed between U-Boot and kernel, I don't see any problem making this change in kernel alone. Thanks, Aswath From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D910FC433EF for ; Tue, 7 Sep 2021 16:49:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A36DE610C9 for ; Tue, 7 Sep 2021 16:49:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A36DE610C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=e/2mr8Y6/ccswmhyvS7mvq+gNxzWlqVeMxlCTSF/B4Y=; b=1c4ZC+i6fEqsBplkxFY2jI8R1n ZulW79uQYdVfyL8y+jbK83cF8q0SP+h9CeWrcs5E+4onrnPxPk5K8kNEJJAp/lM9OUdaYEbYTqfJ+ OzQn/KX0/vkSllRHogry8XobZaKwfmP/7IqpI60hXeo4nC7HBLjFpTaOPPG9yDlv56MCouomfUO3Y iuUYfRi3J7A2qzpqWnuZ4WuakCbJgXYBlgCXo3MnYuiNXizMFrsBJb7COx0G08bzNbR48iJ8NoU9A TzH1YFGCTAlXvoifzkmEZJo/zqmEYmAAtkfLIZJWN9spyMczdYami/uD2djI+S27/4s6+raNF00SZ rNO2YLSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNeG2-004FqM-W6; Tue, 07 Sep 2021 16:47:39 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNeFx-004Fns-8S for linux-arm-kernel@lists.infradead.org; Tue, 07 Sep 2021 16:47:34 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 187GlTiG122068; Tue, 7 Sep 2021 11:47:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1631033249; bh=zJ4XDxcazJUychEqFAjufjQBTDd31o5RAnh+vygywfY=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=q2RZNtlX5DD7k8kQyb5/JOlY87xJdTb7GrqDCyHRH2VnDm9Wyl8LxZFsfapbIKhki q29/6ViSV/VPlO4SIJV74XZIpwktor+IBOMK/mblRCJN5z0AxAPqyURnmb9MQLjSxI 3X/ec2/yxrDF8DhS6dqGta6MT7WpyB+s7xa9owjg= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 187GlTro033026 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 7 Sep 2021 11:47:29 -0500 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Tue, 7 Sep 2021 11:47:29 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Tue, 7 Sep 2021 11:47:29 -0500 Received: from [10.250.232.51] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 187GlQIx038629; Tue, 7 Sep 2021 11:47:26 -0500 Subject: Re: [PATCH 1/3] arm64: dts: ti: iot2050: Flip mmc device ordering on Advanced devices To: Nishanth Menon , Jan Kiszka CC: Tero Kristo , Rob Herring , , , , Bao Cheng Su , Chao Zeng References: <8e2e435ef67868cb98382b44c51ddb5c8d045d66.1631024536.git.jan.kiszka@siemens.com> <20210907151301.7fqwmc7hmcyhhybv@carve> <35e0cadf-526c-6402-fb8e-8cdb8b7a0bfe@siemens.com> <20210907152746.fbddtkktvx6hb5ti@cattishly> <20210907153547.53cc2zx23rx72kqf@thyself> From: Aswath Govindraju Message-ID: <482dddc1-b1f8-15db-a0c5-0d6def5d859f@ti.com> Date: Tue, 7 Sep 2021 22:17:25 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210907153547.53cc2zx23rx72kqf@thyself> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210907_094733_481790_2FF8CF22 X-CRM114-Status: GOOD ( 23.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nishanth, On 07/09/21 9:05 pm, Nishanth Menon wrote: > On 17:30-20210907, Jan Kiszka wrote: >> On 07.09.21 17:27, Nishanth Menon wrote: >>> On 17:20-20210907, Jan Kiszka wrote: >>>> On 07.09.21 17:13, Nishanth Menon wrote: >>>>> On 16:22-20210907, Jan Kiszka wrote: >>>>>> From: Jan Kiszka >>>>>> >>>>>> This ensures that the SD card will remain mmc0 across Basic and Advanced >>>>>> devices, also avoiding surprises for users coming from the downstream >>>>>> kernels. >>>>>> >>>>>> Signed-off-by: Jan Kiszka >>>>>> --- >>>>>> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts | 5 +++++ >>>>>> 1 file changed, 5 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts >>>>>> index ec9617c13cdb..d1d5278e0b94 100644 >>>>>> --- a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts >>>>>> +++ b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts >>>>>> @@ -18,6 +18,11 @@ / { >>>>>> compatible = "siemens,iot2050-advanced", "ti,am654"; >>>>>> model = "SIMATIC IOT2050 Advanced"; >>>>>> >>>>>> + aliases { >>>>>> + mmc0 = &sdhci1; >>>>>> + mmc1 = &sdhci0; >>>>>> + }; >>>>> >>>>> >>>>> Should we do this at SoC level? >>>>> >>>> >>>> Well, I wouldn't mind - but that would also impact your EVMs. For us, >>>> this is fine as we are coming from that ordering above with our >>>> downstream kernel/dts. >>>> >>> >>> I think it'd probably be a welcome change. overall we've standardized on >>> partuuid. >>> >> >> Yeah, it's more about "dd if=emmc.img of=/dev/mmcblk1 - damn, the wrong >> one again." >> >> Let me know what you prefer, and I'll update my patch. > > > Lets do it at SoC level. I will follow it up with a patch for other K3 > SoCs as well. > > > Unless someone has a strong opinion on this approach - if so, speak up > with reasons. > Making this change in SoC level for all K3 devices would force changes to be made in U-Boot too, for consistency. In U-Boot, a major change would be required in the environment variables to support this. As I don't see any functional advantage by making this change, I feel that this change would make things more confusing for users already using the K3 devices. At present, the ordering is consistent across all the K3 devices, I feel that keeping it the same way would be better. As for making changes only on IoT boards, if it is okay to have the ordering changed between U-Boot and kernel, I don't see any problem making this change in kernel alone. Thanks, Aswath _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel