From: "Azarewicz, PiotrX T" <piotrx.t.azarewicz@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"Doherty, Declan" <declan.doherty@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v1 1/1] examples/l2fwd-crypto: improve random key generator
Date: Wed, 8 Jun 2016 07:46:33 +0000 [thread overview]
Message-ID: <4837007523CC9A4B9414D20C13DE6E64136D27B2@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <21237364.CLn9ZV8ln9@xps13>
> 2016-05-25 15:34, Piotr Azarewicz:
> > This patch improve generate_random_key() function by replacing rand()
> > function with reading from /dev/urandom.
> >
> > CID 120136 : Calling risky function (DC.WEAK_CRYPTO)
> > dont_call: rand should not be used for security related applications,
> > as linear congruential algorithms are too easy to break
> >
> > Coverity issue: 120136
> >
> > Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
> > ---
> > examples/l2fwd-crypto/main.c | 18 +++++++++++++-----
>
> Is it relevant for this example?
Maybe not. But it don't break anything, and in the end make Coverity tool happy.
Declan, please share your opinion.
next prev parent reply other threads:[~2016-06-08 7:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 13:34 [PATCH v1 1/1] examples/l2fwd-crypto: improve random key generator Piotr Azarewicz
2016-06-07 20:30 ` Thomas Monjalon
2016-06-08 7:46 ` Azarewicz, PiotrX T [this message]
2016-07-11 14:17 ` Thomas Monjalon
2016-07-13 15:54 ` Declan Doherty
2016-07-13 15:55 ` Declan Doherty
2016-07-15 22:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4837007523CC9A4B9414D20C13DE6E64136D27B2@IRSMSX102.ger.corp.intel.com \
--to=piotrx.t.azarewicz@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.