[MPTCP] Re: [PATCH v2 5/6] mptcp: Export low-level routines for IPv6

[Paolo Abeni <pabeni at redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

On Wed, 2019-11-06 at 10:37 +0100, Matthieu Baerts wrote:
> Hi Paolo,
> 
> On 06/11/2019 10:03, Paolo Abeni wrote:
> > On Tue, 2019-11-05 at 20:41 -0800, Peter Krystad wrote:
> > > @@ -1111,7 +1111,8 @@ static void tcp_v6_restore_cb(struct sk_buff *skb)
> > >   		sizeof(struct inet6_skb_parm));
> > >   }
> > >   
> > > -static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk, struct sk_buff *skb,
> > > +static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk,
> > > +					 struct sk_buff *skb,
> > >   					 struct request_sock *req,
> > >   					 struct dst_entry *dst,
> > >   					 struct request_sock *req_unhash,
> > 
> > Minor nit: it looks like this chunk is not needed[1].
> 
> Peter replied this in the previous version of the patch:
> 
>  > It seemed like since I was in the neighborhood I would fix this
>  > over-80 char line. If that's not appropriate we can drop this chunk.

whoops, I missed that, sorry! And thank you for the head-up!

> I guess we should not modify the style of non MPTCP code. Then better to 
> drop this change, right?

Yes, exactly. The above change should be in a separate, non mptcp-
related patch.

Cheers,

Paolo