From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/2] scripts: add checkpatch wrapper Date: Fri, 23 Oct 2015 22:27:32 +0200 Message-ID: <4846214.yzCNZhmeXD@xps13> References: <1445615606-3885-1-git-send-email-thomas.monjalon@6wind.com> <4288301.N0F7Gaqfh8@xps13> <20151023095842.5249bdee@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Stephen Hemminger Return-path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id B5A663F9 for ; Fri, 23 Oct 2015 22:28:38 +0200 (CEST) Received: by wikq8 with SMTP id q8so92126833wik.1 for ; Fri, 23 Oct 2015 13:28:38 -0700 (PDT) In-Reply-To: <20151023095842.5249bdee@xeon-e3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-10-23 09:58, Stephen Hemminger: > On Fri, 23 Oct 2015 18:34:23 +0200 > Thomas Monjalon wrote: > > > > LINUX_VERSION_CODE > > > > It is used for out-of-tree modules. > > Actually for the kernel modules, all flags should be enabled. > It is kernel code and it should follow the kernel style conventions. No, version macros are needed in out of tree modules but forbidden upstream.