From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA449C4338F for ; Tue, 10 Aug 2021 15:09:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A25F60F02 for ; Tue, 10 Aug 2021 15:09:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2A25F60F02 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:38072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDTO6-0006Wp-2t for qemu-devel@archiver.kernel.org; Tue, 10 Aug 2021 11:09:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDTME-0003aR-7F for qemu-devel@nongnu.org; Tue, 10 Aug 2021 11:07:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46915) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDTM9-0001tr-Rx for qemu-devel@nongnu.org; Tue, 10 Aug 2021 11:07:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628608071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wQrJF8t9EReP04tyvPyrDyLNtvjcyc7yjipfp4ho0w0=; b=ClrqmvkLjCUDYHrhQ7gIZ/ozLjbgM4T88TPZQPUXxM12tkZJpzmSPakIceDncs6tEoPqlq 7g45/zqikBWk04g5ePZs5MVad6N23SiRE/6lqwmJZFsxMZnYvZekjFjIb1W1yM9BLLIC0k N54uI7JVazprU8T8fdIMLmv7Fmy11dE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-339--b_w_j7GNRGS-iWjMUXWmw-1; Tue, 10 Aug 2021 11:07:50 -0400 X-MC-Unique: -b_w_j7GNRGS-iWjMUXWmw-1 Received: by mail-wm1-f70.google.com with SMTP id b3-20020a1c80030000b02902e6a7296cb3so125860wmd.5 for ; Tue, 10 Aug 2021 08:07:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=wQrJF8t9EReP04tyvPyrDyLNtvjcyc7yjipfp4ho0w0=; b=HyBc1bVFvSAbVexLs7yE/Z4cXSA60folX5hXnH/PiBU0KouEWdCVea+W5kDSqDNgij xbMsVkAOEjBxUenf1ld0ZNeVl8scX6P4WEzDuREin6ptxw/cnm23YiBhlB9akjT5jR8S 6fD8nPXiGFht7o5C6PNHUDpp8p9mEfcqfMDCpNX9vrR1cLlCe7ld3IRsjZiHmi/fH/NT 6OHShltcVzaBWBFExg8jYKINKblnTTmUY22csYOJ7cqBeEOE81iyaRNhG6gja8OqOxB3 /lKenx75RP6JbLin6KQGMVOMzsPK76HG6iN0/iCTYJEhiccHDmHYjJNgD/NPLZ/wn1gb /efg== X-Gm-Message-State: AOAM533J9FKkrs9lehfyasdLoVCQRGqDUdhn0COcNzY9j7WT6ATvKVcM wVni+sK+PLUqegLx+rXFG8uYby/u7T37hlz+4pQZHlzPaUEUQeokk8XDXyZ0UjTz8IKCdjx8to9 kikgsDSp+ZUSSzpk= X-Received: by 2002:a05:600c:3653:: with SMTP id y19mr23198309wmq.147.1628608069179; Tue, 10 Aug 2021 08:07:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzulC4g9jUzhlZ3NRHV/KS41XkQYPK13HjBRGhAL/SGOkKA62MBCVpErOTw4053yRhLmSSD6g== X-Received: by 2002:a05:600c:3653:: with SMTP id y19mr23198266wmq.147.1628608068902; Tue, 10 Aug 2021 08:07:48 -0700 (PDT) Received: from dresden.str.redhat.com ([2a02:908:1e46:160:b272:8083:d5:bc7d]) by smtp.gmail.com with ESMTPSA id t23sm3106773wmi.32.2021.08.10.08.07.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Aug 2021 08:07:48 -0700 (PDT) Subject: Re: [PATCH v7 08/33] block/backup: set copy_range and compress after filter insertion To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org References: <20210804093813.20688-1-vsementsov@virtuozzo.com> <20210804093813.20688-9-vsementsov@virtuozzo.com> From: Hanna Reitz Message-ID: <484ee988-b198-f963-cd2f-ecd049bf29ce@redhat.com> Date: Tue, 10 Aug 2021 17:07:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210804093813.20688-9-vsementsov@virtuozzo.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=hreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.704, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, berrange@redhat.com, ehabkost@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, crosa@redhat.com, pbonzini@redhat.com, mreitz@redhat.com, eblake@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 04.08.21 11:37, Vladimir Sementsov-Ogievskiy wrote: > We are going to publish copy-before-write filter, so it would be > initialized through options. Still we don't want to publish compress > and copy-range options, as > > 1. Modern way to enable compression is to use compress filter. > > 2. For copy-range it's unclean how to make proper interface: > - it's has experimental prefix for backup job anyway > - the whole BackupPerf structure doesn't make sense for the filter > So, let's just add copy-range possibility to the filter later if > needed. > > Still, we are going to continue support for compression and > experimental copy-range in backup job. So, set these options after > filter creation. > > Note, that we can drop "compress" argument of bdrv_cbw_append() now, as > well as "perf". The only reason not doing so is that now, when I > prepare this patch the big series around it is already reviewed and I > want to avoid extra rebase conflicts to simplify review of the > following version. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/copy-before-write.h | 1 - > block/backup.c | 3 ++- > block/copy-before-write.c | 4 +--- > 3 files changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Hanna Reitz