From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AB73C4332F for ; Tue, 7 Dec 2021 06:55:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229483AbhLGG7V (ORCPT ); Tue, 7 Dec 2021 01:59:21 -0500 Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]:59773 "EHLO alexa-out-sd-02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229683AbhLGG7U (ORCPT ); Tue, 7 Dec 2021 01:59:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1638860150; x=1670396150; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=DQWaPQ+0rviNbgTffzEDspCm5f8s267jdCGIyLu/vFM=; b=PPGCuv1AYMiP2rSSQL8t+f4TwnpwIwUiaPnW4agsItFZV1a7fVnnZPuC LEuFe7GVFrrffWv6bWap7RMvJR9ZqOsbjBjsDXbF0Z2DWh91wOj5HPtCY V1vsfq76b04BPmrk3UYXDA74qUUbFE7OHZVLBEW2fZhOfWevzWM10xapM s=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-02.qualcomm.com with ESMTP; 06 Dec 2021 22:55:50 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2021 22:55:50 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Mon, 6 Dec 2021 22:55:37 -0800 Received: from blr-ubuntu-311.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Mon, 6 Dec 2021 22:55:32 -0800 From: Sai Prakash Ranjan To: Will Deacon , Catalin Marinas , Marc Zyngier , Arnd Bergmann , Steven Rostedt CC: gregkh , , , , , Sai Prakash Ranjan , Neil Armstrong , kernel test robot Subject: [PATCHv6 3/5] drm/meson: Fix overflow implicit truncation warnings Date: Tue, 7 Dec 2021 12:24:47 +0530 Message-ID: <4850d7fd105dfb46cabada697907da0c03c7f492.1638858747.git.quic_saipraka@quicinc.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Fix -Woverflow warnings for drm/meson driver which is a result of moving arm64 custom MMIO accessor macros to asm-generic function implementations giving a bonus type-checking now and uncovering these overflow warnings. drivers/gpu/drm/meson/meson_viu.c: In function ‘meson_viu_init’: drivers/gpu/drm/meson/meson_registers.h:1826:48: error: large integer implicitly truncated to unsigned type [-Werror=overflow] #define VIU_OSD_BLEND_REORDER(dest, src) ((src) << (dest * 4)) ^ drivers/gpu/drm/meson/meson_viu.c:472:18: note: in expansion of macro ‘VIU_OSD_BLEND_REORDER’ writel_relaxed(VIU_OSD_BLEND_REORDER(0, 1) | ^~~~~~~~~~~~~~~~~~~~~ Cc: Arnd Bergmann Cc: Neil Armstrong Reported-by: kernel test robot Signed-off-by: Sai Prakash Ranjan --- drivers/gpu/drm/meson/meson_viu.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_viu.c b/drivers/gpu/drm/meson/meson_viu.c index 259f3e6bec90..bb7e109534de 100644 --- a/drivers/gpu/drm/meson/meson_viu.c +++ b/drivers/gpu/drm/meson/meson_viu.c @@ -469,17 +469,17 @@ void meson_viu_init(struct meson_drm *priv) priv->io_base + _REG(VD2_IF0_LUMA_FIFO_SIZE)); if (meson_vpu_is_compatible(priv, VPU_COMPATIBLE_G12A)) { - writel_relaxed(VIU_OSD_BLEND_REORDER(0, 1) | - VIU_OSD_BLEND_REORDER(1, 0) | - VIU_OSD_BLEND_REORDER(2, 0) | - VIU_OSD_BLEND_REORDER(3, 0) | - VIU_OSD_BLEND_DIN_EN(1) | - VIU_OSD_BLEND1_DIN3_BYPASS_TO_DOUT1 | - VIU_OSD_BLEND1_DOUT_BYPASS_TO_BLEND2 | - VIU_OSD_BLEND_DIN0_BYPASS_TO_DOUT0 | - VIU_OSD_BLEND_BLEN2_PREMULT_EN(1) | - VIU_OSD_BLEND_HOLD_LINES(4), - priv->io_base + _REG(VIU_OSD_BLEND_CTRL)); + u32 val = (u32)VIU_OSD_BLEND_REORDER(0, 1) | + (u32)VIU_OSD_BLEND_REORDER(1, 0) | + (u32)VIU_OSD_BLEND_REORDER(2, 0) | + (u32)VIU_OSD_BLEND_REORDER(3, 0) | + (u32)VIU_OSD_BLEND_DIN_EN(1) | + (u32)VIU_OSD_BLEND1_DIN3_BYPASS_TO_DOUT1 | + (u32)VIU_OSD_BLEND1_DOUT_BYPASS_TO_BLEND2 | + (u32)VIU_OSD_BLEND_DIN0_BYPASS_TO_DOUT0 | + (u32)VIU_OSD_BLEND_BLEN2_PREMULT_EN(1) | + (u32)VIU_OSD_BLEND_HOLD_LINES(4); + writel_relaxed(val, priv->io_base + _REG(VIU_OSD_BLEND_CTRL)); writel_relaxed(OSD_BLEND_PATH_SEL_ENABLE, priv->io_base + _REG(OSD1_BLEND_SRC_CTRL)); -- 2.33.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 913D6C433F5 for ; Tue, 7 Dec 2021 06:57:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X9zNdLNWB9BeXfBf8UFNO9Am/HJfaXKDCQ2Hb2W+RaA=; b=K9OJNO37Sxg3NV pKvia6dam/3lWapYrRad3zMS1XVOu/8vbupPjqSYLeZ5/qxvrZGW/ubaqr54WzF8AC2jqtR1UrEJn WVMl0oias0yklDlnopvGRKGJinwtXc+8Eho5ahP9dNDP4PdBRms49py0QunRHL/J/iG+407ieOdMI kBWYjfHXB9JZu/7q94/0Qvh2ImXMlW7njbOxxnTjdwusMa4mEXOxvF/7poEZgUcMx7VDLFYxQrGmT r9CYVVcntOaAtcX2OPwhEyp+BsJLj/+toV6kEyZqdFvYBTBQk1P9A5OKjlvPvItCb+dD1o6otPyjB ZxgegCT5vW5f4wbKvyIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muUOf-0077xq-0x; Tue, 07 Dec 2021 06:56:17 +0000 Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muUOI-0077rP-68 for linux-arm-kernel@lists.infradead.org; Tue, 07 Dec 2021 06:55:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1638860154; x=1670396154; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=DQWaPQ+0rviNbgTffzEDspCm5f8s267jdCGIyLu/vFM=; b=f5TUEnp2WVfimtq78hVsscIAGvrtYcYwxPZW1clNTcackpLuX55ojgFn wOuyRTqheSc1QWoscu019PLSE3tEuZpKzlrXwE//KFu60S4SSxkrIgsKd c0XyCzoVXdTaQF030DfFy21EZrWpjOZav84xWAnoPkMVLQBbZjyWwnIvi c=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-02.qualcomm.com with ESMTP; 06 Dec 2021 22:55:50 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2021 22:55:50 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Mon, 6 Dec 2021 22:55:37 -0800 Received: from blr-ubuntu-311.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Mon, 6 Dec 2021 22:55:32 -0800 From: Sai Prakash Ranjan To: Will Deacon , Catalin Marinas , Marc Zyngier , Arnd Bergmann , Steven Rostedt CC: gregkh , , , , , Sai Prakash Ranjan , Neil Armstrong , kernel test robot Subject: [PATCHv6 3/5] drm/meson: Fix overflow implicit truncation warnings Date: Tue, 7 Dec 2021 12:24:47 +0530 Message-ID: <4850d7fd105dfb46cabada697907da0c03c7f492.1638858747.git.quic_saipraka@quicinc.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_225554_279326_77008428 X-CRM114-Status: GOOD ( 10.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rml4IC1Xb3ZlcmZsb3cgd2FybmluZ3MgZm9yIGRybS9tZXNvbiBkcml2ZXIgd2hpY2ggaXMgYSBy ZXN1bHQKb2YgbW92aW5nIGFybTY0IGN1c3RvbSBNTUlPIGFjY2Vzc29yIG1hY3JvcyB0byBhc20t Z2VuZXJpYyBmdW5jdGlvbgppbXBsZW1lbnRhdGlvbnMgZ2l2aW5nIGEgYm9udXMgdHlwZS1jaGVj a2luZyBub3cgYW5kIHVuY292ZXJpbmcgdGhlc2UKb3ZlcmZsb3cgd2FybmluZ3MuCgpkcml2ZXJz L2dwdS9kcm0vbWVzb24vbWVzb25fdml1LmM6IEluIGZ1bmN0aW9uIOKAmG1lc29uX3ZpdV9pbml0 4oCZOgpkcml2ZXJzL2dwdS9kcm0vbWVzb24vbWVzb25fcmVnaXN0ZXJzLmg6MTgyNjo0ODogZXJy b3I6IGxhcmdlIGludGVnZXIgaW1wbGljaXRseSB0cnVuY2F0ZWQgdG8gdW5zaWduZWQgdHlwZSBb LVdlcnJvcj1vdmVyZmxvd10KICNkZWZpbmUgIFZJVV9PU0RfQkxFTkRfUkVPUkRFUihkZXN0LCBz cmMpICAgICAgKChzcmMpIDw8IChkZXN0ICogNCkpCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIF4KZHJpdmVycy9ncHUvZHJtL21lc29uL21lc29uX3ZpdS5j OjQ3MjoxODogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmFZJVV9PU0RfQkxFTkRfUkVP UkRFUuKAmQogICB3cml0ZWxfcmVsYXhlZChWSVVfT1NEX0JMRU5EX1JFT1JERVIoMCwgMSkgfAog ICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn5+fn4KCkNjOiBBcm5kIEJlcmdtYW5u IDxhcm5kQGFybmRiLmRlPgpDYzogTmVpbCBBcm1zdHJvbmcgPG5hcm1zdHJvbmdAYmF5bGlicmUu Y29tPgpSZXBvcnRlZC1ieToga2VybmVsIHRlc3Qgcm9ib3QgPGxrcEBpbnRlbC5jb20+ClNpZ25l ZC1vZmYtYnk6IFNhaSBQcmFrYXNoIFJhbmphbiA8cXVpY19zYWlwcmFrYUBxdWljaW5jLmNvbT4K LS0tCiBkcml2ZXJzL2dwdS9kcm0vbWVzb24vbWVzb25fdml1LmMgfCAyMiArKysrKysrKysrKy0t LS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21lc29uL21lc29uX3ZpdS5jIGIvZHJp dmVycy9ncHUvZHJtL21lc29uL21lc29uX3ZpdS5jCmluZGV4IDI1OWYzZTZiZWM5MC4uYmI3ZTEw OTUzNGRlIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWVzb24vbWVzb25fdml1LmMKKysr IGIvZHJpdmVycy9ncHUvZHJtL21lc29uL21lc29uX3ZpdS5jCkBAIC00NjksMTcgKzQ2OSwxNyBA QCB2b2lkIG1lc29uX3ZpdV9pbml0KHN0cnVjdCBtZXNvbl9kcm0gKnByaXYpCiAJCQlwcml2LT5p b19iYXNlICsgX1JFRyhWRDJfSUYwX0xVTUFfRklGT19TSVpFKSk7CiAKIAlpZiAobWVzb25fdnB1 X2lzX2NvbXBhdGlibGUocHJpdiwgVlBVX0NPTVBBVElCTEVfRzEyQSkpIHsKLQkJd3JpdGVsX3Jl bGF4ZWQoVklVX09TRF9CTEVORF9SRU9SREVSKDAsIDEpIHwKLQkJCSAgICAgICBWSVVfT1NEX0JM RU5EX1JFT1JERVIoMSwgMCkgfAotCQkJICAgICAgIFZJVV9PU0RfQkxFTkRfUkVPUkRFUigyLCAw KSB8Ci0JCQkgICAgICAgVklVX09TRF9CTEVORF9SRU9SREVSKDMsIDApIHwKLQkJCSAgICAgICBW SVVfT1NEX0JMRU5EX0RJTl9FTigxKSB8Ci0JCQkgICAgICAgVklVX09TRF9CTEVORDFfRElOM19C WVBBU1NfVE9fRE9VVDEgfAotCQkJICAgICAgIFZJVV9PU0RfQkxFTkQxX0RPVVRfQllQQVNTX1RP X0JMRU5EMiB8Ci0JCQkgICAgICAgVklVX09TRF9CTEVORF9ESU4wX0JZUEFTU19UT19ET1VUMCB8 Ci0JCQkgICAgICAgVklVX09TRF9CTEVORF9CTEVOMl9QUkVNVUxUX0VOKDEpIHwKLQkJCSAgICAg ICBWSVVfT1NEX0JMRU5EX0hPTERfTElORVMoNCksCi0JCQkgICAgICAgcHJpdi0+aW9fYmFzZSAr IF9SRUcoVklVX09TRF9CTEVORF9DVFJMKSk7CisJCXUzMiB2YWwgPSAodTMyKVZJVV9PU0RfQkxF TkRfUkVPUkRFUigwLCAxKSB8CisJCQkgICh1MzIpVklVX09TRF9CTEVORF9SRU9SREVSKDEsIDAp IHwKKwkJCSAgKHUzMilWSVVfT1NEX0JMRU5EX1JFT1JERVIoMiwgMCkgfAorCQkJICAodTMyKVZJ VV9PU0RfQkxFTkRfUkVPUkRFUigzLCAwKSB8CisJCQkgICh1MzIpVklVX09TRF9CTEVORF9ESU5f RU4oMSkgfAorCQkJICAodTMyKVZJVV9PU0RfQkxFTkQxX0RJTjNfQllQQVNTX1RPX0RPVVQxIHwK KwkJCSAgKHUzMilWSVVfT1NEX0JMRU5EMV9ET1VUX0JZUEFTU19UT19CTEVORDIgfAorCQkJICAo dTMyKVZJVV9PU0RfQkxFTkRfRElOMF9CWVBBU1NfVE9fRE9VVDAgfAorCQkJICAodTMyKVZJVV9P U0RfQkxFTkRfQkxFTjJfUFJFTVVMVF9FTigxKSB8CisJCQkgICh1MzIpVklVX09TRF9CTEVORF9I T0xEX0xJTkVTKDQpOworCQl3cml0ZWxfcmVsYXhlZCh2YWwsIHByaXYtPmlvX2Jhc2UgKyBfUkVH KFZJVV9PU0RfQkxFTkRfQ1RSTCkpOwogCiAJCXdyaXRlbF9yZWxheGVkKE9TRF9CTEVORF9QQVRI X1NFTF9FTkFCTEUsCiAJCQkgICAgICAgcHJpdi0+aW9fYmFzZSArIF9SRUcoT1NEMV9CTEVORF9T UkNfQ1RSTCkpOwotLSAKMi4zMy4xCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=