From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0BB4C2D0EF for ; Sat, 18 Apr 2020 09:44:49 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 0D64E21D93 for ; Sat, 18 Apr 2020 09:44:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="ohiyj/bh"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="G3FSvPd0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D64E21D93 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 20AAD1E915; Sat, 18 Apr 2020 11:44:48 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 233721E8FB for ; Sat, 18 Apr 2020 11:44:47 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 787EA5807A8; Sat, 18 Apr 2020 05:44:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sat, 18 Apr 2020 05:44:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=CyjQTPGlWklbl1LlR4/Ff+Om3VkdkpYKaHYCysGcmbc=; b=ohiyj/bhbjW5 Jdh5kpQ/iyJkcrH0+Rjn48CSoesesANKNliX1UsdizHSTo70TE2zYhQbJ4J2z1tM D2HhqhrhZdDZD+DljGytrHkaduqsb0ZbIIOi7+gIMPNHwqtRyCbHxt8OmvfGxHPN aO8G5DZNuUf3qqDdP+2JH5trJVFoIF4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=CyjQTPGlWklbl1LlR4/Ff+Om3VkdkpYKaHYCysGcm bc=; b=G3FSvPd03U5ELvrMxxptTpj34FYahX9kYk9dSc9gbsMTpGWi2gj3WoeVQ 6TxSHHAYIjxSrmLzyLytbkGTzXyQ551WyfBpi8l2a7Y6bh+wSwZHChzS+GYTMqMW +YvEkepd+AidsP3jatmJoX1MUklEtYNMIJm6iRGxvlysdJc05roHUVIzfKUBv0dE nmysOrzO+SqSlsNqau23u6BY/sCB/SF/IcMAot1B3wSupT97YDPETjkhuPuVIRkG 6wmauSm7aUF6WLequ78SxNSm0tlvwAjoJlSHuE2wyTUTOTx5nsXJJmcCGa+0fIhU 6hI/x4SVdKgV3ploJrJ6PZnXDmthw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrfeelgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D4209306005C; Sat, 18 Apr 2020 05:44:44 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , Ori Kam , Matan Azrad , "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" , "john.mcnamara@intel.com" , "marko.kovacevic@intel.com" , "arybchenko@solarflare.com" , Bill Zhou Cc: "dev@dpdk.org" Date: Sat, 18 Apr 2020 11:44:43 +0200 Message-ID: <4860948.CpGBqz00pN@thomas> In-Reply-To: References: <20200410094631.31330-1-dongz@mellanox.com> <192e2e54-17fe-5444-1917-3982837f6e5c@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: support flow aging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/04/2020 07:04, Bill Zhou: > From: Ferruh Yigit > > On 4/14/2020 9:32 AM, Dong Zhou wrote: > > > --- a/lib/librte_ethdev/rte_ethdev.h > > > +++ b/lib/librte_ethdev/rte_ethdev.h > > > @@ -3015,6 +3015,7 @@ enum rte_eth_event_type { > > > RTE_ETH_EVENT_NEW, /**< port is probed */ > > > RTE_ETH_EVENT_DESTROY, /**< port is released */ > > > RTE_ETH_EVENT_IPSEC, /**< IPsec offload related event */ > > > + RTE_ETH_EVENT_FLOW_AGED,/**< New aged-out flows is detected > > */ > > > RTE_ETH_EVENT_MAX /**< max value of this enum */ > > > }; > > > > > > Just recognized that this is failing in ABI check [1], as far as last time for a > > similar enum warning a QAT patch has been dropped, should this need to > > wait for > > 20.11 too? > > This patch is commonly used for flow aging, there are 2 other patches have > implement flow aging in mlx5 driver reply to this patch. > In our schedule, this feature is merged in 20.05 for some customers. Can it > be fixed? These MAX values in enums are a pain. We can try to think what can be done, waiting 20.11. Not sure there is a solution, except hijacking an existing value not used in the PMD, waiting the definitive value in 20.11...