From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 647EBC43334 for ; Fri, 17 Jun 2022 14:06:29 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85E66410E7; Fri, 17 Jun 2022 16:06:28 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 337A940F19 for ; Fri, 17 Jun 2022 16:06:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655474785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=94u3yZir/105MsjM4tFXXXTLAoGA30eZN3jpPl9aYnU=; b=HAGDukD2iiMBZLCz/bEYBy/THDsV1BRSoeSfNt8sl46KQxeFtZ7uN/Y/NdNUEy4FTPelAK ZEmttj6AnjdlO0eH4RSs+xwIWGgWFfTYuh+vsweWVvWFrqJZiwt4p5hBvbHJJgMl/6pd8J xXbglP7m93CcPQ9I9qsNdBd+fJCOmsQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-169-Z6Yetoi5NRiEwiDWcmKACw-1; Fri, 17 Jun 2022 10:06:22 -0400 X-MC-Unique: Z6Yetoi5NRiEwiDWcmKACw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E3AC8802804; Fri, 17 Jun 2022 14:06:21 +0000 (UTC) Received: from [10.39.208.34] (unknown [10.39.208.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 74F362166B26; Fri, 17 Jun 2022 14:06:20 +0000 (UTC) Message-ID: <4867138f-8520-ff15-ac55-ec59d29e2786@redhat.com> Date: Fri, 17 Jun 2022 16:06:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 0/6] Vhost checksum offload improvements To: dev@dpdk.org, jasowang@redhat.com, chenbo.xia@intel.com, david.marchand@redhat.com, olivier.matz@6wind.com, wenwux.ma@intel.com, yuying.zhang@intel.com, aman.deep.singh@intel.com References: <20220608124946.102623-1-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: <20220608124946.102623-1-maxime.coquelin@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/8/22 14:49, Maxime Coquelin wrote: > This series aims at improving Vhost checksum offloading > support. > > The first patch reverts overwritting MAC address in > testpmd CSUM forward mode. This is required to be able to > test checksum offloading with real traffic. MAC forwarding > mode should be used if the MAC addresses need to be > changed. > > Second patch is a Vhost library fix to be compliant with > the Virtio specification, which requires that the > pseudo-header checksum is being set by the device when > offloading the checksum to the guest. > > Third patch enables the compliant offloading mode of Vhost > library in Vhost PMD by default, since the legacy mode > violates the mbuf API by setting Tx flags in the receive > path. A new devarg is introduced for application willing > to use the legacy mode. > > Fourth patch is just a small cleanup to represent a boolean > value as a boolean. > > The two last patches introduces compatibility layers > that performs checksum in SW when the ethdev and Virtio > features are not aligned. > > Note that the two last patches are not tagged as fixes > because they rely on the new compliant offload mode of > Vhost library, and so would casue an ABI breakage if > backported. > > With this series, it is now possible to perform IO > forwarding between a vhost-user port and a Vitio-user > with kernel backend port even if the guest has negotiated > VIRTIO_NET_F_CSUM. > > With csum forward mode, it now works whathever the > offloading configuration set either on Virtio or Ethdev > sides. > > Changes in v2: > ============== > - Add the new devarg to validation array (Wenwu) > - Fix typos in commit messages (Chenbo, checkpatch, Yuying) > > Maxime Coquelin (6): > Revert "app/testpmd: modify mac in csum forwarding" > vhost: fix missing enqueue pseudo-header calculation > net/vhost: enable compliant offloading mode > net/vhost: make VLAN stripping flag a boolean > net/vhost: perform SW checksum in Rx path > net/vhost: perform SW checksum in Tx path > > app/test-pmd/csumonly.c | 4 - > doc/guides/nics/features/vhost.ini | 1 + > doc/guides/nics/vhost.rst | 6 ++ > drivers/net/vhost/rte_eth_vhost.c | 167 ++++++++++++++++++++++++++++- > lib/vhost/virtio_net.c | 10 ++ > 5 files changed, 180 insertions(+), 8 deletions(-) > Applied to dpdk-next-virtio/main. Thanks, Maxime