From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Qais Yousef <qyousef@layalina.io>,
Vincent Guittot <vincent.guittot@linaro.org>
Cc: Kajetan Puchalski <kajetan.puchalski@arm.com>,
mingo@kernel.org, peterz@infradead.org, rafael@kernel.org,
viresh.kumar@linaro.org, vschneid@redhat.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
lukasz.luba@arm.com, wvw@google.com, xuewen.yan94@gmail.com,
han.lin@mediatek.com, Jonathan.JMChen@mediatek.com
Subject: Re: [PATCH v2] sched/fair: unlink misfit task from cpu overutilized
Date: Mon, 16 Jan 2023 09:21:20 +0000 [thread overview]
Message-ID: <487f0252-c697-eb62-989d-57ee731691a2@arm.com> (raw)
In-Reply-To: <20230114211854.nmvmhtd5yz5wgh2a@airbuntu>
On 14/01/2023 22:18, Qais Yousef wrote:
> On 01/13/23 15:28, Vincent Guittot wrote:
>> Hi Kajetan,
>>
>> On Fri, 13 Jan 2023 at 14:50, Kajetan Puchalski
>> <kajetan.puchalski@arm.com> wrote:
[...]
>>> sched/uclamp: Fix a uninitialized variable warnings
>>> (baseline_ufc) sched/fair: Check if prev_cpu has highest spare cap in feec()
>>> sched/uclamp: Cater for uclamp in find_energy_efficient_cpu()'s early exit condition
>>> sched/uclamp: Make cpu_overutilized() use util_fits_cpu()
>>> sched/uclamp: Make asym_fits_capacity() use util_fits_cpu()
>>> sched/uclamp: Make select_idle_capacity() use util_fits_cpu()
>>> sched/uclamp: Fix fits_capacity() check in feec()
>>> sched/uclamp: Make task_fits_capacity() use util_fits_cpu()
>>> sched/uclamp: Fix relationship between uclamp and migration margin
>>> (previous 'baseline' was here)
>>>
>>> I omitted the 3 patches relating directly to capacity_inversion but in
>
> This could lead to confusion. Was there a specific reason for this omission?
> Did you hit some problem?
I thought Vincent's 'split MF from CPU OU' should replace 'CapInv'?
https://lkml.kernel.org/r/20221209164739.GA24368@vingu-book
... I have reverted patches:
Revert "sched/fair: Detect capacity inversion"
Revert "sched/fair: Consider capacity inversion in util_fits_cpu()"
Revert "sched/uclamp: Make cpu_overutilized() use util_fits_cpu()" ...
You also mentioned this in
https://lkml.kernel.org/r/<20230115001906.v7uq4ddodrbvye7d@airbuntu
[...]
next prev parent reply other threads:[~2023-01-16 9:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 16:54 [PATCH v2] sched/fair: unlink misfit task from cpu overutilized Vincent Guittot
2023-01-12 14:26 ` Qais Yousef
2023-01-13 8:53 ` Vincent Guittot
2023-01-14 18:21 ` Qais Yousef
2023-01-13 13:49 ` Kajetan Puchalski
2023-01-13 14:28 ` Vincent Guittot
2023-01-13 14:50 ` Kajetan Puchalski
2023-01-14 21:18 ` Qais Yousef
2023-01-16 9:21 ` Dietmar Eggemann [this message]
2023-01-16 11:25 ` Vincent Guittot
2023-01-17 16:40 ` Qais Yousef
2023-01-20 16:08 ` Kajetan Puchalski
2022-12-29 5:40 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487f0252-c697-eb62-989d-57ee731691a2@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=Jonathan.JMChen@mediatek.com \
--cc=han.lin@mediatek.com \
--cc=kajetan.puchalski@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=qyousef@layalina.io \
--cc=rafael@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vschneid@redhat.com \
--cc=wvw@google.com \
--cc=xuewen.yan94@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.