From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Date: Wed, 16 Jan 2019 16:26:16 +0000 Subject: [U-Boot] [PATCH] ARC: Move ENV_SIZE and ENV_OFFSET to Kconfig In-Reply-To: <20190116162456.GV27429@bill-the-cat> References: <20190116161115.21136-1-abrodkin@synopsys.com> <20190116161833.GU27429@bill-the-cat> <4881796E12491D4BB15146FE0209CE64681C7C84@DE02WEMBXB.internal.synopsys.com> <20190116162456.GV27429@bill-the-cat> Message-ID: <4881796E12491D4BB15146FE0209CE64681C7CAB@DE02WEMBXB.internal.synopsys.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, > -----Original Message----- > From: Tom Rini > Sent: Wednesday, January 16, 2019 7:25 PM > To: Alexey Brodkin > Cc: u-boot at lists.denx.de; uboot-snps-arc at synopsys.com; Michal Simek ; Simon > Glass > Subject: Re: [PATCH] ARC: Move ENV_SIZE and ENV_OFFSET to Kconfig > > On Wed, Jan 16, 2019 at 04:22:22PM +0000, Alexey Brodkin wrote: > > Hi Tom, > > > > > -----Original Message----- > > > From: Tom Rini > > > Sent: Wednesday, January 16, 2019 7:19 PM > > > To: Alexey Brodkin > > > Cc: u-boot at lists.denx.de; uboot-snps-arc at synopsys.com; Michal Simek ; > Simon > > > Glass > > > Subject: Re: [PATCH] ARC: Move ENV_SIZE and ENV_OFFSET to Kconfig > > > > > > On Wed, Jan 16, 2019 at 07:11:15PM +0300, Alexey Brodkin wrote: > > > > > > > Join the party of some ARM boards and drop more > > > > items from include/configs/xxx.h. > > > > > > > > Signed-off-by: Alexey Brodkin > > > > Cc: Michal Simek > > > > Cc: Simon Glass > > > > Cc: Tom Rini > > > > --- > > > > [snip] > > > > > > config ENV_OFFSET > > > > hex "Environment Offset" > > > > @@ -441,6 +441,7 @@ config ENV_OFFSET > > > > default 0x88000 if ARCH_SUNXI > > > > default 0xE0000 if ARCH_ZYNQ > > > > default 0x1E00000 if ARCH_ZYNQMP > > > > + default 0 > > > > > > Please make this "if ARC", thanks! > > > > Actually I don't like having here listed all the boards > > because with more boards/arches moving ENV settings to Kconfig > > we'll get here all of them listed at some point. > > Why default ENV_OFFSET [as well as] ENV_SIZE are not set in > > arch/soc/board top-level Kconfig? > > I believe the answer is that having config FOO prompt in one place and N > config FOO values results in lots of churn in the defconfig files when > they get re-synced. So yes, having N lines of default X if Y with the > prompt is what we want, at least until everything is converted and then > we can see if no, really, moving the defaults to some defined / > consistent locations doesn't result in so much churn. Ok that's fine by me. Sending a re-spin. -Alexey