From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v3,7/7] dmaengine: Add Synopsys eDMA IP test and sample driver From: Gustavo Pimentel Message-Id: <488fda69-6e92-00ae-a5f2-2fe099a0ac8f@synopsys.com> Date: Wed, 16 Jan 2019 11:56:20 +0000 To: Jose Abreu , Gustavo Pimentel , "linux-pci@vger.kernel.org" , "dmaengine@vger.kernel.org" Cc: Vinod Koul , Dan Williams , Eugeniy Paltsev , Andy Shevchenko , Russell King , Niklas Cassel , Joao Pinto , Luis de Oliveira , Vitor Soares , Nelson Costa , Pedro Sousa List-ID: SGkgSm9zZSwKCk9uIDE2LzAxLzIwMTkgMTA6NDUsIEpvc2UgQWJyZXUgd3JvdGU6Cj4gSGkgR3Vz dGF2bywKPiAKPiBPbiAxLzExLzIwMTkgNjozMyBQTSwgR3VzdGF2byBQaW1lbnRlbCB3cm90ZToK Pj4gQWRkIFN5bm9wc3lzIGVETUEgSVAgdGVzdCBhbmQgc2FtcGxlIGRyaXZlciB0byBiZSB1c2Ug Zm9yIHRlc3RpbmcKPj4gcHVycG9zZXMgYW5kIGFsc28gYXMgYSByZWZlcmVuY2UgZm9yIGFueSBk ZXZlbG9wZXIgd2hvIG5lZWRzIHRvCj4+IGltcGxlbWVudCBhbmQgdXNlIFN5bm9wc3lzIGVETUEu Cj4+Cj4+IFRoaXMgZHJpdmVyIGNhbiBiZSBjb21waWxlIGFzIGJ1aWx0LWluIG9yIGV4dGVybmFs IG1vZHVsZSBpbiBrZXJuZWwuCj4+Cj4+IFRvIGVuYWJsZSB0aGlzIGRyaXZlciBqdXN0IHNlbGVj dCBEV19FRE1BX1RFU1Qgb3B0aW9uIGluIGtlcm5lbAo+PiBjb25maWd1cmF0aW9uLCBob3dldmVy IGl0IHJlcXVpcmVzIGFuZCBzZWxlY3RzIGF1dG9tYXRpY2FsbHkgRFdfRURNQQo+PiBvcHRpb24g dG9vLgo+Pgo+PiBDaGFuZ2VzOgo+PiBSRkMgdjEtPlJGQyB2MjoKPj4gIC0gTm8gY2hhbmdlcwo+ PiBSRkMgdjItPlJGQyB2MzoKPj4gIC0gQWRkIHRlc3QgbW9kdWxlCj4+Cj4+IFNpZ25lZC1vZmYt Ynk6IEd1c3Rhdm8gUGltZW50ZWwgPGd1c3Rhdm8ucGltZW50ZWxAc3lub3BzeXMuY29tPgo+PiBD YzogVmlub2QgS291bCA8dmtvdWxAa2VybmVsLm9yZz4KPj4gQ2M6IERhbiBXaWxsaWFtcyA8ZGFu Lmoud2lsbGlhbXNAaW50ZWwuY29tPgo+PiBDYzogRXVnZW5peSBQYWx0c2V2IDxwYWx0c2V2QHN5 bm9wc3lzLmNvbT4KPj4gQ2M6IEFuZHkgU2hldmNoZW5rbyA8YW5kcml5LnNoZXZjaGVua29AbGlu dXguaW50ZWwuY29tPgo+PiBDYzogUnVzc2VsbCBLaW5nIDxybWsra2VybmVsQGFybWxpbnV4Lm9y Zy51az4KPj4gQ2M6IE5pa2xhcyBDYXNzZWwgPG5pa2xhcy5jYXNzZWxAbGluYXJvLm9yZz4KPj4g Q2M6IEpvYW8gUGludG8gPGpwaW50b0BzeW5vcHN5cy5jb20+Cj4+IENjOiBKb3NlIEFicmV1IDxq b3NlLmFicmV1QHN5bm9wc3lzLmNvbT4KPj4gQ2M6IEx1aXMgT2xpdmVpcmEgPGxvbGl2ZWlAc3lu b3BzeXMuY29tPgo+PiBDYzogVml0b3IgU29hcmVzIDx2aXRvci5zb2FyZXNAc3lub3BzeXMuY29t Pgo+PiBDYzogTmVsc29uIENvc3RhIDxuZWxzb24uY29zdGFAc3lub3BzeXMuY29tPgo+PiBDYzog UGVkcm8gU291c2EgPHBlZHJvbS5zb3VzYUBzeW5vcHN5cy5jb20+Cj4gCj4+ICtzdGF0aWMgaW50 IGR3X2VkbWFfdGVzdF9hZGRfY2hhbm5lbChzdHJ1Y3QgZHdfZWRtYV90ZXN0X2luZm8gKmluZm8s Cj4+ICsJCQkJICAgIHN0cnVjdCBkbWFfY2hhbiAqY2hhbiwKPj4gKwkJCQkgICAgdTMyIGNoYW5u ZWwpCj4+ICt7Cj4+ICsJc3RydWN0IGR3X2VkbWFfdGVzdF9wYXJhbXMgKnBhcmFtcyA9ICZpbmZv LT5wYXJhbXM7Cj4+ICsJc3RydWN0IGR3X2VkbWFfdGVzdF90aHJlYWQgKnRocmVhZDsKPj4gKwlz dHJ1Y3QgZHdfZWRtYV90ZXN0X2NoYW4gKnRjaGFuOwo+PiArCj4+ICsJdGNoYW4gPSBrdm1hbGxv YyhzaXplb2YoKnRjaGFuKSwgR0ZQX0tFUk5FTCk7Cj4+ICsJaWYgKCF0Y2hhbikKPj4gKwkJcmV0 dXJuIC1FTk9NRU07Cj4+ICsKPj4gKwl0Y2hhbi0+Y2hhbiA9IGNoYW47Cj4+ICsKPj4gKwl0aHJl YWQgPSBrdnphbGxvYyhzaXplb2YoKnRocmVhZCksIEdGUF9LRVJORUwpOwo+PiArCWlmICghdGhy ZWFkKSB7Cj4+ICsJCWt2ZnJlZSh0Y2hhbik7Cj4+ICsJCXJldHVybiAtRU5PTUVNOwo+PiArCX0K Pj4gKwo+PiArCXRocmVhZC0+aW5mbyA9IGluZm87Cj4+ICsJdGhyZWFkLT5jaGFuID0gdGNoYW4t PmNoYW47Cj4+ICsJc3dpdGNoIChjaGFubmVsKSB7Cj4+ICsJY2FzZSBFRE1BX0NIX1dSOgo+PiAr CQl0aHJlYWQtPmRpcmVjdGlvbiA9IERNQV9ERVZfVE9fTUVNOwo+PiArCQlicmVhazsKPj4gKwlj YXNlIEVETUFfQ0hfUkQ6Cj4+ICsJCXRocmVhZC0+ZGlyZWN0aW9uID0gRE1BX01FTV9UT19ERVY7 Cj4+ICsJCWJyZWFrOwo+PiArCWRlZmF1bHQ6Cj4+ICsJCWt2ZnJlZSh0Y2hhbik7Cj4gCj4gWW91 IGFyZSBsZWFraW5nIHRocmVhZCBoZXJlLgoKWWVzLCBpbmRlZWQuCgo+IAo+PiArCQlyZXR1cm4g LUVQRVJNOwo+PiArCX0KPj4gKwl0aHJlYWQtPnRlc3RfZG9uZS53YWl0ID0gJnRocmVhZC0+ZG9u ZV93YWl0Owo+PiArCWluaXRfd2FpdHF1ZXVlX2hlYWQoJnRocmVhZC0+ZG9uZV93YWl0KTsKPj4g Kwo+PiArCWlmICghcGFyYW1zLT5yZXBldGl0aW9ucykKPj4gKwkJdGhyZWFkLT50YXNrID0ga3Ro cmVhZF9jcmVhdGUoZHdfZWRtYV90ZXN0X3NnLCB0aHJlYWQsICIlcyIsCj4+ICsJCQkJCSAgICAg IGRtYV9jaGFuX25hbWUoY2hhbikpOwo+PiArCWVsc2UKPj4gKwkJdGhyZWFkLT50YXNrID0ga3Ro cmVhZF9jcmVhdGUoZHdfZWRtYV90ZXN0X2N5Y2xpYywgdGhyZWFkLCAiJXMiLAo+PiArCQkJCQkg ICAgICBkbWFfY2hhbl9uYW1lKGNoYW4pKTsKPj4gKwo+PiArCWlmIChJU19FUlIodGhyZWFkLT50 YXNrKSkgewo+PiArCQlwcl9lcnIoImZhaWxlZCB0byBjcmVhdGUgdGhyZWFkICVzXG4iLCBkbWFf Y2hhbl9uYW1lKGNoYW4pKTsKPj4gKwkJa3ZmcmVlKHRjaGFuKTsKPj4gKwkJa3ZmcmVlKHRocmVh ZCk7Cj4+ICsJCXJldHVybiAtRVBFUk07Cj4+ICsJfQo+PiArCj4+ICsJdGNoYW4tPnRocmVhZCA9 IHRocmVhZDsKPj4gKwlkZXZfZGJnKGNoYW4tPmRldmljZS0+ZGV2LCAiYWRkIHRocmVhZCAlc1xu IiwgZG1hX2NoYW5fbmFtZShjaGFuKSk7Cj4+ICsJbGlzdF9hZGRfdGFpbCgmdGNoYW4tPm5vZGUs ICZpbmZvLT5jaGFubmVscyk7Cj4+ICsKPj4gKwlyZXR1cm4gMDsKPj4gK30KPj4gKwoKVGhhbmtz IQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF3C5C43387 for ; Wed, 16 Jan 2019 12:01:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA764206C2 for ; Wed, 16 Jan 2019 12:01:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=synopsys.com header.i=@synopsys.com header.b="iG2mxDB4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390036AbfAPMBF (ORCPT ); Wed, 16 Jan 2019 07:01:05 -0500 Received: from smtprelay.synopsys.com ([198.182.47.9]:48152 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390001AbfAPMBE (ORCPT ); Wed, 16 Jan 2019 07:01:04 -0500 Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239]) by smtprelay.synopsys.com (Postfix) with ESMTP id 79B3A24E0600; Wed, 16 Jan 2019 04:01:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1547640064; bh=XhTYBVG0GNTpvdt/A6CyJAYXyqExqLZEAX3Sa7dxaFg=; h=Subject:To:CC:References:From:Date:In-Reply-To:From; b=iG2mxDB4LMgVRHryJEAmELGy+EG9JRrP8BiMf/iS3DhD5nqPAHKet0tL4LT7Bnp0t aPBznLJNgG+qxRTR/Xdz5iMnhcaArvlNMgaofjRfM4FbvLGiAweutG9KKnZ0ztoQfg vB4kQo6dMh/UHHledYJ8Ar8Hffy8OhhV+F0spvObA6dRmzkXRt8fjS8KfS6SCH1YPl 9y7GK/uQ5jxHpSkhIW7x9VWNBvamJ+tl44LNEJcGt3tJ1L57X/RYKC5rnQCteUHK3S Le5XAsS+C6qfWi//+LEZm4jn6b03JHNIhGxRHXfjTG/sUDTCQF3inv82qTW63a/w+2 4APxFRG/ibCsg== Received: from us01wehtc1.internal.synopsys.com (us01wehtc1-vip.internal.synopsys.com [10.12.239.236]) by mailhost.synopsys.com (Postfix) with ESMTP id 5FD295D5D; Wed, 16 Jan 2019 04:01:04 -0800 (PST) Received: from DE02WEHTCB.internal.synopsys.com (10.225.19.94) by us01wehtc1.internal.synopsys.com (10.12.239.235) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 16 Jan 2019 04:01:04 -0800 Received: from DE02WEHTCA.internal.synopsys.com (10.225.19.92) by DE02WEHTCB.internal.synopsys.com (10.225.19.94) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 16 Jan 2019 13:01:02 +0100 Received: from [10.107.25.131] (10.107.25.131) by DE02WEHTCA.internal.synopsys.com (10.225.19.80) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 16 Jan 2019 13:01:02 +0100 Subject: Re: [RFC v3 7/7] dmaengine: Add Synopsys eDMA IP test and sample driver To: Jose Abreu , Gustavo Pimentel , "linux-pci@vger.kernel.org" , "dmaengine@vger.kernel.org" CC: Vinod Koul , Dan Williams , Eugeniy Paltsev , Andy Shevchenko , Russell King , Niklas Cassel , Joao Pinto , Jose Abreu , Luis de Oliveira , Vitor Soares , Nelson Costa , "Pedro Sousa" References: <1876fee2-9f8c-925c-a9ab-cf69fe6693a1@synopsys.com> From: Gustavo Pimentel Message-ID: <488fda69-6e92-00ae-a5f2-2fe099a0ac8f@synopsys.com> Date: Wed, 16 Jan 2019 11:56:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <1876fee2-9f8c-925c-a9ab-cf69fe6693a1@synopsys.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.25.131] Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Jose, On 16/01/2019 10:45, Jose Abreu wrote: > Hi Gustavo, > > On 1/11/2019 6:33 PM, Gustavo Pimentel wrote: >> Add Synopsys eDMA IP test and sample driver to be use for testing >> purposes and also as a reference for any developer who needs to >> implement and use Synopsys eDMA. >> >> This driver can be compile as built-in or external module in kernel. >> >> To enable this driver just select DW_EDMA_TEST option in kernel >> configuration, however it requires and selects automatically DW_EDMA >> option too. >> >> Changes: >> RFC v1->RFC v2: >> - No changes >> RFC v2->RFC v3: >> - Add test module >> >> Signed-off-by: Gustavo Pimentel >> Cc: Vinod Koul >> Cc: Dan Williams >> Cc: Eugeniy Paltsev >> Cc: Andy Shevchenko >> Cc: Russell King >> Cc: Niklas Cassel >> Cc: Joao Pinto >> Cc: Jose Abreu >> Cc: Luis Oliveira >> Cc: Vitor Soares >> Cc: Nelson Costa >> Cc: Pedro Sousa > >> +static int dw_edma_test_add_channel(struct dw_edma_test_info *info, >> + struct dma_chan *chan, >> + u32 channel) >> +{ >> + struct dw_edma_test_params *params = &info->params; >> + struct dw_edma_test_thread *thread; >> + struct dw_edma_test_chan *tchan; >> + >> + tchan = kvmalloc(sizeof(*tchan), GFP_KERNEL); >> + if (!tchan) >> + return -ENOMEM; >> + >> + tchan->chan = chan; >> + >> + thread = kvzalloc(sizeof(*thread), GFP_KERNEL); >> + if (!thread) { >> + kvfree(tchan); >> + return -ENOMEM; >> + } >> + >> + thread->info = info; >> + thread->chan = tchan->chan; >> + switch (channel) { >> + case EDMA_CH_WR: >> + thread->direction = DMA_DEV_TO_MEM; >> + break; >> + case EDMA_CH_RD: >> + thread->direction = DMA_MEM_TO_DEV; >> + break; >> + default: >> + kvfree(tchan); > > You are leaking thread here. Yes, indeed. > >> + return -EPERM; >> + } >> + thread->test_done.wait = &thread->done_wait; >> + init_waitqueue_head(&thread->done_wait); >> + >> + if (!params->repetitions) >> + thread->task = kthread_create(dw_edma_test_sg, thread, "%s", >> + dma_chan_name(chan)); >> + else >> + thread->task = kthread_create(dw_edma_test_cyclic, thread, "%s", >> + dma_chan_name(chan)); >> + >> + if (IS_ERR(thread->task)) { >> + pr_err("failed to create thread %s\n", dma_chan_name(chan)); >> + kvfree(tchan); >> + kvfree(thread); >> + return -EPERM; >> + } >> + >> + tchan->thread = thread; >> + dev_dbg(chan->device->dev, "add thread %s\n", dma_chan_name(chan)); >> + list_add_tail(&tchan->node, &info->channels); >> + >> + return 0; >> +} >> + Thanks!