From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43444C433B4 for ; Wed, 12 May 2021 13:00:03 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 17FF3611C9 for ; Wed, 12 May 2021 13:00:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17FF3611C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01D5E4003F; Wed, 12 May 2021 15:00:01 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id AD0D14003E for ; Wed, 12 May 2021 14:59:59 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 5A4CB132E; Wed, 12 May 2021 08:59:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 12 May 2021 08:59:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 8/ypf8bqjGrIC9wSSt5gkakyzbNjftjRCDt7rGdLeeU=; b=A7Aubb0C/ZDcUiXh GMS/y3vIZrwejExOj9MK4a3d8/K97cu/JqVrfGzx7XC+bCZbRGW9g/KxdlisFmGn HEkdW/z17/BJJ8eUGeLt58fl85R1WR1Q2Ct2ZD1pGmQF17ktKzYnS+R6iOVewj5w zim9/eUjBoZIODeumfFzTOOcghfglkg0VaeU7o64txPrVcRPzz87HLbhNUe4QjUf Lu7bRTeb17iruDrk5hRVjRMyz3EV5W7NVqi9hxBZTzaIXvxWpYPnQjl0sCQriOIC u0uRfo86epnr2MX3ojpzZjS5VImcJp2MUB+d8GV5cuTZw49awhQ7TuI1O/ejdY6b 0iGupQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=8/ypf8bqjGrIC9wSSt5gkakyzbNjftjRCDt7rGdLe eU=; b=mIehhGGaWbAlPXx/2klg9zRA4X8DI6QaRTEvw+PNWEi+9NJPC0IsicbKy Hg9XicBfa/SmS73OJ4hdKAF6bI6eRUDkTp5Px9Sx9eExh+jyE2b0YNjSLoas01yv s13XhOVTt0AaReMV6OfIhGgkmYvsV0IpzwbYbf6stIMuZtAoRVQFG3z5vKkqmUrN afW3LluY6niTzKSSQ9wEpHWVtgt5qL2zufCae6LtNOS7bb5bFFuhQWIF6/PLWt/J UdumzOYTWMqHxg5Np+wI5qsJ78CJw3g9fZ31uOZ6dpGACpWdep4zuAV2LWZOOOWz rCJwSs48Fe2VZapZDbjVRIsgYEADg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdehvddgheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 May 2021 08:59:56 -0400 (EDT) From: Thomas Monjalon To: Kevin Laatz Cc: dev@dpdk.org, bruce.richardson@intel.com, david.marchand@redhat.com, Sunil Pai G Date: Wed, 12 May 2021 14:59:55 +0200 Message-ID: <4899036.3OxnyC5ACu@thomas> In-Reply-To: <20210512104746.247453-1-kevin.laatz@intel.com> References: <20210510125514.12914-1-kevin.laatz@intel.com> <20210512104746.247453-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] raw/ioat: fix parameter shadow warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/05/2021 12:47, Kevin Laatz: > In the function __idxd_completed_ops() we have a parameter shadow warning > due to a local variable having the same name as one of the function > parameters. This issue is fixed by simply renaming the local variable. > > This warning was caught when additions were made to the OVS codebase, > which include adding calls the IOAT APIs. The OVS build passes the > -Wshadow flag by default, allowing the warning to be seen when building > OVS with DPDK 21.05-rc2. > > Fixes: 245efe544d8e ("raw/ioat: report status of completed jobs") > > Reported-by: Sunil Pai G > Signed-off-by: Kevin Laatz > Tested-by: Sunil Pai G > Acked-by: Bruce Richardson Applied, thanks.