From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Sam Bobroff <sbobroff@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: fbarrat@linux.ibm.com
Subject: Re: [PATCH 1/1] powerpc/eeh: fix deadlock handling dead PHB
Date: Wed, 19 Feb 2020 23:39:52 +1100 (AEDT) [thread overview]
Message-ID: <48My3X74HJz9sSM@ozlabs.org> (raw)
In-Reply-To: <0547e82dbf90ee0729a2979a8cac5c91665c621f.1581051445.git.sbobroff@linux.ibm.com>
On Fri, 2020-02-07 at 04:57:31 UTC, Sam Bobroff wrote:
> Recovering a dead PHB can currently cause a deadlock as the PCI
> rescan/remove lock is taken twice.
>
> This is caused as part of an existing bug in
> eeh_handle_special_event(). The pe is processed while traversing the
> PHBs even though the pe is unrelated to the loop. This causes the pe
> to be, incorrectly, processed more than once.
>
> Untangling this section can move the pe processing out of the loop and
> also outside the locked section, correcting both problems.
>
> Signed-off-by: Sam Bobroff <sbobroff@linux.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/d4f194ed9eb9841a8f978710e4d24296f791a85b
cheers
prev parent reply other threads:[~2020-02-19 12:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 4:57 [PATCH 1/1] powerpc/eeh: fix deadlock handling dead PHB Sam Bobroff
2020-02-07 8:56 ` Frederic Barrat
2020-02-19 12:39 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48My3X74HJz9sSM@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=fbarrat@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sbobroff@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.