From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ou.quest-ce.net (unknown [IPv6:2001:bc8:3541:100::1]) (using TLSv1.2 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 70A7B2111B79A for ; Thu, 6 Sep 2018 00:13:21 -0700 (PDT) Message-ID: <48b8af08170fb896c12cc4e3eae7501b4fa4181d.camel@opteya.com> From: Yann Droneaud Date: Thu, 06 Sep 2018 09:12:58 +0200 In-Reply-To: References: <153616286704.23468.584491117180383924.stgit@warthog.procyon.org.uk> <20180905165552.GB25206@kroah.com> Mime-Version: 1.0 Subject: Re: [RFC] UAPI: Check headers by compiling all together as C++ List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Greg KH , David Howells Cc: moderated for non-subscribers , "Michael S. Tsirkin" , David Airlie , Jason Wang , Mat Martineau , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, Masahiro Yamada , keyrings@vger.kernel.org, Ryusuke Konishi , linux-nilfs@vger.kernel.org, linux-nvdimm@lists.01.org, codalist@coda.cs.cmu.edu, coda@cs.cmu.edu, coreteam@netfilter.org, Kent Overstreet , linux-kbuild@vger.kernel.org, linux-arm-msm@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Jaroslav Kysela , Jan Harkes , Michal Marek , linux-api@vger.kernel.org, Takashi Iwai , linux-kernel@vger.kernel.org, Rob Clark , netfilter-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, freedreno@lists.freedesktop.org List-ID: TGUgbWVyY3JlZGkgMDUgc2VwdGVtYnJlIDIwMTggw6AgMTk6MzMgKzAyMDAsIFlhbm4gRHJvbmVh dWQgYSDDqWNyaXQgOgo+IExlIG1lcmNyZWRpIDA1IHNlcHRlbWJyZSAyMDE4IMOgIDE4OjU1ICsw MjAwLCBHcmVnIEtIIGEgw6ljcml0IDoKPiA+IE9uIFdlZCwgU2VwIDA1LCAyMDE4IGF0IDA0OjU0 OjI3UE0gKzAxMDAsIERhdmlkIEhvd2VsbHMgd3JvdGU6Cj4gPiA+IAo+ID4gPiBIZXJlJ3MgYSBz ZXQgb2YgcGF0Y2hlcyB0aGF0IGluc2VydHMgYSBzdGVwIGludG8gdGhlIGJ1aWxkCj4gPiA+IHBy b2Nlc3MgdG8gbWFrZQo+ID4gPiBzdXJlIHRoYXQgdGhlIFVBUEkgaGVhZGVycyBjYW4gYWxsIGJl IGJ1aWx0IHRvZ2V0aGVyIHdpdGggQysrIChpZgo+ID4gPiB0aGUKPiA+ID4gY29tcGlsZXIgYmVp bmcgdXNlZCBzdXBwb3J0cyBDKyspLiAgQWxsIGJ1dCB0aGUgZmluYWwgcGF0Y2gKPiA+ID4gcGVy Zm9ybSBmaXh1cHMsCj4gPiA+IGluY2x1ZGluZzoKPiA+IAo+ID4gV2FpdCwgd2h5IGRvIHdlIGNh cmU/ICBXaGF0IGhhcyByZWNlbnRseSBjaGFuZ2VkIHRvIHN0YXJ0IHRvCj4gPiBkaXJlY3RseQo+ ID4gaW1wb3J0IGtlcm5lbCB1YXBpIGZpbGVzIGludG8gQysrIGNvZGU/Cj4gPiAKPiA+IEFuZCBp ZiB1c2Vyc3BhY2Ugd2FudHMgdG8gZG8gdGhpcywgY2FuJ3QgdGhleSBkbyB0aGUgQyBuYW1lc3Bh Y2UKPiA+IHRyaWNrCj4gPiB0aGVtc2VsdmVzIHdoZW4gdGhleSBkbyB0aGUgaW1wb3J0PyAgVGhh dCBtdXN0IGJlIGhvdyB0aGV5IGFyZQo+ID4gZG9pbmcgaXQKPiA+IHRvZGF5LCByaWdodD8KPiA+ IAo+IAo+IFRoZXkgY2FuJ3QuCj4gCj4gCj4gQWRkaW5nIGV4dGVybiAiQyIgeyB9IGRvZXNuJ3Qg bWFnaWNhbGx5IG1ha2UgImNsYXNzIiBhIG5vbiBrZXl3b3JkLgo+IEV2ZW4gaWYgaXQgd2FzIHRo ZSBjYXNlLCB3cml0aW5nIEMrKyBjb2RlIHVzaW5nIHdoYXRldmVyLT5jbGFzcyB3b3VsZAo+IHBy b2JhYmx5IGJyb2tlIGJlY2F1c2UgY2xhc3MgaXMgYSBrZXl3b3JkIGluIEMrKy4KPiAKCkZvciB0 aGUgcmVjb3JkLCBsaWJYMTEgaGFzIHRvIGhhbmRsZSB0aGUga2luayBwZiBpc3N1ZSB3aXRoIEMr KwprZXl3b3JkOgoKCmh0dHBzOi8vZ2l0bGFiLmZyZWVkZXNrdG9wLm9yZy94b3JnL2xpYi9saWJ4 MTEvYmxvYi83MzNmNjRiZmViMzExYzFkMDQwYjJmNzUxYmZkZWY5YzlkMGY4OWVmL2luY2x1ZGUv WDExL1hsaWIuaCNMMjI3Cgp0eXBlZGVmIHN0cnVjdCB7CglYRXh0RGF0YSAqZXh0X2RhdGE7CS8q IGhvb2sgZm9yIGV4dGVuc2lvbiB0byBoYW5nIGRhdGEgKi8KCVZpc3VhbElEIHZpc3VhbGlkOwkv KiB2aXN1YWwgaWQgb2YgdGhpcyB2aXN1YWwgKi8KI2lmIGRlZmluZWQoX19jcGx1c3BsdXMpIHx8 IGRlZmluZWQoY19wbHVzcGx1cykKCWludCBjX2NsYXNzOwkJLyogQysrIGNsYXNzIG9mIHNjcmVl biAobW9ub2Nocm9tZSwgZXRjLikgKi8KI2Vsc2UKCWludCBjbGFzczsJCS8qIGNsYXNzIG9mIHNj cmVlbiAobW9ub2Nocm9tZSwgZXRjLikgKi8KI2VuZGlmCgl1bnNpZ25lZCBsb25nIHJlZF9tYXNr LCBncmVlbl9tYXNrLCBibHVlX21hc2s7CS8qIG1hc2sgdmFsdWVzICovCglpbnQgYml0c19wZXJf cmdiOwkvKiBsb2cgYmFzZSAyIG9mIGRpc3RpbmN0IGNvbG9yIHZhbHVlcyAqLwoJaW50IG1hcF9l bnRyaWVzOwkvKiBjb2xvciBtYXAgZW50cmllcyAqLwp9IFZpc3VhbDsKCgpSZWdhcmRzLgoKLS0g Cllhbm4gRHJvbmVhdWQKT1BURVlBCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KTGludXgtbnZkaW1tIG1haWxpbmcgbGlzdApMaW51eC1udmRpbW1AbGlz dHMuMDEub3JnCmh0dHBzOi8vbGlzdHMuMDEub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbnZk aW1tCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann Droneaud Subject: Re: [RFC] UAPI: Check headers by compiling all together as C++ Date: Thu, 06 Sep 2018 09:12:58 +0200 Message-ID: <48b8af08170fb896c12cc4e3eae7501b4fa4181d.camel@opteya.com> References: <153616286704.23468.584491117180383924.stgit@warthog.procyon.org.uk> <20180905165552.GB25206@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Greg KH , David Howells Cc: moderated for non-subscribers , "Michael S. Tsirkin" , David Airlie , Jason Wang , Mat Martineau , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Masahiro Yamada , keyrings-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ryusuke Konishi , linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, codalist-/uMB558Y47wP4a1z8dhFYw@public.gmane.org, coda-ETDLCGt7PQU3uPMLIKxrzw@public.gmane.org, coreteam-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org, Kent Overstreet , linux-kbuild-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Coly Li , linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jaroslav Kysela , Jan Harkes , Michal Marek , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Takashi Iwai , linux-kernel@ List-Id: linux-arm-msm@vger.kernel.org TGUgbWVyY3JlZGkgMDUgc2VwdGVtYnJlIDIwMTggw6AgMTk6MzMgKzAyMDAsIFlhbm4gRHJvbmVh dWQgYSDDqWNyaXQgOgo+IExlIG1lcmNyZWRpIDA1IHNlcHRlbWJyZSAyMDE4IMOgIDE4OjU1ICsw MjAwLCBHcmVnIEtIIGEgw6ljcml0IDoKPiA+IE9uIFdlZCwgU2VwIDA1LCAyMDE4IGF0IDA0OjU0 OjI3UE0gKzAxMDAsIERhdmlkIEhvd2VsbHMgd3JvdGU6Cj4gPiA+IAo+ID4gPiBIZXJlJ3MgYSBz ZXQgb2YgcGF0Y2hlcyB0aGF0IGluc2VydHMgYSBzdGVwIGludG8gdGhlIGJ1aWxkCj4gPiA+IHBy b2Nlc3MgdG8gbWFrZQo+ID4gPiBzdXJlIHRoYXQgdGhlIFVBUEkgaGVhZGVycyBjYW4gYWxsIGJl IGJ1aWx0IHRvZ2V0aGVyIHdpdGggQysrIChpZgo+ID4gPiB0aGUKPiA+ID4gY29tcGlsZXIgYmVp bmcgdXNlZCBzdXBwb3J0cyBDKyspLiAgQWxsIGJ1dCB0aGUgZmluYWwgcGF0Y2gKPiA+ID4gcGVy Zm9ybSBmaXh1cHMsCj4gPiA+IGluY2x1ZGluZzoKPiA+IAo+ID4gV2FpdCwgd2h5IGRvIHdlIGNh cmU/ICBXaGF0IGhhcyByZWNlbnRseSBjaGFuZ2VkIHRvIHN0YXJ0IHRvCj4gPiBkaXJlY3RseQo+ ID4gaW1wb3J0IGtlcm5lbCB1YXBpIGZpbGVzIGludG8gQysrIGNvZGU/Cj4gPiAKPiA+IEFuZCBp ZiB1c2Vyc3BhY2Ugd2FudHMgdG8gZG8gdGhpcywgY2FuJ3QgdGhleSBkbyB0aGUgQyBuYW1lc3Bh Y2UKPiA+IHRyaWNrCj4gPiB0aGVtc2VsdmVzIHdoZW4gdGhleSBkbyB0aGUgaW1wb3J0PyAgVGhh dCBtdXN0IGJlIGhvdyB0aGV5IGFyZQo+ID4gZG9pbmcgaXQKPiA+IHRvZGF5LCByaWdodD8KPiA+ IAo+IAo+IFRoZXkgY2FuJ3QuCj4gCj4gCj4gQWRkaW5nIGV4dGVybiAiQyIgeyB9IGRvZXNuJ3Qg bWFnaWNhbGx5IG1ha2UgImNsYXNzIiBhIG5vbiBrZXl3b3JkLgo+IEV2ZW4gaWYgaXQgd2FzIHRo ZSBjYXNlLCB3cml0aW5nIEMrKyBjb2RlIHVzaW5nIHdoYXRldmVyLT5jbGFzcyB3b3VsZAo+IHBy b2JhYmx5IGJyb2tlIGJlY2F1c2UgY2xhc3MgaXMgYSBrZXl3b3JkIGluIEMrKy4KPiAKCkZvciB0 aGUgcmVjb3JkLCBsaWJYMTEgaGFzIHRvIGhhbmRsZSB0aGUga2luayBwZiBpc3N1ZSB3aXRoIEMr KwprZXl3b3JkOgoKCmh0dHBzOi8vZ2l0bGFiLmZyZWVkZXNrdG9wLm9yZy94b3JnL2xpYi9saWJ4 MTEvYmxvYi83MzNmNjRiZmViMzExYzFkMDQwYjJmNzUxYmZkZWY5YzlkMGY4OWVmL2luY2x1ZGUv WDExL1hsaWIuaCNMMjI3Cgp0eXBlZGVmIHN0cnVjdCB7CglYRXh0RGF0YSAqZXh0X2RhdGE7CS8q IGhvb2sgZm9yIGV4dGVuc2lvbiB0byBoYW5nIGRhdGEgKi8KCVZpc3VhbElEIHZpc3VhbGlkOwkv KiB2aXN1YWwgaWQgb2YgdGhpcyB2aXN1YWwgKi8KI2lmIGRlZmluZWQoX19jcGx1c3BsdXMpIHx8 IGRlZmluZWQoY19wbHVzcGx1cykKCWludCBjX2NsYXNzOwkJLyogQysrIGNsYXNzIG9mIHNjcmVl biAobW9ub2Nocm9tZSwgZXRjLikgKi8KI2Vsc2UKCWludCBjbGFzczsJCS8qIGNsYXNzIG9mIHNj cmVlbiAobW9ub2Nocm9tZSwgZXRjLikgKi8KI2VuZGlmCgl1bnNpZ25lZCBsb25nIHJlZF9tYXNr LCBncmVlbl9tYXNrLCBibHVlX21hc2s7CS8qIG1hc2sgdmFsdWVzICovCglpbnQgYml0c19wZXJf cmdiOwkvKiBsb2cgYmFzZSAyIG9mIGRpc3RpbmN0IGNvbG9yIHZhbHVlcyAqLwoJaW50IG1hcF9l bnRyaWVzOwkvKiBjb2xvciBtYXAgZW50cmllcyAqLwp9IFZpc3VhbDsKCgpSZWdhcmRzLgoKLS0g Cllhbm4gRHJvbmVhdWQKT1BURVlBCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KTGludXgtbnZkaW1tIG1haWxpbmcgbGlzdApMaW51eC1udmRpbW1AbGlz dHMuMDEub3JnCmh0dHBzOi8vbGlzdHMuMDEub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbnZk aW1tCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann Droneaud Date: Thu, 06 Sep 2018 07:12:58 +0000 Subject: Re: [RFC] UAPI: Check headers by compiling all together as C++ Message-Id: <48b8af08170fb896c12cc4e3eae7501b4fa4181d.camel@opteya.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit List-Id: References: <153616286704.23468.584491117180383924.stgit@warthog.procyon.org.uk> <20180905165552.GB25206@kroah.com> In-Reply-To: To: Greg KH , David Howells Cc: moderated for non-subscribers , "Michael S. Tsirkin" , David Airlie , Jason Wang , Mat Martineau , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Masahiro Yamada , keyrings-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ryusuke Konishi , linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, codalist-/uMB558Y47wP4a1z8dhFYw@public.gmane.org, coda-ETDLCGt7PQU3uPMLIKxrzw@public.gmane.org, coreteam-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org, Kent Overstreet , linux-kbuild-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Coly Li , linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jaroslav Kysela , Jan Harkes , Michal Marek , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Takashi Iwai Le mercredi 05 septembre 2018 à 19:33 +0200, Yann Droneaud a écrit : > Le mercredi 05 septembre 2018 à 18:55 +0200, Greg KH a écrit : > > On Wed, Sep 05, 2018 at 04:54:27PM +0100, David Howells wrote: > > > > > > Here's a set of patches that inserts a step into the build > > > process to make > > > sure that the UAPI headers can all be built together with C++ (if > > > the > > > compiler being used supports C++). All but the final patch > > > perform fixups, > > > including: > > > > Wait, why do we care? What has recently changed to start to > > directly > > import kernel uapi files into C++ code? > > > > And if userspace wants to do this, can't they do the C namespace > > trick > > themselves when they do the import? That must be how they are > > doing it > > today, right? > > > > They can't. > > > Adding extern "C" { } doesn't magically make "class" a non keyword. > Even if it was the case, writing C++ code using whatever->class would > probably broke because class is a keyword in C++. > For the record, libX11 has to handle the kink pf issue with C++ keyword: https://gitlab.freedesktop.org/xorg/lib/libx11/blob/733f64bfeb311c1d040b2f751bfdef9c9d0f89ef/include/X11/Xlib.h#L227 typedef struct { XExtData *ext_data; /* hook for extension to hang data */ VisualID visualid; /* visual id of this visual */ #if defined(__cplusplus) || defined(c_plusplus) int c_class; /* C++ class of screen (monochrome, etc.) */ #else int class; /* class of screen (monochrome, etc.) */ #endif unsigned long red_mask, green_mask, blue_mask; /* mask values */ int bits_per_rgb; /* log base 2 of distinct color values */ int map_entries; /* color map entries */ } Visual; Regards. -- Yann Droneaud OPTEYA From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2A5AC433F5 for ; Thu, 6 Sep 2018 07:13:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7674520645 for ; Thu, 6 Sep 2018 07:13:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7674520645 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=opteya.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726541AbeIFLrs (ORCPT ); Thu, 6 Sep 2018 07:47:48 -0400 Received: from ou.quest-ce.net ([195.154.187.82]:42388 "EHLO ou.quest-ce.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725851AbeIFLrr (ORCPT ); Thu, 6 Sep 2018 07:47:47 -0400 Received: from [37.170.112.156] (helo=test.quest-ce.net) by ou.quest-ce.net with esmtpsa (TLS1.1:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1fxoTT-000CKb-CG; Thu, 06 Sep 2018 09:13:08 +0200 Message-ID: <48b8af08170fb896c12cc4e3eae7501b4fa4181d.camel@opteya.com> From: Yann Droneaud To: Greg KH , David Howells Cc: linux-api@vger.kernel.org, linux-kbuild@vger.kernel.org, Michal Marek , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, keyrings@vger.kernel.org, David Airlie , linux-nilfs@vger.kernel.org, linux-nvdimm@lists.01.org, "Michael S. Tsirkin" , codalist@coda.cs.cmu.edu, coda@cs.cmu.edu, coreteam@netfilter.org, Rob Clark , linux-arm-msm@vger.kernel.org, Kent Overstreet , Dan Williams , Takashi Iwai , linux-bcache@vger.kernel.org, Coly Li , Jaroslav Kysela , Jan Harkes , Masahiro Yamada , Ryusuke Konishi , Jason Wang , Mat Martineau , netfilter-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, moderated for non-subscribers , freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Thu, 06 Sep 2018 09:12:58 +0200 In-Reply-To: References: <153616286704.23468.584491117180383924.stgit@warthog.procyon.org.uk> <20180905165552.GB25206@kroah.com> Organization: OPTEYA Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-1.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 37.170.112.156 X-SA-Exim-Mail-From: ydroneaud@opteya.com Subject: Re: [RFC] UAPI: Check headers by compiling all together as C++ X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ou.quest-ce.net) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le mercredi 05 septembre 2018 à 19:33 +0200, Yann Droneaud a écrit : > Le mercredi 05 septembre 2018 à 18:55 +0200, Greg KH a écrit : > > On Wed, Sep 05, 2018 at 04:54:27PM +0100, David Howells wrote: > > > > > > Here's a set of patches that inserts a step into the build > > > process to make > > > sure that the UAPI headers can all be built together with C++ (if > > > the > > > compiler being used supports C++). All but the final patch > > > perform fixups, > > > including: > > > > Wait, why do we care? What has recently changed to start to > > directly > > import kernel uapi files into C++ code? > > > > And if userspace wants to do this, can't they do the C namespace > > trick > > themselves when they do the import? That must be how they are > > doing it > > today, right? > > > > They can't. > > > Adding extern "C" { } doesn't magically make "class" a non keyword. > Even if it was the case, writing C++ code using whatever->class would > probably broke because class is a keyword in C++. > For the record, libX11 has to handle the kink pf issue with C++ keyword: https://gitlab.freedesktop.org/xorg/lib/libx11/blob/733f64bfeb311c1d040b2f751bfdef9c9d0f89ef/include/X11/Xlib.h#L227 typedef struct { XExtData *ext_data; /* hook for extension to hang data */ VisualID visualid; /* visual id of this visual */ #if defined(__cplusplus) || defined(c_plusplus) int c_class; /* C++ class of screen (monochrome, etc.) */ #else int class; /* class of screen (monochrome, etc.) */ #endif unsigned long red_mask, green_mask, blue_mask; /* mask values */ int bits_per_rgb; /* log base 2 of distinct color values */ int map_entries; /* color map entries */ } Visual; Regards. -- Yann Droneaud OPTEYA From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann Droneaud Subject: Re: [RFC] UAPI: Check headers by compiling all together as C++ Date: Thu, 06 Sep 2018 09:12:58 +0200 Message-ID: <48b8af08170fb896c12cc4e3eae7501b4fa4181d.camel@opteya.com> References: <153616286704.23468.584491117180383924.stgit@warthog.procyon.org.uk> <20180905165552.GB25206@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Greg KH , David Howells Cc: moderated for non-subscribers , "Michael S. Tsirkin" , David Airlie , Jason Wang , Mat Martineau , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Masahiro Yamada , keyrings-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ryusuke Konishi , linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, codalist-/uMB558Y47wP4a1z8dhFYw@public.gmane.org, coda-ETDLCGt7PQU3uPMLIKxrzw@public.gmane.org, coreteam-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org, Kent Overstreet , linux-kbuild-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Coly Li , linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jaroslav Kysela , Jan Harkes , Michal Marek , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Takashi Iwai , TGUgbWVyY3JlZGkgMDUgc2VwdGVtYnJlIDIwMTggw6AgMTk6MzMgKzAyMDAsIFlhbm4gRHJvbmVh dWQgYSDDqWNyaXQgOgo+IExlIG1lcmNyZWRpIDA1IHNlcHRlbWJyZSAyMDE4IMOgIDE4OjU1ICsw MjAwLCBHcmVnIEtIIGEgw6ljcml0IDoKPiA+IE9uIFdlZCwgU2VwIDA1LCAyMDE4IGF0IDA0OjU0 OjI3UE0gKzAxMDAsIERhdmlkIEhvd2VsbHMgd3JvdGU6Cj4gPiA+IAo+ID4gPiBIZXJlJ3MgYSBz ZXQgb2YgcGF0Y2hlcyB0aGF0IGluc2VydHMgYSBzdGVwIGludG8gdGhlIGJ1aWxkCj4gPiA+IHBy b2Nlc3MgdG8gbWFrZQo+ID4gPiBzdXJlIHRoYXQgdGhlIFVBUEkgaGVhZGVycyBjYW4gYWxsIGJl IGJ1aWx0IHRvZ2V0aGVyIHdpdGggQysrIChpZgo+ID4gPiB0aGUKPiA+ID4gY29tcGlsZXIgYmVp bmcgdXNlZCBzdXBwb3J0cyBDKyspLiAgQWxsIGJ1dCB0aGUgZmluYWwgcGF0Y2gKPiA+ID4gcGVy Zm9ybSBmaXh1cHMsCj4gPiA+IGluY2x1ZGluZzoKPiA+IAo+ID4gV2FpdCwgd2h5IGRvIHdlIGNh cmU/ICBXaGF0IGhhcyByZWNlbnRseSBjaGFuZ2VkIHRvIHN0YXJ0IHRvCj4gPiBkaXJlY3RseQo+ ID4gaW1wb3J0IGtlcm5lbCB1YXBpIGZpbGVzIGludG8gQysrIGNvZGU/Cj4gPiAKPiA+IEFuZCBp ZiB1c2Vyc3BhY2Ugd2FudHMgdG8gZG8gdGhpcywgY2FuJ3QgdGhleSBkbyB0aGUgQyBuYW1lc3Bh Y2UKPiA+IHRyaWNrCj4gPiB0aGVtc2VsdmVzIHdoZW4gdGhleSBkbyB0aGUgaW1wb3J0PyAgVGhh dCBtdXN0IGJlIGhvdyB0aGV5IGFyZQo+ID4gZG9pbmcgaXQKPiA+IHRvZGF5LCByaWdodD8KPiA+ IAo+IAo+IFRoZXkgY2FuJ3QuCj4gCj4gCj4gQWRkaW5nIGV4dGVybiAiQyIgeyB9IGRvZXNuJ3Qg bWFnaWNhbGx5IG1ha2UgImNsYXNzIiBhIG5vbiBrZXl3b3JkLgo+IEV2ZW4gaWYgaXQgd2FzIHRo ZSBjYXNlLCB3cml0aW5nIEMrKyBjb2RlIHVzaW5nIHdoYXRldmVyLT5jbGFzcyB3b3VsZAo+IHBy b2JhYmx5IGJyb2tlIGJlY2F1c2UgY2xhc3MgaXMgYSBrZXl3b3JkIGluIEMrKy4KPiAKCkZvciB0 aGUgcmVjb3JkLCBsaWJYMTEgaGFzIHRvIGhhbmRsZSB0aGUga2luayBwZiBpc3N1ZSB3aXRoIEMr KwprZXl3b3JkOgoKCmh0dHBzOi8vZ2l0bGFiLmZyZWVkZXNrdG9wLm9yZy94b3JnL2xpYi9saWJ4 MTEvYmxvYi83MzNmNjRiZmViMzExYzFkMDQwYjJmNzUxYmZkZWY5YzlkMGY4OWVmL2luY2x1ZGUv WDExL1hsaWIuaCNMMjI3Cgp0eXBlZGVmIHN0cnVjdCB7CglYRXh0RGF0YSAqZXh0X2RhdGE7CS8q IGhvb2sgZm9yIGV4dGVuc2lvbiB0byBoYW5nIGRhdGEgKi8KCVZpc3VhbElEIHZpc3VhbGlkOwkv KiB2aXN1YWwgaWQgb2YgdGhpcyB2aXN1YWwgKi8KI2lmIGRlZmluZWQoX19jcGx1c3BsdXMpIHx8 IGRlZmluZWQoY19wbHVzcGx1cykKCWludCBjX2NsYXNzOwkJLyogQysrIGNsYXNzIG9mIHNjcmVl biAobW9ub2Nocm9tZSwgZXRjLikgKi8KI2Vsc2UKCWludCBjbGFzczsJCS8qIGNsYXNzIG9mIHNj cmVlbiAobW9ub2Nocm9tZSwgZXRjLikgKi8KI2VuZGlmCgl1bnNpZ25lZCBsb25nIHJlZF9tYXNr LCBncmVlbl9tYXNrLCBibHVlX21hc2s7CS8qIG1hc2sgdmFsdWVzICovCglpbnQgYml0c19wZXJf cmdiOwkvKiBsb2cgYmFzZSAyIG9mIGRpc3RpbmN0IGNvbG9yIHZhbHVlcyAqLwoJaW50IG1hcF9l bnRyaWVzOwkvKiBjb2xvciBtYXAgZW50cmllcyAqLwp9IFZpc3VhbDsKCgpSZWdhcmRzLgoKLS0g Cllhbm4gRHJvbmVhdWQKT1BURVlBCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KTGludXgtbnZkaW1tIG1haWxpbmcgbGlzdApMaW51eC1udmRpbW1AbGlz dHMuMDEub3JnCmh0dHBzOi8vbGlzdHMuMDEub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbnZk aW1tCg==