All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: luoyonggang@gmail.com
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
	Qemu-block <qemu-block@nongnu.org>,
	Wen Congyang <wencongyang2@huawei.com>,
	Xie Changlong <xiechanglong.d@gmail.com>,
	qemu-level <qemu-devel@nongnu.org>
Subject: Re: make -i check resut for msys2
Date: Fri, 4 Sep 2020 08:03:17 +0200	[thread overview]
Message-ID: <48c60a95-c30b-433a-7955-3845074776d8@redhat.com> (raw)
In-Reply-To: <CAE2XoE_3Kjjk+tRz1y7rk94+vre2FSfmCGQVWNgjNW14vSNSdw@mail.gmail.com>

On 04/09/2020 00.53, 罗勇刚(Yonggang Luo) wrote:
> 
> 
> On Thu, Sep 3, 2020 at 10:33 PM Thomas Huth <thuth@redhat.com
> <mailto:thuth@redhat.com>> wrote:
> 
>     On 03/09/2020 11.18, 罗勇刚(Yonggang Luo) wrote:
>     [...]
>     >   TEST    check-unit: tests/test-replication.exe
>     > **
>     > ERROR:C:/work/xemu/qemu/tests/test-replication.c:136:make_temp:
>     > assertion failed: (fd >= 0)
>     > ERROR test-replication.exe - Bail out!
>     > ERROR:C:/work/xemu/qemu/tests/test-replication.c:136:make_temp:
>     > assertion failed: (fd >= 0)
> 
>     At least this one should be easy to fix: The test uses /tmp as
>     hard-coded directory for temporary files. I think it should use
>     g_get_tmp_dir() from glib to get that directory instead.
> 
>      Thomas
> 
> After fixes tmp path, how to fixes following error:
> $ tests/test-replication.exe                                            
>                                                                        
>                                                                        
>          
> # random seed: R02Sdf2e4ffc0e6fbe96624598386b538927
> 1..13
> # Start of replication tests
> # Start of primary tests
> Unexpected error in bdrv_open_inherit() at ../block.c:3456:
> Block protocol 'file' doesn't support the option 'locking' 

Not sure ... as a temporary test, try to remove the "locking=off"
strings from the test. If it then works, it might be worth discussing
with the block layer folks how to handle this test on Windows in the
best way. If it still does not work, it's maybe simply not worth the
effort to try to get this test running on Windows - and thus mark it
with CONFIG_POSIX in the Makefile / meson.build.

 Thomas



  reply	other threads:[~2020-09-04  6:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03  9:18 make -i check resut for msys2 罗勇刚(Yonggang Luo)
2020-09-03 14:33 ` Thomas Huth
2020-09-03 22:53   ` 罗勇刚(Yonggang Luo)
2020-09-04  6:03     ` Thomas Huth [this message]
2020-09-04  8:50       ` Kevin Wolf
2020-09-05  6:21         ` 罗勇刚(Yonggang Luo)
2020-09-07  9:23           ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48c60a95-c30b-433a-7955-3845074776d8@redhat.com \
    --to=thuth@redhat.com \
    --cc=berrange@redhat.com \
    --cc=luoyonggang@gmail.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wencongyang2@huawei.com \
    --cc=xiechanglong.d@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.