Re: [PATCH 04/10] wiphy: fix runtime error from bit shift

[James Prestwood <prestwoj@gmail.com>]

On Tue, 2022-07-26 at 15:57 -0500, Denis Kenzior wrote:
> Hi James,
> 
> On 7/26/22 12:09, James Prestwood wrote:
> > The compiler treated the '1' as an int type which was not big
> > enough
> > to hold a bit shift of 31:
> > 
> > runtime error: left shift of 1 by 31 places cannot be represented
> > in
> >                 type 'int'
> > 
> > Instead of doing the iftype check manually, refactor
> > wiphy_get_supported_iftypes by adding a subroutine which just
> > parses
> > out iftypes from a mask into a char** list. This removes the need
> > to
> > case each iftype into a string.
> > ---
> >   src/wiphy.c | 48 ++++++++++++++----------------------------------
> >   1 file changed, 14 insertions(+), 34 deletions(-)
> > 
> > diff --git a/src/wiphy.c b/src/wiphy.c
> > index 09b99fb2..98bd3aa4 100644
> > --- a/src/wiphy.c
> > +++ b/src/wiphy.c
> > @@ -707,17 +707,16 @@ bool wiphy_constrain_freq_set(const struct
> > wiphy *wiphy,
> >         return true;
> >   }
> >   
> > -static char **wiphy_get_supported_iftypes(struct wiphy *wiphy,
> > uint16_t mask)
> > +static char **wiphy_iftype_mask_to_str(uint16_t mask)
> 
> I'm still unsure why you introduce this? Can't you use 
> wiphy_get_supported_iftypes() as is?

Only to avoid passing the wiphy pointer to all these print functions.
Otherwise yes, the original could be used as-is.