From: avalluri <amarnath.valluri@intel.com>
To: mark.asselstine@windriver.com
Cc: "meta-virtualization@yoctoproject.org"
<meta-virtualization@yoctoproject.org>
Subject: Re: [PATCH 4/4] libvirt: Replace systemd units location to match with bitbake environment.
Date: Wed, 8 Feb 2017 16:37:31 +0200 [thread overview]
Message-ID: <48deae3a-974f-406e-4091-7476397847aa@intel.com> (raw)
In-Reply-To: <CAPuovEJs8vWHca-GW5aMj29PXXyPn3qPAmNpZ7ESRJYxqznmbA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1417 bytes --]
On 08.02.2017 16:15, Mark Asselstine wrote:
> On Wed, Feb 8, 2017 at 8:46 AM, Amarnath Valluri
> <amarnath.valluri@intel.com> wrote:
>> Signed-off-by: Amarnath Valluri<amarnath.valluri@intel.com>
>> ---
>> recipes-extended/libvirt/libvirt_1.3.5.bb | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/recipes-extended/libvirt/libvirt_1.3.5.bb b/recipes-extended/libvirt/libvirt_1.3.5.bb
>> index c848c99..206f59f 100644
>> --- a/recipes-extended/libvirt/libvirt_1.3.5.bb
>> +++ b/recipes-extended/libvirt/libvirt_1.3.5.bb
>> @@ -213,6 +213,12 @@ PACKAGECONFIG[wireshark] = "--with-wireshark-dissector,--without-wireshark-disse
>> # Enable the Python tool support
>> require libvirt-python.inc
>>
>> +do_configure_prepend() {
>> + systemd_system_unitdir="${@d.getVar('systemd_system_unitdir')}"
>> + sed -i -e "s;^SYSTEMD_UNIT_DIR =.*;SYSTEMD_UNIT_DIR = $systemd_system_unitdir;" \
>> + ${S}/daemon/Makefile.am ${S}/src/Makefile.am ${S}/tools/Makefile.am
> The others patches look fine but for this one is there no way to pass
> the value to make? I almost prefer to have this taken care of via a
> patch to the source instead of sed expressions here.
Its value is hard coded in Makefile.am, one thing we can do is to patch
the configure.ac to make systemd unit dir configurable from outside. I
can send the V2 with this change.
-Amarnath
[-- Attachment #2: Type: text/html, Size: 2266 bytes --]
next prev parent reply other threads:[~2017-02-08 14:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 13:46 [PATCH 1/4] containerd: Replace /lib/systemd/system with ${systemd_system_unitdir} Amarnath Valluri
2017-02-08 13:46 ` [PATCH 2/4] docker: Replace /usr/share with ${datadir} Amarnath Valluri
2017-02-08 13:46 ` [PATCH 3/4] lxc: Make use of bitbake variables where appropriate Amarnath Valluri
2017-02-08 13:46 ` [PATCH 4/4] libvirt: Replace systemd units location to match with bitbake environment Amarnath Valluri
2017-02-08 14:15 ` Mark Asselstine
2017-02-08 14:37 ` avalluri [this message]
2017-02-08 14:38 ` Mark Asselstine
2017-02-09 14:16 ` [PATCH 1/4] containerd: Replace /lib/systemd/system with ${systemd_system_unitdir} Bruce Ashfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48deae3a-974f-406e-4091-7476397847aa@intel.com \
--to=amarnath.valluri@intel.com \
--cc=mark.asselstine@windriver.com \
--cc=meta-virtualization@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.