From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935128AbeEWXvT (ORCPT ); Wed, 23 May 2018 19:51:19 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:32890 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934981AbeEWXvR (ORCPT ); Wed, 23 May 2018 19:51:17 -0400 X-Google-Smtp-Source: AB8JxZqTkd6LXPwWJnu0DALP226/KM/FcNFkGO1FT7hxjD4H0HFfywxVEwTwjmzJJjm5wS/cGDWnxg== Subject: Re: [PATCH v2 2/6] Documentation: DT: Add optional 'timeout-sec' property for sp805 To: Guenter Roeck Cc: Wim Van Sebroeck , Rob Herring , Mark Rutland , Frank Rowand , Catalin Marinas , Will Deacon , Robin Murphy , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com References: <1527107527-8093-1-git-send-email-ray.jui@broadcom.com> <1527107527-8093-3-git-send-email-ray.jui@broadcom.com> <20180523222915.GA16779@roeck-us.net> From: Ray Jui Message-ID: <48dfe138-7bf5-3f91-0108-5b0ce3811ab7@broadcom.com> Date: Wed, 23 May 2018 16:51:12 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180523222915.GA16779@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/23/2018 3:29 PM, Guenter Roeck wrote: > On Wed, May 23, 2018 at 01:32:03PM -0700, Ray Jui wrote: >> Update the SP805 binding document to add optional 'timeout-sec' >> devicetree property >> >> Signed-off-by: Ray Jui >> Reviewed-by: Scott Branden >> Reviewed-by: Guenter Roeck >> --- >> Documentation/devicetree/bindings/watchdog/arm,sp805.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/watchdog/arm,sp805.txt b/Documentation/devicetree/bindings/watchdog/arm,sp805.txt >> index de93a4d..9cd7470 100644 >> --- a/Documentation/devicetree/bindings/watchdog/arm,sp805.txt >> +++ b/Documentation/devicetree/bindings/watchdog/arm,sp805.txt >> @@ -18,6 +18,8 @@ Required properties: >> >> Optional properties: >> - interrupts : Should specify WDT interrupt number. >> +timeout-sec : Should specify default WDT timeout in seconds. If unset, the >> + default timeout in the driver is 30 seconds > > That looks odd, with the changed indentation and the missing '-' > in front of 'timeout-sec' > My bad. Will fix this in v3. Thanks. > Guenter > From mboxrd@z Thu Jan 1 00:00:00 1970 From: ray.jui@broadcom.com (Ray Jui) Date: Wed, 23 May 2018 16:51:12 -0700 Subject: [PATCH v2 2/6] Documentation: DT: Add optional 'timeout-sec' property for sp805 In-Reply-To: <20180523222915.GA16779@roeck-us.net> References: <1527107527-8093-1-git-send-email-ray.jui@broadcom.com> <1527107527-8093-3-git-send-email-ray.jui@broadcom.com> <20180523222915.GA16779@roeck-us.net> Message-ID: <48dfe138-7bf5-3f91-0108-5b0ce3811ab7@broadcom.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 5/23/2018 3:29 PM, Guenter Roeck wrote: > On Wed, May 23, 2018 at 01:32:03PM -0700, Ray Jui wrote: >> Update the SP805 binding document to add optional 'timeout-sec' >> devicetree property >> >> Signed-off-by: Ray Jui >> Reviewed-by: Scott Branden >> Reviewed-by: Guenter Roeck >> --- >> Documentation/devicetree/bindings/watchdog/arm,sp805.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/watchdog/arm,sp805.txt b/Documentation/devicetree/bindings/watchdog/arm,sp805.txt >> index de93a4d..9cd7470 100644 >> --- a/Documentation/devicetree/bindings/watchdog/arm,sp805.txt >> +++ b/Documentation/devicetree/bindings/watchdog/arm,sp805.txt >> @@ -18,6 +18,8 @@ Required properties: >> >> Optional properties: >> - interrupts : Should specify WDT interrupt number. >> +timeout-sec : Should specify default WDT timeout in seconds. If unset, the >> + default timeout in the driver is 30 seconds > > That looks odd, with the changed indentation and the missing '-' > in front of 'timeout-sec' > My bad. Will fix this in v3. Thanks. > Guenter >