From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75EA2C433DF for ; Mon, 1 Jun 2020 18:33:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47D852074B for ; Mon, 1 Jun 2020 18:33:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DSZqvOLG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MClL+BXh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47D852074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W3Bgd0P6rc27QY3th5JK5K5NQvgnRmeHJxTILSW+dyE=; b=DSZqvOLGY2wSyI IWv/qzZF5XXm10GC9n+QaezBF/4IylO0OXibnAgnANkBxWLwP1a9ur0A6q7F0tM9wRgmenSE/C+rt 11AkW8DbMPYIZ6b3DBEzhtISPxFzeMPRpS7nTPkXwrniwUdiIRCEtD12P+RhxUHrULPQlcmLmJwdd RL6rsKmVKb8iCL0T6dCsPFOee7O/lOhquh4AWM/z3ubDHk4DGSjoFg0M+t9SGSOOMA/QrrOref7re Gp54ZR9CvnG+o4KthLgdoAOrbX1bvgnIFny+u9YKYlURrk/huEYkGHA6I0Dcz0oKsy7rlQ9sQtows QW1x4yTWjb4+iTWMUMqw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jfpFA-0005sX-29; Mon, 01 Jun 2020 18:33:04 +0000 Received: from mail-qv1-xf44.google.com ([2607:f8b0:4864:20::f44]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jfpF7-0005sC-VR for linux-snps-arc@lists.infradead.org; Mon, 01 Jun 2020 18:33:03 +0000 Received: by mail-qv1-xf44.google.com with SMTP id y9so511104qvs.4 for ; Mon, 01 Jun 2020 11:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sjBuPnPDPWJQ0Kb9xGy57pRa9Ly5c+AUH3macAbvczA=; b=MClL+BXhXqB8jjkN6WKSv8YLcCjZKJYNif48UH0k+qVCOtAG+ESKJBBP9KhH6lcSFd 0C3gXJ9Z2jX4PnZgXsYgKT7ta1DY//N1kHLdH6tzjIaD43SzmPG9fcY4kSU3Jkqd5kv2 unqetaIV+8eDPlQJExerZKa2F37kRdpMK47FsBknnMwViGn88rCgTzVH08o8OZvQZdzI xQqDBTQ+O88CY53+G0uCq3S0ei0ur8C1XoRFw1fyiAgB59SxafNZxIjaCYnFGqqa8sG/ RJLxIImZpadpQHI2IHtr9ahesbbkv+QW4Xn4hcfik76NJevsmdBTm/cigEtKNe0hQdcR ecQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=sjBuPnPDPWJQ0Kb9xGy57pRa9Ly5c+AUH3macAbvczA=; b=MpPvw65d+KILMmc5IbW1WiKBWQS2e2aqFLRZkKvVXF5eRYZINsc6WLwvIV/11kMUl4 kvPyL2zAk4dlpJpsCb+LsBYWPBOsZh/cZHIqxSd+Oqdry4wd08fPZCNIKuaSy5swQ8SL e1hHQsxMuLhDcXKsUKM2CVDvtg+zhbaFn+Lp1qaKmirVFiDk8hgQWfL5G8tZ+79AyIr+ etmcqA7Glg7nJS2QAQV3LqrTHTYMHpPBkdPXSdhThSVstqYLEQDfzJYYaRR5SpSeoBg/ +CY+9WCXkG1L+kDbT/N8JTxTf8Wace0dlGNUTcM2N8o26MAejZBb5p27wt+kyMYtFIZB x6+Q== X-Gm-Message-State: AOAM532/KKNZr8bEKXeosYF6fqcrV4T345lGuUUoSqntZwwFFNwK4e8D 9tqaX8qhT78+j3+vz1kDMiY16SKNEE4= X-Google-Smtp-Source: ABdhPJydxMuHFjFaQ1T0FAYl0VFJa9Hq+T+3p/s+GEsDpfRN6ZD06IqWxenNlhUYddUUN6ppPvDXpg== X-Received: by 2002:a0c:f944:: with SMTP id i4mr20885227qvo.230.1591036380364; Mon, 01 Jun 2020 11:33:00 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id j3sm41867qkf.9.2020.06.01.11.32.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jun 2020 11:33:00 -0700 (PDT) Subject: Re: [PATCH 2/5] iee754: prvoide gcc builtins based generic sqrt functions To: Vineet Gupta , "libc-alpha@sourceware.org" References: <20200530020047.5490-1-vgupta@synopsys.com> <20200530020047.5490-3-vgupta@synopsys.com> <1f8c98ba-481c-1463-29ff-c0dec7add324@linaro.org> <45540801-e568-54ef-ad29-c3c2130eddb5@linaro.org> <6dc09d6c-e957-eeb5-34e7-089d3d608cd8@synopsys.com> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: <48e1cf71-fb16-da08-d94f-6a2281c84039@linaro.org> Date: Mon, 1 Jun 2020 15:32:57 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <6dc09d6c-e957-eeb5-34e7-089d3d608cd8@synopsys.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200601_113302_043685_C778758C X-CRM114-Status: GOOD ( 10.62 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-snps-arc@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On 01/06/2020 15:12, Vineet Gupta wrote: > On 6/1/20 7:42 AM, Adhemerval Zanella via Libc-alpha wrote: >> You will need to move this definitions inside the !USE_SQRTF_BUILTIN >> to avoid defined by not used warnings. Current practice is to just >> open code the constants and let compiler optimize the constant pool: > > Won't it be better to keep the const variable and trust the compiler to subsume it > instead of open coding in multiple places. Makes it more readable ? I don't have a strong preference, it is just the recent math optimizations use the constant directly in the hex format instead of trying to factoring them out. _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc