From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9063C64E7C for ; Wed, 2 Dec 2020 12:34:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 631742222F for ; Wed, 2 Dec 2020 12:34:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726629AbgLBMd5 (ORCPT ); Wed, 2 Dec 2020 07:33:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725859AbgLBMd5 (ORCPT ); Wed, 2 Dec 2020 07:33:57 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9843DC0613CF; Wed, 2 Dec 2020 04:33:16 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id e25so7519094wme.0; Wed, 02 Dec 2020 04:33:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rIn6QWz2xudVpAq7uZ7Rf4V3ACEBYHTmdt8ipDUu0MQ=; b=la+tWiJvvIroO80Y6slUiKrzpYqcz5PXM8WrpHg+YMFLLgRGXVzlxwzKvQrc3gMPRX PLNmW2b0PhBJhyevb7fByo9VkIbX40RgaYrdnL6LKvn/fXhO2XAd0H242R7wnmZ0VqYi PffNnMgSgQVS+Ju2qZQYh20g3C+sbEG8u1NJb4Vm1KVF1kKeJ0TP8r/DcA6GMv3JRgFj bnNLjSR8WUN0yOaq1YeFTBi1KUb7lJHXdtv+B2rAns+7S5drWTArv8I4hztt2TF0nksC QqnZi/ViWZhgWeq2tTaIaPKVtdt/57VcID4zYt7MHRYVm0eGuV5ekm3qDuVFDEXTLWEP Kfmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rIn6QWz2xudVpAq7uZ7Rf4V3ACEBYHTmdt8ipDUu0MQ=; b=GjVfArbDuP0e11on4KYtfdhFZS0NnknFO2lmW/fyQlIl4rMVNb7bC+tFLlnx02CyOB PIqu7x2FEwxMMT7cl7/g8bsFHc964JrnV0yKuVWJa4ECVJuhAKbWZczYC/PfZC4W8hx3 Q5tRsph9zXaElSAtmFn0y3YoITeG9ReySoRbgyVfXC+COJwkjdkUz2QpAc7UxLOA+NxW wWoLa47eBG0zAl7CNqlfZHqopVQZiqDnx9e/NrqahHnjRn90xC1MtdzpgjvWD0g8lJV9 uR+SeiCU4GSTU2U95aotAf3PX0r3Xs9FHxmpoWgp3nifYv0xHHofGxwHrhOPPM9JoWVO 4Kkg== X-Gm-Message-State: AOAM531fT38glfpEgiLwIbuv8n+Bndm2t5hU2PqqWEqDs8RVDBtH8oB7 RalcJ51Jzbk3fB0wbu9/6lXJMA1h0nLlFJmY X-Google-Smtp-Source: ABdhPJzm7lTbbL0RMIe+sSxgF1+aJlnOtxvKJJAJJu115+v9PVuiu/kmKy/ZQy2+DlGYIcegJS1ZMw== X-Received: by 2002:a1c:6002:: with SMTP id u2mr2985322wmb.29.1606912395093; Wed, 02 Dec 2020 04:33:15 -0800 (PST) Received: from [192.168.1.143] ([170.253.51.130]) by smtp.gmail.com with ESMTPSA id o2sm1922153wrq.37.2020.12.02.04.33.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Dec 2020 04:33:14 -0800 (PST) Subject: Re: [PATCH -V6 RESEND 2/3] NOT kernel/man-pages: man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING To: Huang Ying , Peter Zijlstra , Mel Gorman Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Matthew Wilcox (Oracle)" , Rafael Aquini , Andrew Morton , Ingo Molnar , Rik van Riel , Johannes Weiner , Dave Hansen , Andi Kleen , Michal Hocko , David Rientjes , linux-api@vger.kernel.org References: <20201202084234.15797-1-ying.huang@intel.com> <20201202084234.15797-3-ying.huang@intel.com> From: "Alejandro Colomar (mailing lists; readonly)" Message-ID: <48e758d7-9961-e28e-26f5-3bb381d36309@gmail.com> Date: Wed, 2 Dec 2020 13:33:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201202084234.15797-3-ying.huang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Huang Ying, Please see a few fixes below. Michael, as always, some question for you too ;) Thanks, Alex On 12/2/20 9:42 AM, Huang Ying wrote: > Signed-off-by: "Huang, Ying" > --- > man2/set_mempolicy.2 | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2 > index 68011eecb..3754b3e12 100644 > --- a/man2/set_mempolicy.2 > +++ b/man2/set_mempolicy.2 > @@ -113,6 +113,12 @@ A nonempty > .I nodemask > specifies node IDs that are relative to the set of > node IDs allowed by the process's current cpuset. > +.TP > +.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)" I'd prefer it to be in alphabetical order (rather than just adding at the bottom). That way, when lists grow, it's easier to find things. > +Enable the Linux kernel NUMA balancing for the task if it is supported > +by kernel. I'd s/Linux kernel/kernel/ when it doesn't specifically refer to the Linux kernel to differentiate it from other kernels. It only adds noise (IMHO). mtk? wfix: ... supported by _the_ kernel. > +If the flag isn't supported by Linux kernel, return -1 and errno is wfix: If the flag isn't supported by _the_ kernel, ... > +set to EINVAL. errno and EINVAL should use .I and .B respectively > .PP > .I nodemask > points to a bit mask of node IDs that contains up to > @@ -293,6 +299,9 @@ argument specified both > .B MPOL_F_STATIC_NODES > and > .BR MPOL_F_RELATIVE_NODES . > +Or, the > +.B MPOL_F_NUMA_BALANCING > +isn't supported by the Linux kernel. > .TP > .B ENOMEM > Insufficient kernel memory was available. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00445C64E8A for ; Wed, 2 Dec 2020 12:33:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7A82A221FE for ; Wed, 2 Dec 2020 12:33:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A82A221FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 792328D0003; Wed, 2 Dec 2020 07:33:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 71A108D0002; Wed, 2 Dec 2020 07:33:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E1FD8D0003; Wed, 2 Dec 2020 07:33:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0162.hostedemail.com [216.40.44.162]) by kanga.kvack.org (Postfix) with ESMTP id 447798D0002 for ; Wed, 2 Dec 2020 07:33:17 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 049C93636 for ; Wed, 2 Dec 2020 12:33:17 +0000 (UTC) X-FDA: 77548282434.19.stop55_401147f273b3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id C920D1ACEA2 for ; Wed, 2 Dec 2020 12:33:16 +0000 (UTC) X-HE-Tag: stop55_401147f273b3 X-Filterd-Recvd-Size: 5351 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Dec 2020 12:33:16 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id d3so6733033wmb.4 for ; Wed, 02 Dec 2020 04:33:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rIn6QWz2xudVpAq7uZ7Rf4V3ACEBYHTmdt8ipDUu0MQ=; b=la+tWiJvvIroO80Y6slUiKrzpYqcz5PXM8WrpHg+YMFLLgRGXVzlxwzKvQrc3gMPRX PLNmW2b0PhBJhyevb7fByo9VkIbX40RgaYrdnL6LKvn/fXhO2XAd0H242R7wnmZ0VqYi PffNnMgSgQVS+Ju2qZQYh20g3C+sbEG8u1NJb4Vm1KVF1kKeJ0TP8r/DcA6GMv3JRgFj bnNLjSR8WUN0yOaq1YeFTBi1KUb7lJHXdtv+B2rAns+7S5drWTArv8I4hztt2TF0nksC QqnZi/ViWZhgWeq2tTaIaPKVtdt/57VcID4zYt7MHRYVm0eGuV5ekm3qDuVFDEXTLWEP Kfmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rIn6QWz2xudVpAq7uZ7Rf4V3ACEBYHTmdt8ipDUu0MQ=; b=M6NfDscukjyCHm6Zhs6UtoeVwUvZosyqq7UCpW3b/oCI1IKn8bUgjI2hiYz2l74isY QkSKfwEUS5IzkdaYot80VVVfSdaqY37EsTLox6IQGD5GkzIjRiIUQQMU0epM1HNeqt7/ 6tkBpnXwY52y/iJiom8tQrPXF73gRbTo/45Y30I3GIYV1Z6z4SVvy+ufAsWWhVicHrrO AcKVsKfeMexWtIQwCfy/Oo0CSQ37Ypm0qzT9R8SAeXnVhZHd+oRUVS20ugjStSKwfVnW lnR+9a7H4+seUUvhkQQ21zon0nl362RuGGfgaKDRU1XblZ7NqkXwMhs59oEKZ5vGOI+v OhfA== X-Gm-Message-State: AOAM532HYEChR5Qe04XIpE5VPbuHIiEttjMNUY/N9u4zc1o8W5vt+ese c89Xx66TI03KlP2kS/sh8uQ= X-Google-Smtp-Source: ABdhPJzm7lTbbL0RMIe+sSxgF1+aJlnOtxvKJJAJJu115+v9PVuiu/kmKy/ZQy2+DlGYIcegJS1ZMw== X-Received: by 2002:a1c:6002:: with SMTP id u2mr2985322wmb.29.1606912395093; Wed, 02 Dec 2020 04:33:15 -0800 (PST) Received: from [192.168.1.143] ([170.253.51.130]) by smtp.gmail.com with ESMTPSA id o2sm1922153wrq.37.2020.12.02.04.33.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Dec 2020 04:33:14 -0800 (PST) Subject: Re: [PATCH -V6 RESEND 2/3] NOT kernel/man-pages: man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING To: Huang Ying , Peter Zijlstra , Mel Gorman Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Matthew Wilcox (Oracle)" , Rafael Aquini , Andrew Morton , Ingo Molnar , Rik van Riel , Johannes Weiner , Dave Hansen , Andi Kleen , Michal Hocko , David Rientjes , linux-api@vger.kernel.org References: <20201202084234.15797-1-ying.huang@intel.com> <20201202084234.15797-3-ying.huang@intel.com> From: "Alejandro Colomar (mailing lists; readonly)" Message-ID: <48e758d7-9961-e28e-26f5-3bb381d36309@gmail.com> Date: Wed, 2 Dec 2020 13:33:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201202084234.15797-3-ying.huang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Huang Ying, Please see a few fixes below. Michael, as always, some question for you too ;) Thanks, Alex On 12/2/20 9:42 AM, Huang Ying wrote: > Signed-off-by: "Huang, Ying" > --- > man2/set_mempolicy.2 | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2 > index 68011eecb..3754b3e12 100644 > --- a/man2/set_mempolicy.2 > +++ b/man2/set_mempolicy.2 > @@ -113,6 +113,12 @@ A nonempty > .I nodemask > specifies node IDs that are relative to the set of > node IDs allowed by the process's current cpuset. > +.TP > +.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)" I'd prefer it to be in alphabetical order (rather than just adding at the bottom). That way, when lists grow, it's easier to find things. > +Enable the Linux kernel NUMA balancing for the task if it is supported > +by kernel. I'd s/Linux kernel/kernel/ when it doesn't specifically refer to the Linux kernel to differentiate it from other kernels. It only adds noise (IMHO). mtk? wfix: ... supported by _the_ kernel. > +If the flag isn't supported by Linux kernel, return -1 and errno is wfix: If the flag isn't supported by _the_ kernel, ... > +set to EINVAL. errno and EINVAL should use .I and .B respectively > .PP > .I nodemask > points to a bit mask of node IDs that contains up to > @@ -293,6 +299,9 @@ argument specified both > .B MPOL_F_STATIC_NODES > and > .BR MPOL_F_RELATIVE_NODES . > +Or, the > +.B MPOL_F_NUMA_BALANCING > +isn't supported by the Linux kernel. > .TP > .B ENOMEM > Insufficient kernel memory was available. >