All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Durrant, Paul" <pdurrant@amazon.co.uk>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>
Cc: "Allister, Jack" <jalliste@amazon.com>,
	"bp@alien8.de" <bp@alien8.de>,
	"diapop@amazon.co.uk" <diapop@amazon.co.uk>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"jmattson@google.com" <jmattson@google.com>,
	"joro@8bytes.org" <joro@8bytes.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"metikaya@amazon.co.uk" <metikaya@amazon.co.uk>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
	"sean.j.christopherson@intel.com"
	<sean.j.christopherson@intel.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"wanpengli@tencent.com" <wanpengli@tencent.com>,
	"x86@kernel.org" <x86@kernel.org>
Subject: RE: ...\n
Date: Wed, 1 Jun 2022 08:54:08 +0000	[thread overview]
Message-ID: <48edf12807254a2b86e339b26873bf00@EX13D32EUC003.ant.amazon.com> (raw)
In-Reply-To: <87r148olol.fsf@redhat.com>

> -----Original Message-----
[snip]
> >>
> >> I'll bite... What's ludicrous about wanting to run a guest at a lower
> >> CPU freq to minimize observable change in whatever workload it is
> >> running?
> >
> > *why* would you want to do that? Everybody wants their stuff done
> > faster.
> >
> 
> FWIW, I can see a valid use-case: imagine you're running some software
> which calibrates itself in the beginning to run at some desired real
> time speed but then the VM running it has to be migrated to a host with
> faster (newer) CPUs. I don't have a real world examples out of top of my
> head but I remember some old DOS era games were impossible to play on
> newer CPUs because everything was happenning too fast. Maybe that's the
> case :-)
> 

That is exactly the case. This is not 'some hare-brained money scheme'; there is genuine concern that moving a VM from old h/w to new h/w may cause it to run 'too fast', breaking any such calibration done by the guest OS/application. I also don't have any real-world examples, but bugs may well be reported and having a lever to address them is IMO a good idea.
However, I also agree with Paolo that KVM doesn't really need to be doing this when the VMM could do the job using cpufreq, so we'll pursue that option instead. (FWIW the reason for involving KVM was to do the freq adjustment right before entering the guest and then remove the cap right after VMEXIT).

  Paul

  parent reply	other threads:[~2022-06-01  8:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-31 10:59 [PATCH] KVM: VMX: CPU frequency scaling for intel x86_64 KVM guests Jack Allister
2022-05-31 11:43 ` Metin Kaya
2022-05-31 18:11   ` Paolo Bonzini
2022-06-01 12:55     ` David Woodhouse
2022-05-31 13:38 ` Peter Zijlstra
2022-05-31 14:02   ` ...\n Jack Allister
2022-05-31 14:44     ` ...\n Peter Zijlstra
2022-05-31 14:52       ` ...\n Durrant, Paul
2022-05-31 15:51         ` ...\n Paolo Bonzini
2022-06-01  7:57           ` ...\n Vitaly Kuznetsov
2022-06-01  8:59             ` ...\n Paolo Bonzini
2022-06-01 10:19               ` ...\n Peter Zijlstra
2022-06-01  6:52         ` ...\n Peter Zijlstra
2022-06-01  8:03           ` ...\n Vitaly Kuznetsov
2022-06-01  8:25             ` ...\n Christophe de Dinechin
2022-06-01  8:54             ` Durrant, Paul [this message]
2022-06-01  8:57               ` ...\n Paolo Bonzini
2022-06-01  9:20                 ` ...\n Durrant, Paul
2022-06-01  9:43           ` ...\n Amit Shah
2022-06-01 13:14           ` ...\n David Woodhouse
2022-05-31 14:52       ` ...\n Paolo Bonzini
2022-05-31 15:27         ` ...\n Peter Zijlstra
2022-05-31 15:01 ` [PATCH] KVM: VMX: CPU frequency scaling for intel x86_64 KVM guests Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48edf12807254a2b86e339b26873bf00@EX13D32EUC003.ant.amazon.com \
    --to=pdurrant@amazon.co.uk \
    --cc=bp@alien8.de \
    --cc=diapop@amazon.co.uk \
    --cc=hpa@zytor.com \
    --cc=jalliste@amazon.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=metikaya@amazon.co.uk \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rkrcmar@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=tglx@linutronix.de \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.