All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhiquan Li <zhiquan1.li@intel.com>
To: Haitao Huang <haitao.huang@linux.intel.com>,
	<linux-sgx@vger.kernel.org>, <tony.luck@intel.com>,
	<jarkko@kernel.org>, <dave.hansen@linux.intel.com>,
	<tglx@linutronix.de>, <bp@alien8.de>
Cc: <seanjc@google.com>, <kai.huang@intel.com>, <fan.du@intel.com>,
	<cathy.zhang@intel.com>, <zhiquan1.li@intel.com>
Subject: Re: [PATCH v8 2/3] x86/sgx: Introduce union with vepc_vaddr field for virtualization case
Date: Thu, 15 Sep 2022 10:22:33 +0800	[thread overview]
Message-ID: <48f10df1-f5ac-cd66-032a-5648989b8aba@intel.com> (raw)
In-Reply-To: <op.1shsrfrrwjvjmi@hhuan26-mobl1.mshome.net>


On 2022/9/14 23:46, Haitao Huang wrote:
> Maybe it's just me missing some prior knowledge. It's not obvious to me
> why you don't need any guard accessing the encl_owner field in ksgxd
> thread. Is it because all vepc pages are never put in the active list
> and encl_owner would never be null for all pages in that list?

Yes, all vepc pages are never put in the active list. The SGX core page
reclaimer doesn’t support reclaiming EPC pages allocated to KVM guests
through the virtual EPC driver.

> Regardless, could you add a few sentence here to to make the rule explicit?

More details please see the section "Virtual EPC" at
Documentation/x86/sgx.rst.

Thanks and Best Regards,
Zhiquan

> 
> Thanks
> Haitao

  reply	other threads:[~2022-09-15  2:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-13 14:53 [PATCH v8 0/3] x86/sgx: fine grained SGX MCA behavior Zhiquan Li
2022-09-13 14:53 ` [PATCH v8 1/3] x86/sgx: Rename the owner field of struct sgx_epc_page as encl_owner Zhiquan Li
2022-09-13 14:53 ` [PATCH v8 2/3] x86/sgx: Introduce union with vepc_vaddr field for virtualization case Zhiquan Li
2022-09-13 16:40   ` Huang, Kai
2022-09-14  0:29     ` Zhiquan Li
2022-09-14 15:46   ` Haitao Huang
2022-09-15  2:22     ` Zhiquan Li [this message]
2022-09-15 20:00       ` Haitao Huang
2022-09-20  4:51   ` Jarkko Sakkinen
2022-09-13 14:53 ` [PATCH v8 3/3] x86/sgx: Fine grained SGX MCA behavior for virtualization Zhiquan Li
2022-09-20  4:52   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48f10df1-f5ac-cd66-032a-5648989b8aba@intel.com \
    --to=zhiquan1.li@intel.com \
    --cc=bp@alien8.de \
    --cc=cathy.zhang@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=fan.du@intel.com \
    --cc=haitao.huang@linux.intel.com \
    --cc=jarkko@kernel.org \
    --cc=kai.huang@intel.com \
    --cc=linux-sgx@vger.kernel.org \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.