From: Bruce Ashfield <bruce.ashfield@windriver.com>
To: richard.purdie@linuxfoundation.org
Cc: openembedded-core@lists.openembedded.org
Subject: [PATCH 3/4] kern-tools: fix processing for no branch meta-data
Date: Fri, 2 Dec 2016 16:09:24 -0500 [thread overview]
Message-ID: <48f1e3e16ca28e1194d6024689d000cb6ffc303c.1480711764.git.bruce.ashfield@windriver.com> (raw)
In-Reply-To: <cover.1480711764.git.bruce.ashfield@windriver.com>
In-Reply-To: <cover.1480711764.git.bruce.ashfield@windriver.com>
Lernel meta-data that has patches, but no branches, can trigger an
error due to no branch specific patch queue.
This error then cascades to more issues since the tools are using
a named file in /tmp to store and display error messages to the
user.
We fix both issues though the following kern tools tweaks:
commit bd9e1d6c9b0a34ff3e19a06999aaf57ffadfd04c
Author: Bruce Ashfield <bruce.ashfield@windriver.com>
Date: Fri Dec 2 13:09:40 2016 -0500
scc: use mktemp for consolidated output capture
To provide useful error messages the tools dump pre-processed
files and messages to a temporary file. If multiple users are
doing builds, this means they either race, or can have permissions
issues.
By creating the temporary file via mktemp, we avoid both issues.
(We also make sure to clean these up on exit, or /tmp will get
polluted quickly).
commit a287da4bfe0b4acb8f2b0627bd8e7abd1a1dde26
Author: Bruce Ashfield <bruce.ashfield@windriver.com>
Date: Fri Dec 2 13:08:08 2016 -0500
patch: do not assume a branch specific patch queue is needed
When processing input files per-branch and global patch queues are
generated. If the meta-data has not created any branches in the
repo, no branch specific queue is required.
The tools assumed that one is always valid, and hence would throw a
non-zero exit code and stop processing.
By testing for a named per-branch queue, we avoid this issue.
Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
---
meta/recipes-kernel/kern-tools/kern-tools-native_git.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb b/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
index 88b1aee729c9..0f8a786176f9 100644
--- a/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
+++ b/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
@@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = "file://git/tools/kgit;beginline=5;endline=9;md5=a6c2fa8aef1b
DEPENDS = "git-native"
-SRCREV = "b36f6f9a5695f2084b83823393e13ca42284bed9"
+SRCREV = "bd9e1d6c9b0a34ff3e19a06999aaf57ffadfd04c"
PR = "r12"
PV = "0.2+git${SRCPV}"
--
2.5.0
next prev parent reply other threads:[~2016-12-02 21:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 21:09 [PATCH 0/4] kernel-yocto: consolidated pull request Bruce Ashfield
2016-12-02 21:09 ` [PATCH 1/4] linux-yocto/4.8: update to v4.8.10 Bruce Ashfield
2016-12-02 21:09 ` [PATCH 2/4] linux-yocto-dev: update to 4.9-rcX Bruce Ashfield
2016-12-02 21:09 ` Bruce Ashfield [this message]
2016-12-06 21:14 ` [PATCH 3/4] kern-tools: fix processing for no branch meta-data Patrick Ohly
2016-12-06 23:02 ` Paul Barker
2016-12-07 15:11 ` Trevor Woerner
2016-12-07 15:14 ` Bruce Ashfield
2016-12-07 16:18 ` Bruce Ashfield
2016-12-07 18:05 ` Trevor Woerner
2016-12-07 23:50 ` Trevor Woerner
2016-12-08 3:23 ` Bruce Ashfield
2016-12-08 15:27 ` Bruce Ashfield
2016-12-02 21:09 ` [PATCH 4/4] kernel-yocto: exit on non-zero return code Bruce Ashfield
2016-12-06 19:32 ` [PATCH 0/4] kernel-yocto: consolidated pull request Trevor Woerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48f1e3e16ca28e1194d6024689d000cb6ffc303c.1480711764.git.bruce.ashfield@windriver.com \
--to=bruce.ashfield@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.