From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45D911586 for ; Tue, 15 Feb 2022 16:00:35 +0000 (UTC) Received: by mail-wr1-f42.google.com with SMTP id p9so12373936wra.12 for ; Tue, 15 Feb 2022 08:00:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kynesim-co-uk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:references:in-reply-to :user-agent:mime-version:content-transfer-encoding; bh=ev89lW43hp3qbktlsuNQsUosdM2OcOnj9zBVHNAOnL8=; b=MzhjypX5VGUPPfW7ufDzJ8pOoKfavQjYoYSJYclgytqFqBZXKAxG/msV+MgbB55DP5 jYgdlvnq14freS8c1DXIVKTwo4g3MgEAMfJamOTRNvFOfeNTbM+HFp7pbT6Rg3MkaSsv 2W1i9eXP/Pqq5DdvtAIxaKRpeDKINU1a6ydfjrucTHbKhKNZs6Z3UBJs12sy8snQSROw n+f2mC8o9/2bgRRyaVwia0sH4QP7EjM0R91QflOf1mCsWwroGs8zNw1amBlMvOIItEgh q0070k1DGHqGBfi59rC1aLgL30M3xE7jnZLs+N+jscdMKK/83d5YG6WsZQxb0IH/70Wr my3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:references :in-reply-to:user-agent:mime-version:content-transfer-encoding; bh=ev89lW43hp3qbktlsuNQsUosdM2OcOnj9zBVHNAOnL8=; b=R6tB+0mLT2INXVKCEVCKEfHEAUV2WLKoNfJcYge58zMRTc31w59bGyoj1ZKhNTpuMt k8Kryz27oyD/FOoJrKwLw/S53nNVgLkb+WSrhKrFgYsYqdMxAkH6VjyvfWwBgc7ZZiTt K7cdwd9Z+41CXJNKQagNwIJqs0ywFNS832etyp/cwM60u8pBlcGEtH5u5FsemOEQLXxJ H7wVmcT5yeR1VV69RTGp6Rg+4haFUtAZxOJslUnl6fTWGE0XrYIj+CsfO3q7bBlCy+tI 8iEgiDODjWf+fHtmR14a5EuaoTUmQ4PIQbCIBNFzKqvDSyvorkExjQ1M1BWksWOAXBk+ CU4w== X-Gm-Message-State: AOAM533CEh+NlX1dsb4XTrGkJN3+l64OUIaeasWqYANti7arNgYYhQm5 tvnXMU01EJ7WmM/f8RL7r3J4nA== X-Google-Smtp-Source: ABdhPJyG0esH7uOaAhVJZcD69tfS19xit7vvGYjc7dcKtgtWanE0SsRjK2d4ZYNkwauxdqt+v2WpYw== X-Received: by 2002:a5d:6488:: with SMTP id o8mr3708827wri.24.1644940834309; Tue, 15 Feb 2022 08:00:34 -0800 (PST) Received: from CTHALPA.outer.uphall.net (cpc1-cmbg20-2-0-cust759.5-4.cable.virginm.net. [86.21.218.248]) by smtp.gmail.com with ESMTPSA id l9sm15483830wrt.29.2022.02.15.08.00.33 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Tue, 15 Feb 2022 08:00:33 -0800 (PST) From: John Cox To: Nicolas Dufresne Cc: Benjamin Gaignard , mchehab@kernel.org, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, jernej.skrabec@gmail.com, hverkuil-cisco@xs4all.nl, jonas@kwiboo.se, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@collabora.com, knaerzche@gmail.com Subject: Re: [RFC v2 6/8] media: uapi: Remove bit_size field from v4l2_ctrl_hevc_slice_params Date: Tue, 15 Feb 2022 16:00:33 +0000 Message-ID: <48in0h5qq4ea87gcnmtkpsfqdk1r4tipid@4ax.com> References: <20220215110103.241297-1-benjamin.gaignard@collabora.com> <20220215110103.241297-7-benjamin.gaignard@collabora.com> <99062279-a3c4-96f7-4c4b-f39e7f812e68@collabora.com> <9a78eb88f8690d43d34d8140420dae3f5f043637.camel@ndufresne.ca> In-Reply-To: <9a78eb88f8690d43d34d8140420dae3f5f043637.camel@ndufresne.ca> User-Agent: ForteAgent/8.00.32.1272 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, 15 Feb 2022 10:28:55 -0500, you wrote: >Le mardi 15 f=C3=A9vrier 2022 =C3=A0 14:50 +0000, John Cox a = =C3=A9crit=C2=A0: >> On Tue, 15 Feb 2022 15:35:12 +0100, you wrote: >>=20 >> >=20 >> > Le 15/02/2022 =C3=A0 15:17, John Cox a =C3=A9crit=C2=A0: >> > > Hi >> > >=20 >> > > > The bit size of the slice could be deduced from the buffer = payload >> > > > so remove bit_size field to avoid duplicated the information. >> > > I think this is a bad idea. In the future we are (I hope) going to= want >> > > to have an array (variable) of slice headers all referring to the = same >> > > bit buffer. When we do that we will need this field. >> >=20 >> > I wonder if that could be considering like another decode mode and = so >> > use an other control ? >>=20 >> I, personally, would be in favour of making the slice header control a >> variable array just as it is. If userland can't cope with multiple >> entries then just send them one at a time and the code looks exactly >> like it does at the moment and if the driver can't then set max array >> entries to 1. >>=20 >> Having implemented this in rpi port of ffmpeg and the RPi V4L2 driver = I >> can say with experience that the code and effort overhead is very low. >>=20 >> Either way having a multiple slice header control in the UAPI is >> important for efficiency. > >Just to clarify the idea, we would have a single slice controls, always = dynamic: > >1. For sliced based decoder > >The dynamic array slice control is implemented by the driver and its = size must >be 1. Yes >2. For frame based decoder that don't care for slices > >The dynamic array slice controls is not implement. Userland detects that= at >runtime, similar to the VP9 compressed headers. If the driver parses all the slice header then that seems plausible >3. For frame based decoders that needs slices (or driver that supports = offset >and can gain performance with such mode) > >The dynamic array slice controls is implemented, and should contain all = the >slices found in the OUTPUT buffer. > >So the reason for this bit_size (not sure why its bits though, perhaps = someone >can educate me ?) RPi doesn't need bits and would be happy with bytes however slice_segment data isn't byte aligned at the end so its possible that there might be decoders out there that want an accurate length for that. > Would be to let the driver offset inside the the single >OUTPUT/bitstream buffer in case this is not automatically found by the = driver >(or that no start-code is needed). Is that last bit correct ? If so, = should we >change it to an offset rather then a size ? Shall we allow using = offesets inside >larger buffer (e.g. to avoid some memory copies) for the Sliced Base = cases ? I use (in the current structure) data_bit_offset to find the start of each slice's slice_segment_data within the OUTPUT buffer and bit_size to find the end. RPi doesn't / can't parse the slice_header and so wants all of that. Decoders that do parse the header might plausably want header offsets too and it would facilitate zero copy of the bit buffer. =20 >> Regards >>=20 >> John Cox >>=20 >> > > > Signed-off-by: Benjamin Gaignard = >> > > > --- >> > > > .../userspace-api/media/v4l/ext-ctrls-codec.rst | 3 --- >> > > > drivers/staging/media/sunxi/cedrus/cedrus_h265.c | 11 = ++++------- >> > > > include/uapi/linux/v4l2-controls.h | 3 +-- >> > > > 3 files changed, 5 insertions(+), 12 deletions(-) >> > > >=20 >> > > > diff --git = a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst = b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst >> > > > index 3296ac3b9fca..c3ae97657fa7 100644 >> > > > --- a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst >> > > > +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst >> > > > @@ -2965,9 +2965,6 @@ enum = v4l2_mpeg_video_hevc_size_of_length_field - >> > > > :stub-columns: 0 >> > > > :widths: 1 1 2 >> > > >=20 >> > > > - * - __u32 >> > > > - - ``bit_size`` >> > > > - - Size (in bits) of the current slice data. >> > > > * - __u32 >> > > > - ``data_bit_offset`` >> > > > - Offset (in bits) to the video data in the current slice= data. >> > > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_h265.c = b/drivers/staging/media/sunxi/cedrus/cedrus_h265.c >> > > > index 8ab2d9c6f048..db8c7475eeb8 100644 >> > > > --- a/drivers/staging/media/sunxi/cedrus/cedrus_h265.c >> > > > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_h265.c >> > > > @@ -312,8 +312,8 @@ static void cedrus_h265_setup(struct = cedrus_ctx *ctx, >> > > > const struct v4l2_hevc_pred_weight_table *pred_weight_table; >> > > > unsigned int width_in_ctb_luma, ctb_size_luma; >> > > > unsigned int log2_max_luma_coding_block_size; >> > > > + size_t slice_bytes; >> > > > dma_addr_t src_buf_addr; >> > > > - dma_addr_t src_buf_end_addr; >> > > > u32 chroma_log2_weight_denom; >> > > > u32 output_pic_list_index; >> > > > u32 pic_order_cnt[2]; >> > > > @@ -370,8 +370,8 @@ static void cedrus_h265_setup(struct = cedrus_ctx *ctx, >> > > >=20 >> > > > cedrus_write(dev, VE_DEC_H265_BITS_OFFSET, 0); >> > > >=20 >> > > > - reg =3D slice_params->bit_size; >> > > > - cedrus_write(dev, VE_DEC_H265_BITS_LEN, reg); >> > > > + slice_bytes =3D vb2_get_plane_payload(&run->src->vb2_buf, 0); >> > > > + cedrus_write(dev, VE_DEC_H265_BITS_LEN, slice_bytes); >> > > I think one of these must be wrong. bit_size is in bits, >> > > vb2_get_plane_payload is in bytes? >> >=20 >> > You are right it should be vb2_get_plane_payload() * 8 to get the = size in bits. >> >=20 >> > I will change that in v3. >> >=20 >> > >=20 >> > > Regards >> > >=20 >> > > John Cox >> > > =20 >> > > > /* Source beginning and end addresses. */ >> > > >=20 >> > > > @@ -384,10 +384,7 @@ static void cedrus_h265_setup(struct = cedrus_ctx *ctx, >> > > >=20 >> > > > cedrus_write(dev, VE_DEC_H265_BITS_ADDR, reg); >> > > >=20 >> > > > - src_buf_end_addr =3D src_buf_addr + >> > > > - DIV_ROUND_UP(slice_params->bit_size, 8); >> > > > - >> > > > - reg =3D VE_DEC_H265_BITS_END_ADDR_BASE(src_buf_end_addr); >> > > > + reg =3D VE_DEC_H265_BITS_END_ADDR_BASE(src_buf_addr + = slice_bytes); >> > > > cedrus_write(dev, VE_DEC_H265_BITS_END_ADDR, reg); >> > > >=20 >> > > > /* Coding tree block address */ >> > > > diff --git a/include/uapi/linux/v4l2-controls.h = b/include/uapi/linux/v4l2-controls.h >> > > > index b1a3dc05f02f..27f5d272dc43 100644 >> > > > --- a/include/uapi/linux/v4l2-controls.h >> > > > +++ b/include/uapi/linux/v4l2-controls.h >> > > > @@ -2457,7 +2457,6 @@ struct v4l2_hevc_pred_weight_table { >> > > > #define V4L2_HEVC_SLICE_PARAMS_FLAG_DEPENDENT_SLICE_SEGMENT = (1ULL << 9) >> > > >=20 >> > > > struct v4l2_ctrl_hevc_slice_params { >> > > > - __u32 bit_size; >> > > > __u32 data_bit_offset; >> > > >=20 >> > > > /* ISO/IEC 23008-2, ITU-T Rec. H.265: NAL unit header */ >> > > > @@ -2484,7 +2483,7 @@ struct v4l2_ctrl_hevc_slice_params { >> > > > /* ISO/IEC 23008-2, ITU-T Rec. H.265: Picture timing SEI = message */ >> > > > __u8 pic_struct; >> > > >=20 >> > > > - __u8 reserved; >> > > > + __u8 reserved[5]; >> > > >=20 >> > > > /* ISO/IEC 23008-2, ITU-T Rec. H.265: General slice segment = header */ >> > > > __u32 slice_segment_addr; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6B5AC433F5 for ; Tue, 15 Feb 2022 16:09:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l/EW0/YogAKeDu8vkavBnplTCSZiNaEAnehSkbX2bHA=; b=1rk6iTIdIKNQer U/bdHpFvPozSjb+3/8lNCf1wP3Y8nDwbgRKYfxrBDiN9tfFMCQRuoKLUpJGRyvzmD6LKzQydhkyIP 3SpR4BMChVLV890QsbDOmm6BqX99N7GHHYUxuMzqt5ud1b5Fi55RQ9tka7fjEuiyKQv4c+q06Uqnm DjBI46TZi9BH/q9h6UlCfDXwXF5xk6WVqYDc0bTn73qf810VZQ1rd6Ith0nnpNdS8j7KirP1IpTga sEVkDQhgq9S0tDRa/jy+a9dCYN4HVi4Q60mIz4FO9DMLzdssgaRJYa4QdGHEUX5JnTTBQtGnz3QXN bmH5nn/AyVFROz1X5vyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK0MK-003ZHD-SA; Tue, 15 Feb 2022 16:07:22 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK0Fn-003WC6-U7 for linux-arm-kernel@lists.infradead.org; Tue, 15 Feb 2022 16:00:38 +0000 Received: by mail-wr1-x42b.google.com with SMTP id w11so32912386wra.4 for ; Tue, 15 Feb 2022 08:00:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kynesim-co-uk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:references:in-reply-to :user-agent:mime-version:content-transfer-encoding; bh=ev89lW43hp3qbktlsuNQsUosdM2OcOnj9zBVHNAOnL8=; b=MzhjypX5VGUPPfW7ufDzJ8pOoKfavQjYoYSJYclgytqFqBZXKAxG/msV+MgbB55DP5 jYgdlvnq14freS8c1DXIVKTwo4g3MgEAMfJamOTRNvFOfeNTbM+HFp7pbT6Rg3MkaSsv 2W1i9eXP/Pqq5DdvtAIxaKRpeDKINU1a6ydfjrucTHbKhKNZs6Z3UBJs12sy8snQSROw n+f2mC8o9/2bgRRyaVwia0sH4QP7EjM0R91QflOf1mCsWwroGs8zNw1amBlMvOIItEgh q0070k1DGHqGBfi59rC1aLgL30M3xE7jnZLs+N+jscdMKK/83d5YG6WsZQxb0IH/70Wr my3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:references :in-reply-to:user-agent:mime-version:content-transfer-encoding; bh=ev89lW43hp3qbktlsuNQsUosdM2OcOnj9zBVHNAOnL8=; b=HzmTc6lHKDc3wft6C9VJUq2f29Zgz1CfaI2At8tFnyktJegRnjZR7L5gU2w44pk6wV LCAakBGFYijMNklctVlA2CNIfIeaqdhhqr9mM1FRNtvJzEhqvXMjtH0oO1xpSGzX6VAw 0DLhvCH/f9wDdUr0Hk1p9luR4U4W2LvLkdtTzkMqicvc+QzRVrqkqe7V2JF1yyMHZ/Fi KWJ9qXUz2TtWsei3de6TVbnJKQH2Ga9qN+sj5cGeanKMMNHIIBoaNL30xErh+ySiuPL2 TbiPSk8FW/3qXX6N+I/UV7KuoWfFBGHXzlqYE7mcA25ZXZFSnGD+qTrlY5oy4l8EQWSm nlGg== X-Gm-Message-State: AOAM531wuQyPlMTm6n696XVAi3YTatcBMZWKMEqmznCEsqEsdva+0EAq Rstx62+lbHPe5kidG9yhaZAmRA== X-Google-Smtp-Source: ABdhPJyG0esH7uOaAhVJZcD69tfS19xit7vvGYjc7dcKtgtWanE0SsRjK2d4ZYNkwauxdqt+v2WpYw== X-Received: by 2002:a5d:6488:: with SMTP id o8mr3708827wri.24.1644940834309; Tue, 15 Feb 2022 08:00:34 -0800 (PST) Received: from CTHALPA.outer.uphall.net (cpc1-cmbg20-2-0-cust759.5-4.cable.virginm.net. [86.21.218.248]) by smtp.gmail.com with ESMTPSA id l9sm15483830wrt.29.2022.02.15.08.00.33 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Tue, 15 Feb 2022 08:00:33 -0800 (PST) From: John Cox To: Nicolas Dufresne Cc: Benjamin Gaignard , mchehab@kernel.org, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, jernej.skrabec@gmail.com, hverkuil-cisco@xs4all.nl, jonas@kwiboo.se, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@collabora.com, knaerzche@gmail.com Subject: Re: [RFC v2 6/8] media: uapi: Remove bit_size field from v4l2_ctrl_hevc_slice_params Date: Tue, 15 Feb 2022 16:00:33 +0000 Message-ID: <48in0h5qq4ea87gcnmtkpsfqdk1r4tipid@4ax.com> References: <20220215110103.241297-1-benjamin.gaignard@collabora.com> <20220215110103.241297-7-benjamin.gaignard@collabora.com> <99062279-a3c4-96f7-4c4b-f39e7f812e68@collabora.com> <9a78eb88f8690d43d34d8140420dae3f5f043637.camel@ndufresne.ca> In-Reply-To: <9a78eb88f8690d43d34d8140420dae3f5f043637.camel@ndufresne.ca> User-Agent: ForteAgent/8.00.32.1272 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220215_080036_076241_C8D0FA87 X-CRM114-Status: GOOD ( 41.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAxNSBGZWIgMjAyMiAxMDoyODo1NSAtMDUwMCwgeW91IHdyb3RlOgoKPkxlIG1hcmRp IDE1IGbDqXZyaWVyIDIwMjIgw6AgMTQ6NTAgKzAwMDAsIEpvaG4gQ294IGEgw6ljcml0wqA6Cj4+ IE9uIFR1ZSwgMTUgRmViIDIwMjIgMTU6MzU6MTIgKzAxMDAsIHlvdSB3cm90ZToKPj4gCj4+ID4g Cj4+ID4gTGUgMTUvMDIvMjAyMiDDoCAxNToxNywgSm9obiBDb3ggYSDDqWNyaXTCoDoKPj4gPiA+ IEhpCj4+ID4gPiAKPj4gPiA+ID4gVGhlIGJpdCBzaXplIG9mIHRoZSBzbGljZSBjb3VsZCBiZSBk ZWR1Y2VkIGZyb20gdGhlIGJ1ZmZlciBwYXlsb2FkCj4+ID4gPiA+IHNvIHJlbW92ZSBiaXRfc2l6 ZSBmaWVsZCB0byBhdm9pZCBkdXBsaWNhdGVkIHRoZSBpbmZvcm1hdGlvbi4KPj4gPiA+IEkgdGhp bmsgdGhpcyBpcyBhIGJhZCBpZGVhLiBJbiB0aGUgZnV0dXJlIHdlIGFyZSAoSSBob3BlKSBnb2lu ZyB0byB3YW50Cj4+ID4gPiB0byBoYXZlIGFuIGFycmF5ICh2YXJpYWJsZSkgb2Ygc2xpY2UgaGVh ZGVycyBhbGwgcmVmZXJyaW5nIHRvIHRoZSBzYW1lCj4+ID4gPiBiaXQgYnVmZmVyLiAgV2hlbiB3 ZSBkbyB0aGF0IHdlIHdpbGwgbmVlZCB0aGlzIGZpZWxkLgo+PiA+IAo+PiA+IEkgd29uZGVyIGlm IHRoYXQgY291bGQgYmUgY29uc2lkZXJpbmcgbGlrZSBhbm90aGVyIGRlY29kZSBtb2RlIGFuZCBz bwo+PiA+IHVzZSBhbiBvdGhlciBjb250cm9sID8KPj4gCj4+IEksIHBlcnNvbmFsbHksIHdvdWxk IGJlIGluIGZhdm91ciBvZiBtYWtpbmcgdGhlIHNsaWNlIGhlYWRlciBjb250cm9sIGEKPj4gdmFy aWFibGUgYXJyYXkganVzdCBhcyBpdCBpcy4gIElmIHVzZXJsYW5kIGNhbid0IGNvcGUgd2l0aCBt dWx0aXBsZQo+PiBlbnRyaWVzIHRoZW4ganVzdCBzZW5kIHRoZW0gb25lIGF0IGEgdGltZSBhbmQg dGhlIGNvZGUgbG9va3MgZXhhY3RseQo+PiBsaWtlIGl0IGRvZXMgYXQgdGhlIG1vbWVudCBhbmQg aWYgdGhlIGRyaXZlciBjYW4ndCB0aGVuIHNldCBtYXggYXJyYXkKPj4gZW50cmllcyB0byAxLgo+ PiAKPj4gSGF2aW5nIGltcGxlbWVudGVkIHRoaXMgaW4gcnBpIHBvcnQgb2YgZmZtcGVnIGFuZCB0 aGUgUlBpIFY0TDIgZHJpdmVyIEkKPj4gY2FuIHNheSB3aXRoIGV4cGVyaWVuY2UgdGhhdCB0aGUg Y29kZSBhbmQgZWZmb3J0IG92ZXJoZWFkIGlzIHZlcnkgbG93Lgo+PiAKPj4gRWl0aGVyIHdheSBo YXZpbmcgYSBtdWx0aXBsZSBzbGljZSBoZWFkZXIgY29udHJvbCBpbiB0aGUgVUFQSSBpcwo+PiBp bXBvcnRhbnQgZm9yIGVmZmljaWVuY3kuCj4KPkp1c3QgdG8gY2xhcmlmeSB0aGUgaWRlYSwgd2Ug d291bGQgaGF2ZSBhIHNpbmdsZSBzbGljZSBjb250cm9scywgYWx3YXlzIGR5bmFtaWM6Cj4KPjEu IEZvciBzbGljZWQgYmFzZWQgZGVjb2Rlcgo+Cj5UaGUgZHluYW1pYyBhcnJheSBzbGljZSBjb250 cm9sIGlzIGltcGxlbWVudGVkIGJ5IHRoZSBkcml2ZXIgYW5kIGl0cyBzaXplIG11c3QKPmJlIDEu CgpZZXMKCj4yLiBGb3IgZnJhbWUgYmFzZWQgZGVjb2RlciB0aGF0IGRvbid0IGNhcmUgZm9yIHNs aWNlcwo+Cj5UaGUgZHluYW1pYyBhcnJheSBzbGljZSBjb250cm9scyBpcyBub3QgaW1wbGVtZW50 LiBVc2VybGFuZCBkZXRlY3RzIHRoYXQgYXQKPnJ1bnRpbWUsIHNpbWlsYXIgdG8gdGhlIFZQOSBj b21wcmVzc2VkIGhlYWRlcnMuCgpJZiB0aGUgZHJpdmVyIHBhcnNlcyBhbGwgdGhlIHNsaWNlIGhl YWRlciB0aGVuIHRoYXQgc2VlbXMgcGxhdXNpYmxlCgo+My4gRm9yIGZyYW1lIGJhc2VkIGRlY29k ZXJzIHRoYXQgbmVlZHMgc2xpY2VzIChvciBkcml2ZXIgdGhhdCBzdXBwb3J0cyBvZmZzZXQKPmFu ZCBjYW4gZ2FpbiBwZXJmb3JtYW5jZSB3aXRoIHN1Y2ggbW9kZSkKPgo+VGhlIGR5bmFtaWMgYXJy YXkgc2xpY2UgY29udHJvbHMgaXMgaW1wbGVtZW50ZWQsIGFuZCBzaG91bGQgY29udGFpbiBhbGwg dGhlCj5zbGljZXMgZm91bmQgaW4gdGhlIE9VVFBVVCBidWZmZXIuCj4KPlNvIHRoZSByZWFzb24g Zm9yIHRoaXMgYml0X3NpemUgKG5vdCBzdXJlIHdoeSBpdHMgYml0cyB0aG91Z2gsIHBlcmhhcHMg c29tZW9uZQo+Y2FuIGVkdWNhdGUgbWUgPykKClJQaSBkb2Vzbid0IG5lZWQgYml0cyBhbmQgd291 bGQgYmUgaGFwcHkgd2l0aCBieXRlcyBob3dldmVyCnNsaWNlX3NlZ21lbnQgZGF0YSBpc24ndCBi eXRlIGFsaWduZWQgYXQgdGhlIGVuZCBzbyBpdHMgcG9zc2libGUgdGhhdAp0aGVyZSBtaWdodCBi ZSBkZWNvZGVycyBvdXQgdGhlcmUgdGhhdCB3YW50IGFuIGFjY3VyYXRlIGxlbmd0aCBmb3IgdGhh dC4KCj4gV291bGQgYmUgdG8gbGV0IHRoZSBkcml2ZXIgb2Zmc2V0IGluc2lkZSB0aGUgdGhlIHNp bmdsZQo+T1VUUFVUL2JpdHN0cmVhbSBidWZmZXIgaW4gY2FzZSB0aGlzIGlzIG5vdCBhdXRvbWF0 aWNhbGx5IGZvdW5kIGJ5IHRoZSBkcml2ZXIKPihvciB0aGF0IG5vIHN0YXJ0LWNvZGUgaXMgbmVl ZGVkKS4gSXMgdGhhdCBsYXN0IGJpdCBjb3JyZWN0ID8gSWYgc28sIHNob3VsZCB3ZQo+Y2hhbmdl IGl0IHRvIGFuIG9mZnNldCByYXRoZXIgdGhlbiBhIHNpemUgPyBTaGFsbCB3ZSBhbGxvdyB1c2lu ZyBvZmZlc2V0cyBpbnNpZGUKPmxhcmdlciBidWZmZXIgKGUuZy4gdG8gYXZvaWQgc29tZSBtZW1v cnkgY29waWVzKSBmb3IgdGhlIFNsaWNlZCBCYXNlIGNhc2VzID8KCkkgdXNlIChpbiB0aGUgY3Vy cmVudCBzdHJ1Y3R1cmUpIGRhdGFfYml0X29mZnNldCB0byBmaW5kIHRoZSBzdGFydCBvZgplYWNo IHNsaWNlJ3Mgc2xpY2Vfc2VnbWVudF9kYXRhIHdpdGhpbiB0aGUgT1VUUFVUIGJ1ZmZlciBhbmQg Yml0X3NpemUgdG8KZmluZCB0aGUgZW5kLiAgUlBpIGRvZXNuJ3QgLyBjYW4ndCBwYXJzZSB0aGUg c2xpY2VfaGVhZGVyIGFuZCBzbyB3YW50cwphbGwgb2YgdGhhdC4gIERlY29kZXJzIHRoYXQgZG8g cGFyc2UgdGhlIGhlYWRlciBtaWdodCBwbGF1c2FibHkgd2FudApoZWFkZXIgb2Zmc2V0cyB0b28g YW5kIGl0IHdvdWxkIGZhY2lsaXRhdGUgemVybyBjb3B5IG9mIHRoZSBiaXQgYnVmZmVyLgoKIAo+ PiBSZWdhcmRzCj4+IAo+PiBKb2huIENveAo+PiAKPj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogQmVu amFtaW4gR2FpZ25hcmQgPGJlbmphbWluLmdhaWduYXJkQGNvbGxhYm9yYS5jb20+Cj4+ID4gPiA+ IC0tLQo+PiA+ID4gPiAuLi4vdXNlcnNwYWNlLWFwaS9tZWRpYS92NGwvZXh0LWN0cmxzLWNvZGVj LnJzdCAgICAgICB8ICAzIC0tLQo+PiA+ID4gPiBkcml2ZXJzL3N0YWdpbmcvbWVkaWEvc3VueGkv Y2VkcnVzL2NlZHJ1c19oMjY1LmMgICAgICB8IDExICsrKystLS0tLS0tCj4+ID4gPiA+IGluY2x1 ZGUvdWFwaS9saW51eC92NGwyLWNvbnRyb2xzLmggICAgICAgICAgICAgICAgICAgIHwgIDMgKy0t Cj4+ID4gPiA+IDMgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMo LSkKPj4gPiA+ID4gCj4+ID4gPiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL3VzZXJzcGFj ZS1hcGkvbWVkaWEvdjRsL2V4dC1jdHJscy1jb2RlYy5yc3QgYi9Eb2N1bWVudGF0aW9uL3VzZXJz cGFjZS1hcGkvbWVkaWEvdjRsL2V4dC1jdHJscy1jb2RlYy5yc3QKPj4gPiA+ID4gaW5kZXggMzI5 NmFjM2I5ZmNhLi5jM2FlOTc2NTdmYTcgMTAwNjQ0Cj4+ID4gPiA+IC0tLSBhL0RvY3VtZW50YXRp b24vdXNlcnNwYWNlLWFwaS9tZWRpYS92NGwvZXh0LWN0cmxzLWNvZGVjLnJzdAo+PiA+ID4gPiAr KysgYi9Eb2N1bWVudGF0aW9uL3VzZXJzcGFjZS1hcGkvbWVkaWEvdjRsL2V4dC1jdHJscy1jb2Rl Yy5yc3QKPj4gPiA+ID4gQEAgLTI5NjUsOSArMjk2NSw2IEBAIGVudW0gdjRsMl9tcGVnX3ZpZGVv X2hldmNfc2l6ZV9vZl9sZW5ndGhfZmllbGQgLQo+PiA+ID4gPiAgICAgIDpzdHViLWNvbHVtbnM6 IDAKPj4gPiA+ID4gICAgICA6d2lkdGhzOiAgICAgICAxIDEgMgo+PiA+ID4gPiAKPj4gPiA+ID4g LSAgICAqIC0gX191MzIKPj4gPiA+ID4gLSAgICAgIC0gYGBiaXRfc2l6ZWBgCj4+ID4gPiA+IC0g ICAgICAtIFNpemUgKGluIGJpdHMpIG9mIHRoZSBjdXJyZW50IHNsaWNlIGRhdGEuCj4+ID4gPiA+ ICAgICAgKiAtIF9fdTMyCj4+ID4gPiA+ICAgICAgICAtIGBgZGF0YV9iaXRfb2Zmc2V0YGAKPj4g PiA+ID4gICAgICAgIC0gT2Zmc2V0IChpbiBiaXRzKSB0byB0aGUgdmlkZW8gZGF0YSBpbiB0aGUg Y3VycmVudCBzbGljZSBkYXRhLgo+PiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zdGFnaW5n L21lZGlhL3N1bnhpL2NlZHJ1cy9jZWRydXNfaDI2NS5jIGIvZHJpdmVycy9zdGFnaW5nL21lZGlh L3N1bnhpL2NlZHJ1cy9jZWRydXNfaDI2NS5jCj4+ID4gPiA+IGluZGV4IDhhYjJkOWM2ZjA0OC4u ZGI4Yzc0NzVlZWI4IDEwMDY0NAo+PiA+ID4gPiAtLS0gYS9kcml2ZXJzL3N0YWdpbmcvbWVkaWEv c3VueGkvY2VkcnVzL2NlZHJ1c19oMjY1LmMKPj4gPiA+ID4gKysrIGIvZHJpdmVycy9zdGFnaW5n L21lZGlhL3N1bnhpL2NlZHJ1cy9jZWRydXNfaDI2NS5jCj4+ID4gPiA+IEBAIC0zMTIsOCArMzEy LDggQEAgc3RhdGljIHZvaWQgY2VkcnVzX2gyNjVfc2V0dXAoc3RydWN0IGNlZHJ1c19jdHggKmN0 eCwKPj4gPiA+ID4gCWNvbnN0IHN0cnVjdCB2NGwyX2hldmNfcHJlZF93ZWlnaHRfdGFibGUgKnBy ZWRfd2VpZ2h0X3RhYmxlOwo+PiA+ID4gPiAJdW5zaWduZWQgaW50IHdpZHRoX2luX2N0Yl9sdW1h LCBjdGJfc2l6ZV9sdW1hOwo+PiA+ID4gPiAJdW5zaWduZWQgaW50IGxvZzJfbWF4X2x1bWFfY29k aW5nX2Jsb2NrX3NpemU7Cj4+ID4gPiA+ICsJc2l6ZV90IHNsaWNlX2J5dGVzOwo+PiA+ID4gPiAJ ZG1hX2FkZHJfdCBzcmNfYnVmX2FkZHI7Cj4+ID4gPiA+IC0JZG1hX2FkZHJfdCBzcmNfYnVmX2Vu ZF9hZGRyOwo+PiA+ID4gPiAJdTMyIGNocm9tYV9sb2cyX3dlaWdodF9kZW5vbTsKPj4gPiA+ID4g CXUzMiBvdXRwdXRfcGljX2xpc3RfaW5kZXg7Cj4+ID4gPiA+IAl1MzIgcGljX29yZGVyX2NudFsy XTsKPj4gPiA+ID4gQEAgLTM3MCw4ICszNzAsOCBAQCBzdGF0aWMgdm9pZCBjZWRydXNfaDI2NV9z ZXR1cChzdHJ1Y3QgY2VkcnVzX2N0eCAqY3R4LAo+PiA+ID4gPiAKPj4gPiA+ID4gCWNlZHJ1c193 cml0ZShkZXYsIFZFX0RFQ19IMjY1X0JJVFNfT0ZGU0VULCAwKTsKPj4gPiA+ID4gCj4+ID4gPiA+ IC0JcmVnID0gc2xpY2VfcGFyYW1zLT5iaXRfc2l6ZTsKPj4gPiA+ID4gLQljZWRydXNfd3JpdGUo ZGV2LCBWRV9ERUNfSDI2NV9CSVRTX0xFTiwgcmVnKTsKPj4gPiA+ID4gKwlzbGljZV9ieXRlcyA9 IHZiMl9nZXRfcGxhbmVfcGF5bG9hZCgmcnVuLT5zcmMtPnZiMl9idWYsIDApOwo+PiA+ID4gPiAr CWNlZHJ1c193cml0ZShkZXYsIFZFX0RFQ19IMjY1X0JJVFNfTEVOLCBzbGljZV9ieXRlcyk7Cj4+ ID4gPiBJIHRoaW5rIG9uZSBvZiB0aGVzZSBtdXN0IGJlIHdyb25nLiBiaXRfc2l6ZSBpcyBpbiBi aXRzLAo+PiA+ID4gdmIyX2dldF9wbGFuZV9wYXlsb2FkIGlzIGluIGJ5dGVzPwo+PiA+IAo+PiA+ IFlvdSBhcmUgcmlnaHQgaXQgc2hvdWxkIGJlIHZiMl9nZXRfcGxhbmVfcGF5bG9hZCgpICogOCB0 byBnZXQgdGhlIHNpemUgaW4gYml0cy4KPj4gPiAKPj4gPiBJIHdpbGwgY2hhbmdlIHRoYXQgaW4g djMuCj4+ID4gCj4+ID4gPiAKPj4gPiA+IFJlZ2FyZHMKPj4gPiA+IAo+PiA+ID4gSm9obiBDb3gK Pj4gPiA+ICAgCj4+ID4gPiA+IAkvKiBTb3VyY2UgYmVnaW5uaW5nIGFuZCBlbmQgYWRkcmVzc2Vz LiAqLwo+PiA+ID4gPiAKPj4gPiA+ID4gQEAgLTM4NCwxMCArMzg0LDcgQEAgc3RhdGljIHZvaWQg Y2VkcnVzX2gyNjVfc2V0dXAoc3RydWN0IGNlZHJ1c19jdHggKmN0eCwKPj4gPiA+ID4gCj4+ID4g PiA+IAljZWRydXNfd3JpdGUoZGV2LCBWRV9ERUNfSDI2NV9CSVRTX0FERFIsIHJlZyk7Cj4+ID4g PiA+IAo+PiA+ID4gPiAtCXNyY19idWZfZW5kX2FkZHIgPSBzcmNfYnVmX2FkZHIgKwo+PiA+ID4g PiAtCQkJICAgRElWX1JPVU5EX1VQKHNsaWNlX3BhcmFtcy0+Yml0X3NpemUsIDgpOwo+PiA+ID4g PiAtCj4+ID4gPiA+IC0JcmVnID0gVkVfREVDX0gyNjVfQklUU19FTkRfQUREUl9CQVNFKHNyY19i dWZfZW5kX2FkZHIpOwo+PiA+ID4gPiArCXJlZyA9IFZFX0RFQ19IMjY1X0JJVFNfRU5EX0FERFJf QkFTRShzcmNfYnVmX2FkZHIgKyBzbGljZV9ieXRlcyk7Cj4+ID4gPiA+IAljZWRydXNfd3JpdGUo ZGV2LCBWRV9ERUNfSDI2NV9CSVRTX0VORF9BRERSLCByZWcpOwo+PiA+ID4gPiAKPj4gPiA+ID4g CS8qIENvZGluZyB0cmVlIGJsb2NrIGFkZHJlc3MgKi8KPj4gPiA+ID4gZGlmZiAtLWdpdCBhL2lu Y2x1ZGUvdWFwaS9saW51eC92NGwyLWNvbnRyb2xzLmggYi9pbmNsdWRlL3VhcGkvbGludXgvdjRs Mi1jb250cm9scy5oCj4+ID4gPiA+IGluZGV4IGIxYTNkYzA1ZjAyZi4uMjdmNWQyNzJkYzQzIDEw MDY0NAo+PiA+ID4gPiAtLS0gYS9pbmNsdWRlL3VhcGkvbGludXgvdjRsMi1jb250cm9scy5oCj4+ ID4gPiA+ICsrKyBiL2luY2x1ZGUvdWFwaS9saW51eC92NGwyLWNvbnRyb2xzLmgKPj4gPiA+ID4g QEAgLTI0NTcsNyArMjQ1Nyw2IEBAIHN0cnVjdCB2NGwyX2hldmNfcHJlZF93ZWlnaHRfdGFibGUg ewo+PiA+ID4gPiAjZGVmaW5lIFY0TDJfSEVWQ19TTElDRV9QQVJBTVNfRkxBR19ERVBFTkRFTlRf U0xJQ0VfU0VHTUVOVAkoMVVMTCA8PCA5KQo+PiA+ID4gPiAKPj4gPiA+ID4gc3RydWN0IHY0bDJf Y3RybF9oZXZjX3NsaWNlX3BhcmFtcyB7Cj4+ID4gPiA+IC0JX191MzIJYml0X3NpemU7Cj4+ID4g PiA+IAlfX3UzMglkYXRhX2JpdF9vZmZzZXQ7Cj4+ID4gPiA+IAo+PiA+ID4gPiAJLyogSVNPL0lF QyAyMzAwOC0yLCBJVFUtVCBSZWMuIEguMjY1OiBOQUwgdW5pdCBoZWFkZXIgKi8KPj4gPiA+ID4g QEAgLTI0ODQsNyArMjQ4Myw3IEBAIHN0cnVjdCB2NGwyX2N0cmxfaGV2Y19zbGljZV9wYXJhbXMg ewo+PiA+ID4gPiAJLyogSVNPL0lFQyAyMzAwOC0yLCBJVFUtVCBSZWMuIEguMjY1OiBQaWN0dXJl IHRpbWluZyBTRUkgbWVzc2FnZSAqLwo+PiA+ID4gPiAJX191OAlwaWNfc3RydWN0Owo+PiA+ID4g PiAKPj4gPiA+ID4gLQlfX3U4CXJlc2VydmVkOwo+PiA+ID4gPiArCV9fdTgJcmVzZXJ2ZWRbNV07 Cj4+ID4gPiA+IAo+PiA+ID4gPiAJLyogSVNPL0lFQyAyMzAwOC0yLCBJVFUtVCBSZWMuIEguMjY1 OiBHZW5lcmFsIHNsaWNlIHNlZ21lbnQgaGVhZGVyICovCj4+ID4gPiA+IAlfX3UzMglzbGljZV9z ZWdtZW50X2FkZHI7CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg==